Plume/Plume
9
18
Derivar 24
Código Questões 177 Pedidos de integração 8 Lançamentos 8 Wiki Trabalho

Make database connections configurable by environment variables #768

Integrado
KitaitiMakoto integrou 4 cometimento(s) do ramo db-conns-conf no ramo master 2020-05-06 17:28:00 +00:00
Diálogo 2 Cometimentos 4 Ficheiros modificados 2 +16 -3
KitaitiMakoto comentou 2020-05-05 06:32:32 +00:00 (Migrado de github.com)
Copiar ligação

so that we can tune performance.

so that we can tune performance.
codecov[bot] comentou 2020-05-05 06:59:18 +00:00 (Migrado de github.com)
Copiar ligação

Codecov Report

Merging #768 into master will decrease coverage by 0.03%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   38.99%   38.96%   -0.04%     
==========================================
  Files          73       73              
  Lines        9721     9729       +8     
  Branches     2226     2227       +1     
==========================================
  Hits         3791     3791              
- Misses       4878     4885       +7     
- Partials     1052     1053       +1
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=h1) Report > Merging [#768](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/180e34b07c014a3a37b2031cf0532ee17104f47b&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `18.18%`. ```diff @@ Coverage Diff @@ ## master #768 +/- ## ========================================== - Coverage 38.99% 38.96% -0.04% ========================================== Files 73 73 Lines 9721 9729 +8 Branches 2226 2227 +1 ========================================== Hits 3791 3791 - Misses 4878 4885 +7 - Partials 1052 1053 +1 ```
elegaanz (Migrado de github.com) reviu 2020-05-05 21:45:21 +00:00
elegaanz (Migrado de github.com) deixou um comentário
Copiar ligação

Nice! I just have a small question, but otherwise it seems good to merge. Thanks!

Nice! I just have a small question, but otherwise it seems good to merge. Thanks!
plume-models/src/config.rs
elegaanz (Migrado de github.com) comentou 2020-05-05 21:43:59 +00:00
Copiar ligação

Is there a reason for panicking in one case and silently failing in the other?

Is there a reason for panicking in one case and silently failing in the other?
KitaitiMakoto (Migrado de github.com) reviu 2020-05-05 22:09:38 +00:00
plume-models/src/config.rs
KitaitiMakoto (Migrado de github.com) comentou 2020-05-05 22:09:38 +00:00
Copiar ligação

Good catch! There's no reason why. I will rewrite this and push it.

Good catch! There's no reason why. I will rewrite this and push it.
KitaitiMakoto (Migrado de github.com) reviu 2020-05-05 22:11:41 +00:00
plume-models/src/config.rs
KitaitiMakoto (Migrado de github.com) comentou 2020-05-05 22:11:41 +00:00
Copiar ligação

Done.

Done.
elegaanz (Migrado de github.com) aprovou estas modificações 2020-05-06 17:27:53 +00:00
elegaanz (Migrado de github.com) deixou um comentário
Copiar ligação

Great!

Great!
KitaitiMakoto comentou 2020-05-06 20:01:59 +00:00 (Migrado de github.com)
Copiar ligação

Thank you for the merge.

Thank you for the merge.
Inicie a sessão para participar neste diálogo.
Revisores
Sem revisores
elegaanz
Rótulos
Retirar rótulos   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

Sem rótulos
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Etapa
Limpar etapa
Sem itens
Sem etapa
Planeamentos
Limpar planeamentos
Sem itens
Nenhum planeamento
Encarregados
Retirar todos os encarregados
Sem encarregados
1 participante
Notificações
Data de vencimento
A data de vencimento é inválida ou está fora do intervalo permitido. Por favor, use o formato "aaaa-mm-dd".

Sem data de vencimento definida.

Dependências

Não estão definidas dependências.

Referência: Plume/Plume#768
Nenhuma descrição fornecida.
Eliminar o ramo "db-conns-conf"

Eliminar um ramo é algo permanente. Embora o ramo eliminado possa continuar a existir por um breve período de tempo antes de ser realmente removido, a operação NÃO PODERÁ ser desfeita na maioria dos casos. Quer continuar?