Plume
/
Plume
6
10
Derivar 9
Código Questões 134 Pedidos de integração 12 Lançamentos 5 Wiki Trabalho
Etiquetas Etapas
Novo pedido de integração

#768 Make database connections configurable by environment variables

Integração executada
KitaitiMakoto integrou 4 cometimentos de %!<(string=db-conns-conf)/code> em master há 8 meses
Diálogo 2 Cometimentos 4 Ficheiros modificados 2
KitaitiMakoto comentado há 8 meses (Migrado de github.com)

so that we can tune performance.

so that we can tune performance.
codecov[bot] comentado há 8 meses (Migrado de github.com)
Proprietário(a)

Codecov Report

Merging #768 into master will decrease coverage by 0.03%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   38.99%   38.96%   -0.04%     
==========================================
  Files          73       73              
  Lines        9721     9729       +8     
  Branches     2226     2227       +1     
==========================================
  Hits         3791     3791              
- Misses       4878     4885       +7     
- Partials     1052     1053       +1
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=h1) Report > Merging [#768](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/180e34b07c014a3a37b2031cf0532ee17104f47b&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `18.18%`. ```diff @@ Coverage Diff @@ ## master #768 +/- ## ========================================== - Coverage 38.99% 38.96% -0.04% ========================================== Files 73 73 Lines 9721 9729 +8 Branches 2226 2227 +1 ========================================== Hits 3791 3791 - Misses 4878 4885 +7 - Partials 1052 1053 +1 ```
elegaanz (Migrado de github.com) reviu há 8 meses
elegaanz (Migrado de github.com) deixou um comentário

Nice! I just have a small question, but otherwise it seems good to merge. Thanks!

plume-models/src/config.rs
Plume_migration_agent comentado há 8 meses

Is there a reason for panicking in one case and silently failing in the other?

Is there a reason for panicking in one case and silently failing in the other?
KitaitiMakoto (Migrado de github.com) reviu há 8 meses
plume-models/src/config.rs
Plume_migration_agent comentado há 8 meses

Good catch! There’s no reason why. I will rewrite this and push it.

Good catch! There's no reason why. I will rewrite this and push it.
KitaitiMakoto (Migrado de github.com) reviu há 8 meses
plume-models/src/config.rs
Plume_migration_agent comentado há 8 meses

Done.

Done.
elegaanz (Migrado de github.com) aprovou estas alterações há 8 meses
elegaanz (Migrado de github.com) deixou um comentário

Great!

KitaitiMakoto comentado há 8 meses (Migrado de github.com)
Proprietário(a)

Thank you for the merge.

Thank you for the merge.

Revisores

Plume_migration_agent aprovou estas alterações há 8 meses
A integração constante no pedido foi executada como 3be842c653.
Inicie a sessão para participar neste diálogo.
Revisores
Solicitar avaliação
Sem revisores
 Plume_migration_agent
Etiquetas
Aplicar etiquetas
Limpar etiquetas
A: API
Related to the REST API A: Backend
Code running on the server A: Federation
Stuff related to Federation A: Front-End
Related to the front-end A: I18N
Translations, and related code A: Meta
More about project management or code than the project itself A: Security Build
The building, or installation process of Plume C: Bug
Something isn't working C: Discussion
We need to talk C: Enhancement
New feature or request C: Feature
This is a new feature Compatibility
Compatibility with different browsers, readers and OS Dependency
Related to an external package that Plume uses Design
UI/UX related issues and PRs Documentation Good first issue
Good for newcomers Help welcome
Extra attention is needed Mobile
Issues affecting only mobile UX Rendering
How elements're rendered out for the end user S: Blocked
Something else needs to be fixed first S: Duplicate
This issue or pull request already exists S: Incomplete
This PR is not complete yet S: Instance specific
Issues concern a limited number of instances S: Invalid
This doesn't seem right S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio) S: Ready for review
This PR is ready to be reviewed Suggestion
Proposed ideas worth considering S: Voted on Loomio
This is issue has been created after a vote on Loomio S: Wontfix
This will not be worked on
Sem etiquetas
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Etapa
Definir etapa
Limpar etapa
Sem itens
Sem etapa
Responsáveis
Definir responsáveis
Limpar responsáveis
Sem responsáveis
1 Participantes
Notificações
Date limite

Sem data limite definida.

Dependências

Este pedido de integração não tem quaisquer dependências, neste momento.

Escrever Pré-visualizar
Carregando…
Cancelar
Guardar
Ainda não há conteúdo.
Eliminar o ramo 'db-conns-conf'

Eliminar um ramo é algo permanente. NÃO PODERÁ ser revertido. Quer continuar?

Não
Sim