Codecov Report

Merging #768 into master will decrease coverage by 0.03%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   38.99%   38.96%   -0.04%     
==========================================
  Files          73       73              
  Lines        9721     9729       +8     
  Branches     2226     2227       +1     
==========================================
  Hits         3791     3791              
- Misses       4878     4885       +7     
- Partials     1052     1053       +1

so that we can tune performance.

elegaanz (从 github.com 迁移) 评审于 8 个月前

Nice! I just have a small question, but otherwise it seems good to merge. Thanks!

plume-models/src/config.rs

Plume_migration_agent 评论于 8 个月前

Is there a reason for panicking in one case and silently failing in the other?

KitaitiMakoto (从 github.com 迁移) 评审于 8 个月前

Good catch! There’s no reason why. I will rewrite this and push it.

Done.

elegaanz (从 github.com 迁移) 已于 8 个月前批准这些更改

Great!

Thank you for the merge.

kiwii 于 5 个月前在代码提交中引用了该工单

Make database connections configurable by environment variables (#768) * Make env DB_MAX_SIZE and DB_MIN_IDLE recognizable * Make database max size and minimum idle configurable * Restore file permission * Fail fast

评审人

Plume_migration_agent 已于 8 个月前批准这些更改

该合并请求已作为 3be842c653 被合并。

登录并参与到对话中。

#768 Make database connections configurable by environment variables

Codecov Report

评审人