#768 Make database connections configurable by environment variables

已合并
KitaitiMakoto 8 个月前 将 4 次代码提交从 db-conns-conf合并至 master
KitaitiMakoto 评论于 8 个月前 (从 github.com 迁移)

so that we can tune performance.

so that we can tune performance.
codecov[bot] 评论于 8 个月前 (从 github.com 迁移)
所有者

Codecov Report

Merging #768 into master will decrease coverage by 0.03%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   38.99%   38.96%   -0.04%     
==========================================
  Files          73       73              
  Lines        9721     9729       +8     
  Branches     2226     2227       +1     
==========================================
  Hits         3791     3791              
- Misses       4878     4885       +7     
- Partials     1052     1053       +1     
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=h1) Report > Merging [#768](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/180e34b07c014a3a37b2031cf0532ee17104f47b&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `18.18%`. ```diff @@ Coverage Diff @@ ## master #768 +/- ## ========================================== - Coverage 38.99% 38.96% -0.04% ========================================== Files 73 73 Lines 9721 9729 +8 Branches 2226 2227 +1 ========================================== Hits 3791 3791 - Misses 4878 4885 +7 - Partials 1052 1053 +1 ```
elegaanz (从 github.com 迁移) 评审于 8 个月前
elegaanz (从 github.com 迁移) 留下了一条评论

Nice! I just have a small question, but otherwise it seems good to merge. Thanks!

Plume_migration_agent 评论于 8 个月前

Is there a reason for panicking in one case and silently failing in the other?

Is there a reason for panicking in one case and silently failing in the other?
KitaitiMakoto (从 github.com 迁移) 评审于 8 个月前
Plume_migration_agent 评论于 8 个月前

Good catch! There’s no reason why. I will rewrite this and push it.

Good catch! There's no reason why. I will rewrite this and push it.
KitaitiMakoto (从 github.com 迁移) 评审于 8 个月前
elegaanz (从 github.com 迁移) 已于 8 个月前 批准这些更改
elegaanz (从 github.com 迁移) 留下了一条评论

Great!

KitaitiMakoto 评论于 8 个月前 (从 github.com 迁移)
所有者

Thank you for the merge.

Thank you for the merge.

评审人

Plume_migration_agent 已于 8 个月前 批准这些更改
该合并请求已作为 3be842c653 被合并。
登录 并参与到对话中。
未选择里程碑
未指派成员
1 名参与者
通知
到期时间

未设置到期时间。

依赖工单

此合并请求当前没有任何依赖。

正在加载...
这个人很懒,什么都没留下。