Make database connections configurable by environment variables #768

已合并

KitaitiMakoto 于将 4 次代码提交从 db-conns-conf 合并至 master

KitaitiMakoto 评论于 (从 github.com 迁移)

so that we can tune performance.

codecov[bot] 评论于 (从 github.com 迁移)

Codecov Report

Merging #768 into master will decrease coverage by 0.03%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   38.99%   38.96%   -0.04%     
==========================================
  Files          73       73              
  Lines        9721     9729       +8     
  Branches     2226     2227       +1     
==========================================
  Hits         3791     3791              
- Misses       4878     4885       +7     
- Partials     1052     1053       +1

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=h1) Report > Merging [#768](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/180e34b07c014a3a37b2031cf0532ee17104f47b&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `18.18%`. ```diff @@ Coverage Diff @@ ## master #768 +/- ## ========================================== - Coverage 38.99% 38.96% -0.04% ========================================== Files 73 73 Lines 9721 9729 +8 Branches 2226 2227 +1 ========================================== Hits 3791 3791 - Misses 4878 4885 +7 - Partials 1052 1053 +1 ```

elegaanz (从 github.com 迁移) 评审于

elegaanz (从 github.com 迁移) 留下了一条评论

Nice! I just have a small question, but otherwise it seems good to merge. Thanks!

plume-models/src/config.rs

elegaanz (从 github.com 迁移) 评论于

Is there a reason for panicking in one case and silently failing in the other?

KitaitiMakoto (从 github.com 迁移) 评审于

plume-models/src/config.rs

KitaitiMakoto (从 github.com 迁移) 评论于

Good catch! There's no reason why. I will rewrite this and push it.

KitaitiMakoto (从 github.com 迁移) 评审于

plume-models/src/config.rs

KitaitiMakoto (从 github.com 迁移) 评论于

Done.

elegaanz (从 github.com 迁移) 于批准此合并请求

elegaanz (从 github.com 迁移) 留下了一条评论

Great!

KitaitiMakoto 评论于 (从 github.com 迁移)

Thank you for the merge.

kiwii 于在代码提交中引用了该工单

Make database connections configurable by environment variables (#768) * Make env DB_MAX_SIZE and DB_MIN_IDLE recognizable * Make database max size and minimum idle configurable * Restore file permission * Fail fast

评审人

该合并请求已作为 3be842c653 被合并。

你也可以查看命令行指令

第一步:

从你的仓库中签出一个新的分支并测试变更。

git checkout -b db-conns-conf master

git pull origin db-conns-conf

第二步：

合并变更并更新到 Forgejo 上

git checkout master

git merge --no-ff db-conns-conf

git push origin master

登录并参与到对话中。

无审核者

未选择里程碑

未指派成员

1 名参与者

通知

到期时间

到期日期无效或超出范围。请使用 'yyyy-mm-dd' 格式。

未设置到期时间。

依赖工单

没有设置依赖项。

正在加载...

这个人很懒，什么都没留下。

标签 里程碑

Make database connections configurable by environment variables #768

Codecov Report

评审人

第一步:

第二步：

标签里程碑