Make database connections configurable by environment variables #768

已合併
KitaitiMakoto 將 4 次提交從 db-conns-conf 合併至 master 4 年前
KitaitiMakoto 已留言 4 年前 (已從 github.com 遷移)

so that we can tune performance.

so that we can tune performance.
codecov[bot] 已留言 4 年前 (已從 github.com 遷移)

Codecov Report

Merging #768 into master will decrease coverage by 0.03%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   38.99%   38.96%   -0.04%     
==========================================
  Files          73       73              
  Lines        9721     9729       +8     
  Branches     2226     2227       +1     
==========================================
  Hits         3791     3791              
- Misses       4878     4885       +7     
- Partials     1052     1053       +1     
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=h1) Report > Merging [#768](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/180e34b07c014a3a37b2031cf0532ee17104f47b&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `18.18%`. ```diff @@ Coverage Diff @@ ## master #768 +/- ## ========================================== - Coverage 38.99% 38.96% -0.04% ========================================== Files 73 73 Lines 9721 9729 +8 Branches 2226 2227 +1 ========================================== Hits 3791 3791 - Misses 4878 4885 +7 - Partials 1052 1053 +1 ```
elegaanz (已從 github.com 遷移) 已審核 4 年前
elegaanz (已從 github.com 遷移) 留下了回應

Nice! I just have a small question, but otherwise it seems good to merge. Thanks!

Nice! I just have a small question, but otherwise it seems good to merge. Thanks!
elegaanz (已從 github.com 遷移) 已留言 4 年前

Is there a reason for panicking in one case and silently failing in the other?

Is there a reason for panicking in one case and silently failing in the other?
KitaitiMakoto (已從 github.com 遷移) 已審核 4 年前
KitaitiMakoto (已從 github.com 遷移) 已留言 4 年前

Good catch! There's no reason why. I will rewrite this and push it.

Good catch! There's no reason why. I will rewrite this and push it.
KitaitiMakoto (已從 github.com 遷移) 已審核 4 年前
KitaitiMakoto (已從 github.com 遷移) 已留言 4 年前

Done.

Done.
elegaanz (已從 github.com 遷移) 核可了這些變更 4 年前
elegaanz (已從 github.com 遷移) 留下了回應

Great!

Great!
KitaitiMakoto 已留言 4 年前 (已從 github.com 遷移)

Thank you for the merge.

Thank you for the merge.

審核者

此合併請求已被合併為 3be842c653
您也可以查看命令列指南

第一步:

在您的儲存庫中切換到新分支並測試變更。
git checkout -b db-conns-conf master
git pull origin db-conns-conf

第二步:

合併變更並更新到 Forgejo。
git checkout master
git merge --no-ff db-conns-conf
git push origin master
登入 才能加入這對話。
沒有審核者
未選擇里程碑
沒有負責人
1 參與者
通知
截止日期
截止日期無效或超出範圍,請使用「yyyy-mm-dd」的格式。

未設定截止日期。

先決條件

未設定先決條件。

參考: Plume/Plume#768
載入中…
尚未有任何內容