Plume/Plume
9
18
分叉 24
程式碼 問題 177 合併請求 8 版本發布 8 Wiki 動態

Make database connections configurable by environment variables #768

已合併
KitaitiMakoto 於 2020-05-06 17:28:00 +00:00 自 db-conns-conf 合併了 4 個提交至 master
對話內容 2 程式碼提交 4 檔案變動 2 +16 -3
KitaitiMakoto 已留言 2020-05-05 06:32:32 +00:00 (已從 github.com 遷移)
複製連結

so that we can tune performance.

so that we can tune performance.
codecov[bot] 已留言 2020-05-05 06:59:18 +00:00 (已從 github.com 遷移)
複製連結

Codecov Report

Merging #768 into master will decrease coverage by 0.03%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   38.99%   38.96%   -0.04%     
==========================================
  Files          73       73              
  Lines        9721     9729       +8     
  Branches     2226     2227       +1     
==========================================
  Hits         3791     3791              
- Misses       4878     4885       +7     
- Partials     1052     1053       +1
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=h1) Report > Merging [#768](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/180e34b07c014a3a37b2031cf0532ee17104f47b&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `18.18%`. ```diff @@ Coverage Diff @@ ## master #768 +/- ## ========================================== - Coverage 38.99% 38.96% -0.04% ========================================== Files 73 73 Lines 9721 9729 +8 Branches 2226 2227 +1 ========================================== Hits 3791 3791 - Misses 4878 4885 +7 - Partials 1052 1053 +1 ```
elegaanz (已從 github.com 遷移) 已審核 2020-05-05 21:45:21 +00:00
elegaanz (已從 github.com 遷移) 留下了回應
複製連結

Nice! I just have a small question, but otherwise it seems good to merge. Thanks!

Nice! I just have a small question, but otherwise it seems good to merge. Thanks!
plume-models/src/config.rs
elegaanz (已從 github.com 遷移) 已留言 2020-05-05 21:43:59 +00:00
複製連結

Is there a reason for panicking in one case and silently failing in the other?

Is there a reason for panicking in one case and silently failing in the other?
KitaitiMakoto (已從 github.com 遷移) 已審核 2020-05-05 22:09:38 +00:00
plume-models/src/config.rs
KitaitiMakoto (已從 github.com 遷移) 已留言 2020-05-05 22:09:38 +00:00
複製連結

Good catch! There's no reason why. I will rewrite this and push it.

Good catch! There's no reason why. I will rewrite this and push it.
KitaitiMakoto (已從 github.com 遷移) 已審核 2020-05-05 22:11:41 +00:00
plume-models/src/config.rs
KitaitiMakoto (已從 github.com 遷移) 已留言 2020-05-05 22:11:41 +00:00
複製連結

Done.

Done.
elegaanz (已從 github.com 遷移) 核可了這些變更 2020-05-06 17:27:53 +00:00
elegaanz (已從 github.com 遷移) 留下了回應
複製連結

Great!

Great!
KitaitiMakoto 已留言 2020-05-06 20:01:59 +00:00 (已從 github.com 遷移)
複製連結

Thank you for the merge.

Thank you for the merge.
登入 才能加入這對話。
審核者
沒有審核者
elegaanz
標籤
清除已選取標籤   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

未選擇標籤
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
里程碑
清除已選取里程碑
沒有項目
沒有里程碑
專案
清除已選取專案
沒有項目
未選擇專案
負責人
清除負責人
沒有負責人
1 位參與者
通知
截止日期
截止日期無效或超出範圍，請使用「yyyy-mm-dd」的格式。

未設定截止日期。

先決條件

未設定先決條件。

參考: Plume/Plume#768
沒有提供敘述。
刪除分支「db-conns-conf」

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?