Plume
/
Plume
5
12
Fork 12
Code Issues 154 Pull Requests 5 Releases 5 Wiki Activity
Labels Milestones
New Pull Request

Don't show boosts and likes for "all" and "local" in timelines #781

Merged
elegaanz merged 1 commits from dedup-articles into master 1 year ago
Conversation 2 Commits 1 Files Changed 1
elegaanz commented 1 year ago (Migrated from github.com)
Owner

The fix was quite easy actually 😅 I think it is just that it wasn't clear enough for us that local/all shouldn't match boosts and likes, but only new posts.

Fixes #711

The fix was quite easy actually :sweat_smile: I think it is just that it wasn't clear enough for us that `local`/`all` shouldn't match boosts and likes, but only new posts. Fixes #711
igalic (Migrated from github.com) approved these changes 1 year ago
codecov[bot] commented 1 year ago (Migrated from github.com)
Owner

Codecov Report

Merging #781 into master will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #781      +/-   ##
==========================================
- Coverage   39.08%   39.07%   -0.02%     
==========================================
  Files          73       73              
  Lines        9736     9736              
  Branches     2227     2227              
==========================================
- Hits         3805     3804       -1     
+ Misses       4879     4878       -1     
- Partials     1052     1054       +2
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/781?src=pr&el=h1) Report > Merging [#781](https://codecov.io/gh/Plume-org/Plume/pull/781?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/ef70cb93e6d9457355bce4f6dae485c700bb07c6&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `50.00%`. ```diff @@ Coverage Diff @@ ## master #781 +/- ## ========================================== - Coverage 39.08% 39.07% -0.02% ========================================== Files 73 73 Lines 9736 9736 Branches 2227 2227 ========================================== - Hits 3805 3804 -1 + Misses 4879 4878 -1 - Partials 1052 1054 +2 ```
Chostakovitch commented 1 year ago (Migrated from github.com)
Owner

Marvellous ! Thank you ! :D

Marvellous ! Thank you ! :D

Reviewers

igalic
The pull request has been merged as 297d9fcf40.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
igalic
Labels
Apply labels
Clear labels
A: API
Related to the REST API A: Backend
Code running on the server A: Federation
Stuff related to Federation A: Front-End
Related to the front-end A: I18N
Translations, and related code A: Meta
More about project management or code than the project itself A: Security Build
The building, or installation process of Plume C: Bug
Something isn't working C: Discussion
We need to talk C: Enhancement
New feature or request C: Feature
This is a new feature Compatibility
Compatibility with different browsers, readers and OS Dependency
Related to an external package that Plume uses Design
UI/UX related issues and PRs Documentation Good first issue
Good for newcomers Help welcome
Extra attention is needed Mobile
Issues affecting only mobile UX Rendering
How elements're rendered out for the end user S: Blocked
Something else needs to be fixed first S: Duplicate
This issue or pull request already exists S: Incomplete
This PR is not complete yet S: Instance specific
Issues concern a limited number of instances S: Invalid
This doesn't seem right S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio) S: Ready for review
This PR is ready to be reviewed Suggestion
Proposed ideas worth considering S: Voted on Loomio
This is issue has been created after a vote on Loomio S: Wontfix
This will not be worked on
No Label A: API A: Backend A: Federation A: Front-End A: I18N A: Meta A: Security Build C: Bug C: Discussion C: Enhancement C: Feature Compatibility Dependency Design Documentation Good first issue Help welcome Mobile Rendering S: Blocked S: Duplicate S: Incomplete S: Instance specific S: Invalid S: Needs Voting/Discussion S: Ready for review Suggestion S: Voted on Loomio S: Wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'dedup-articles'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes