Plume
/
Plume
8
16
Fork 22
Code Issues 174 Pull Requests 8 Releases 8 Wiki Activity

Labels Milestones

Add Vazir Font #787

Merged
theMasix merged 4 commits from theMasix into master 4 years ago
Conversation 1 Commits 4 Files Changed 51
theMasix commented 4 years ago (Migrated from github.com)

I added the Vazir Font based on a request from #783

I added the [Vazir Font](https://github.com/rastikerdar/vazir-font) based on a request from #783
igalic (Migrated from github.com) reviewed 4 years ago
igalic (Migrated from github.com) left a comment

👀

👀
assets/themes/default/_variables.scss
igalic (Migrated from github.com) commented 4 years ago

as long as the lines don't get excessively long, why not keep this inline?

as long as the lines don't get excessively long, why not keep this inline?
assets/themes/default/dark.scss
@ -4,3 +3,1 @@
@import url('./fonts/Route159/Route159.css');
@import url('./fonts/Lora/Lora.css');
@import url('./fonts/Playfair_Display/PlayfairDisplay.css');
@import url("./feather.css");
igalic (Migrated from github.com) commented 4 years ago

what's the license are these files?

what's the license are these files?
codecov[bot] commented 4 years ago (Migrated from github.com)

Codecov Report

Merging #787 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #787      +/-   ##
==========================================
- Coverage   39.09%   39.08%   -0.02%     
==========================================
  Files          73       73              
  Lines        9756     9756              
  Branches     2233     2233              
==========================================
- Hits         3814     3813       -1     
  Misses       4885     4885              
- Partials     1057     1058       +1
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/787?src=pr&el=h1) Report > Merging [#787](https://codecov.io/gh/Plume-org/Plume/pull/787?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/d99b42582d7a5a8c8087b6ebe067b944cae0c294&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #787 +/- ## ========================================== - Coverage 39.09% 39.08% -0.02% ========================================== Files 73 73 Lines 9756 9756 Branches 2233 2233 ========================================== - Hits 3814 3813 -1 Misses 4885 4885 - Partials 1057 1058 +1 ```
theMasix (Migrated from github.com) reviewed 4 years ago
assets/themes/default/_variables.scss
theMasix (Migrated from github.com) commented 4 years ago

VSCode Prettier extension did this.

VSCode Prettier extension did this.
theMasix (Migrated from github.com) reviewed 4 years ago
assets/themes/default/dark.scss
@ -4,3 +3,1 @@
@import url('./fonts/Route159/Route159.css');
@import url('./fonts/Lora/Lora.css');
@import url('./fonts/Playfair_Display/PlayfairDisplay.css');
@import url("./feather.css");
theMasix (Migrated from github.com) commented 4 years ago

License added.

License added.
igalic (Migrated from github.com) reviewed 4 years ago
assets/themes/default/_variables.scss
igalic (Migrated from github.com) commented 4 years ago

since i'm not sure it's that much "prettier", or more readable for that matter, could we put this back into one line each?

after that it should be good to merge

since i'm not sure it's that much "prettier", or more readable for that matter, could we put this back into one line each? after that it should be good to merge
theMasix (Migrated from github.com) reviewed 4 years ago
assets/themes/default/_variables.scss
theMasix (Migrated from github.com) commented 4 years ago

fixed.

fixed.
elegaanz (Migrated from github.com) reviewed 4 years ago
elegaanz (Migrated from github.com) left a comment

Thank you for your PR! 😊 I still have a small change request, and then we should be good to merge!

Thank you for your PR! :blush: I still have a small change request, and then we should be good to merge!
assets/themes/default/_variables.scss
elegaanz (Migrated from github.com) commented 4 years ago

This font is for the interface. Maybe you could also import the Shabnam font as suggested in #783 instead of Vizir for this one? This can be done in another PR, but if you don't want to do it in this one, could you at least restore Route159? It looks like there are some margin issues with this font on some buttons (but not in other places strangely).

bildo

(it is quite subtle, but the text is not perfectly centered vertically)

This font is for the interface. Maybe you could also import the Shabnam font as suggested in #783 instead of Vizir for this one? This can be done in another PR, but if you don't want to do it in this one, could you at least restore Route159? It looks like there are some margin issues with this font on some buttons (but not in other places strangely). ![bildo](https://user-images.githubusercontent.com/16254623/85204173-e0c4d280-b312-11ea-8d19-b770e04a0841.png) (it is quite subtle, but the text is not perfectly centered vertically)
igalic (Migrated from github.com) reviewed 4 years ago
assets/themes/default/_variables.scss
igalic (Migrated from github.com) commented 4 years ago

could we do what was suggested and only enable this for certain Unicode ranges?

could we do what was suggested and only enable this for certain Unicode ranges?
igalic (Migrated from github.com) reviewed 4 years ago
igalic (Migrated from github.com) left a comment

🙋‍♀️

🙋‍♀️
assets/themes/default/fonts/Vazir_WOL/Vazir_WOL.css
@ -0,0 +6,4 @@
url('Vazir-WOL.woff') format('woff'),
url('Vazir-WOL.ttf') format('truetype');
font-weight: normal;
font-style: normal;
igalic (Migrated from github.com) commented 4 years ago

we could add unicode-range here
unfortunately, those being the same as Arabic, might break Arabic texts.
@DearRude, what do you think?

we could add `unicode-range` here unfortunately, those being the same as Arabic, might break Arabic texts. @DearRude, what do you think?
DearRude (Migrated from github.com) reviewed 4 years ago
assets/themes/default/fonts/Vazir_WOL/Vazir_WOL.css
@ -0,0 +6,4 @@
url('Vazir-WOL.woff') format('woff'),
url('Vazir-WOL.ttf') format('truetype');
font-weight: normal;
font-style: normal;
DearRude (Migrated from github.com) commented 4 years ago

Just like English and German, Persian and Arabic have common characters. We would not be able to cut down Arabic by unicode-range.
However, I suggest using Vazir and Shamim fonts for Arabic too. Since those fonts fully support Arabic and have been used in other projects in Arabic, I won't be a bad idea if we support both.

I can provide range of unicode in Persian and Arabic together if needed.

Just like English and German, Persian and Arabic have common characters. We would not be able to cut down Arabic by `unicode-range`. However, I suggest using Vazir and Shamim fonts for Arabic too. Since those fonts fully support Arabic and have been used in other projects in Arabic, I won't be a bad idea if we support both. I can provide range of unicode in Persian and Arabic together if needed.
DearRude (Migrated from github.com) reviewed 4 years ago
assets/themes/default/_variables.scss
DearRude (Migrated from github.com) commented 4 years ago

I believe using non-Latin one would have the same effect. If we prioritize it, only Persian and Arabic chars will be effected.

I believe using [non-Latin](https://github.com/rastikerdar/vazir-font/tree/master/dist/Farsi-Digits-Without-Latin) one would have the same effect. If we prioritize it, only Persian and Arabic chars will be effected.
igalic (Migrated from github.com) reviewed 4 years ago
assets/themes/default/fonts/Vazir_WOL/Vazir_WOL.css
@ -0,0 +6,4 @@
url('Vazir-WOL.woff') format('woff'),
url('Vazir-WOL.ttf') format('truetype');
font-weight: normal;
font-style: normal;
igalic (Migrated from github.com) commented 4 years ago

the ranges are well documented, https://en.m.wikipedia.org/wiki/Arabic_script_in_Unicode but excessive
so i think we should use the non-Latin variants of the scripts.

the ranges are well documented, https://en.m.wikipedia.org/wiki/Arabic_script_in_Unicode but excessive so i think we should use the non-Latin variants of the scripts.
theMasix (Migrated from github.com) reviewed 4 years ago
assets/themes/default/fonts/Vazir_WOL/Vazir_WOL.css
@ -0,0 +6,4 @@
url('Vazir-WOL.woff') format('woff'),
url('Vazir-WOL.ttf') format('truetype');
font-weight: normal;
font-style: normal;
theMasix (Migrated from github.com) commented 4 years ago

This Vazir-WOL is a non-latin package. But as @dearrude said, Persian and Arabic has some common characters.

This ```Vazir-WOL``` is a non-latin package. But as @dearrude said, Persian and Arabic has some common characters.
igalic (Migrated from github.com) reviewed 4 years ago
assets/themes/default/fonts/Vazir_WOL/Vazir_WOL.css
@ -0,0 +6,4 @@
url('Vazir-WOL.woff') format('woff'),
url('Vazir-WOL.ttf') format('truetype');
font-weight: normal;
font-style: normal;
igalic (Migrated from github.com) commented 4 years ago

WOL ➡️ Without Latin

so how come @elegaanz noticed those issues with the centering of the text? what's going on?

WOL ➡️ Without Latin so how come @elegaanz noticed those issues with the centering of the text? what's going on?
theMasix (Migrated from github.com) reviewed 4 years ago
assets/themes/default/fonts/Vazir_WOL/Vazir_WOL.css
@ -0,0 +6,4 @@
url('Vazir-WOL.woff') format('woff'),
url('Vazir-WOL.ttf') format('truetype');
font-weight: normal;
font-style: normal;
theMasix (Migrated from github.com) commented 4 years ago

As @elegaanz said, It's an strange issue and I don't know if Shabnam could fix it or not!

As @elegaanz said, It's an strange issue and I don't know if ```Shabnam``` could fix it or not!
igalic (Migrated from github.com) reviewed 4 years ago
assets/themes/default/fonts/Vazir_WOL/Vazir_WOL.css
@ -0,0 +6,4 @@
url('Vazir-WOL.woff') format('woff'),
url('Vazir-WOL.ttf') format('truetype');
font-weight: normal;
font-style: normal;
igalic (Migrated from github.com) commented 4 years ago

let's try!

let's try!
theMasix (Migrated from github.com) reviewed 4 years ago
assets/themes/default/fonts/Vazir_WOL/Vazir_WOL.css
@ -0,0 +6,4 @@
url('Vazir-WOL.woff') format('woff'),
url('Vazir-WOL.ttf') format('truetype');
font-weight: normal;
font-style: normal;
theMasix (Migrated from github.com) commented 4 years ago

Shabnam-WOL Added. @igalic @elegaanz

```Shabnam-WOL``` Added. @igalic @elegaanz
elegaanz (Migrated from github.com) approved these changes 4 years ago
elegaanz (Migrated from github.com) left a comment

Perfect! Thank you!

Perfect! Thank you!

Reviewers

elegaanz
The pull request has been merged as 28576c1fa3.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b theMasix master
git pull origin theMasix

Step 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff theMasix
git push origin master
Sign in to join this conversation.
Reviewers
Request review
No reviewers
elegaanz
Labels
Apply labels
Clear labels   
A: API

Related to the REST API   
A: Backend

Code running on the server   
A: Federation

Stuff related to Federation   
A: Front-End

Related to the front-end   
A: I18N

Translations, and related code   
A: Meta

More about project management or code than the project itself   
A: Security
   
Build

The building, or installation process of Plume   
C: Bug

Something isn't working   
C: Discussion

We need to talk   
C: Enhancement

New feature or request   
C: Feature

This is a new feature   
Compatibility

Compatibility with different browsers, readers and OS   
Dependency

Related to an external package that Plume uses   
Design

UI/UX related issues and PRs   
Documentation
   
Good first issue

Good for newcomers   
Help welcome

Extra attention is needed   
Mobile

Issues affecting only mobile UX   
Rendering

How elements're rendered out for the end user   
S: Blocked

Something else needs to be fixed first   
S: Duplicate

This issue or pull request already exists   
S: Incomplete

This PR is not complete yet   
S: Instance specific

Issues concern a limited number of instances   
S: Invalid

This doesn't seem right   
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)   
S: Ready for review

This PR is ready to be reviewed   
Suggestion

Proposed ideas worth considering   
S: Voted on Loomio

This is issue has been created after a vote on Loomio   
S: Wontfix

This will not be worked on
No Label
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#787
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'theMasix'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes