Plume/Plume
9
18
フォーク 24
コード イシュー 177 プルリクエスト 8 リリース 8 Wiki アクティビティ

Add Vazir Font #787

マージ済み
theMasix が 4 個のコミットを theMasix から master へマージ 2020-06-24 13:48:05 +00:00
会話 1 コミット 4 変更されたファイル 51 +290 -27
theMasix がコメント 2020-06-20 09:33:23 +00:00 (github.comから移行)
リンクをコピー

I added the Vazir Font based on a request from #783

I added the [Vazir Font](https://github.com/rastikerdar/vazir-font) based on a request from #783
igalic (github.comから移行) がレビュー 2020-06-20 10:06:52 +00:00
igalic (github.comから移行) がコメント
リンクをコピー

👀

👀
assets/themes/default/_variables.scss
igalic (github.comから移行) がコメント 2020-06-20 09:56:47 +00:00
リンクをコピー

as long as the lines don't get excessively long, why not keep this inline?

as long as the lines don't get excessively long, why not keep this inline?
assets/themes/default/dark.scss
@ -4,3 +3,1 @@
@import url('./fonts/Route159/Route159.css');
@import url('./fonts/Lora/Lora.css');
@import url('./fonts/Playfair_Display/PlayfairDisplay.css');
@import url("./feather.css");
igalic (github.comから移行) がコメント 2020-06-20 10:06:37 +00:00
リンクをコピー

what's the license are these files?

what's the license are these files?
codecov[bot] がコメント 2020-06-20 10:08:43 +00:00 (github.comから移行)
リンクをコピー

Codecov Report

Merging #787 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #787      +/-   ##
==========================================
- Coverage   39.09%   39.08%   -0.02%     
==========================================
  Files          73       73              
  Lines        9756     9756              
  Branches     2233     2233              
==========================================
- Hits         3814     3813       -1     
  Misses       4885     4885              
- Partials     1057     1058       +1
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/787?src=pr&el=h1) Report > Merging [#787](https://codecov.io/gh/Plume-org/Plume/pull/787?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/d99b42582d7a5a8c8087b6ebe067b944cae0c294&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #787 +/- ## ========================================== - Coverage 39.09% 39.08% -0.02% ========================================== Files 73 73 Lines 9756 9756 Branches 2233 2233 ========================================== - Hits 3814 3813 -1 Misses 4885 4885 - Partials 1057 1058 +1 ```
theMasix (github.comから移行) がレビュー 2020-06-20 10:42:37 +00:00
assets/themes/default/_variables.scss
theMasix (github.comから移行) がコメント 2020-06-20 10:42:37 +00:00
リンクをコピー

VSCode Prettier extension did this.

VSCode Prettier extension did this.
theMasix (github.comから移行) がレビュー 2020-06-20 10:48:00 +00:00
assets/themes/default/dark.scss
@ -4,3 +3,1 @@
@import url('./fonts/Route159/Route159.css');
@import url('./fonts/Lora/Lora.css');
@import url('./fonts/Playfair_Display/PlayfairDisplay.css');
@import url("./feather.css");
theMasix (github.comから移行) がコメント 2020-06-20 10:48:00 +00:00
リンクをコピー

License added.

License added.
igalic (github.comから移行) がレビュー 2020-06-20 11:23:35 +00:00
assets/themes/default/_variables.scss
igalic (github.comから移行) がコメント 2020-06-20 11:23:35 +00:00
リンクをコピー

since i'm not sure it's that much "prettier", or more readable for that matter, could we put this back into one line each?

after that it should be good to merge

since i'm not sure it's that much "prettier", or more readable for that matter, could we put this back into one line each? after that it should be good to merge
theMasix (github.comから移行) がレビュー 2020-06-20 12:18:59 +00:00
assets/themes/default/_variables.scss
theMasix (github.comから移行) がコメント 2020-06-20 12:18:58 +00:00
リンクをコピー

fixed.

fixed.
elegaanz (github.comから移行) がレビュー 2020-06-20 14:28:06 +00:00
elegaanz (github.comから移行) がコメント
リンクをコピー

Thank you for your PR! 😊 I still have a small change request, and then we should be good to merge!

Thank you for your PR! :blush: I still have a small change request, and then we should be good to merge!
assets/themes/default/_variables.scss
elegaanz (github.comから移行) がコメント 2020-06-20 14:27:28 +00:00
リンクをコピー

This font is for the interface. Maybe you could also import the Shabnam font as suggested in #783 instead of Vizir for this one? This can be done in another PR, but if you don't want to do it in this one, could you at least restore Route159? It looks like there are some margin issues with this font on some buttons (but not in other places strangely).

bildo

(it is quite subtle, but the text is not perfectly centered vertically)

This font is for the interface. Maybe you could also import the Shabnam font as suggested in #783 instead of Vizir for this one? This can be done in another PR, but if you don't want to do it in this one, could you at least restore Route159? It looks like there are some margin issues with this font on some buttons (but not in other places strangely). ![bildo](https://user-images.githubusercontent.com/16254623/85204173-e0c4d280-b312-11ea-8d19-b770e04a0841.png) (it is quite subtle, but the text is not perfectly centered vertically)
igalic (github.comから移行) がレビュー 2020-06-20 14:44:39 +00:00
assets/themes/default/_variables.scss
igalic (github.comから移行) がコメント 2020-06-20 14:44:39 +00:00
リンクをコピー

could we do what was suggested and only enable this for certain Unicode ranges?

could we do what was suggested and only enable this for certain Unicode ranges?
igalic (github.comから移行) がレビュー 2020-06-20 18:05:09 +00:00
igalic (github.comから移行) がコメント
リンクをコピー

🙋‍♀️

🙋‍♀️
assets/themes/default/fonts/Vazir_WOL/Vazir_WOL.css
@ -0,0 +6,4 @@
url('Vazir-WOL.woff') format('woff'),
url('Vazir-WOL.ttf') format('truetype');
font-weight: normal;
font-style: normal;
igalic (github.comから移行) がコメント 2020-06-20 18:04:41 +00:00
リンクをコピー

we could add unicode-range here
unfortunately, those being the same as Arabic, might break Arabic texts.
@DearRude, what do you think?

we could add `unicode-range` here unfortunately, those being the same as Arabic, might break Arabic texts. @DearRude, what do you think?
DearRude (github.comから移行) がレビュー 2020-06-22 03:18:07 +00:00
assets/themes/default/fonts/Vazir_WOL/Vazir_WOL.css
@ -0,0 +6,4 @@
url('Vazir-WOL.woff') format('woff'),
url('Vazir-WOL.ttf') format('truetype');
font-weight: normal;
font-style: normal;
DearRude (github.comから移行) がコメント 2020-06-22 03:18:07 +00:00
リンクをコピー

Just like English and German, Persian and Arabic have common characters. We would not be able to cut down Arabic by unicode-range.
However, I suggest using Vazir and Shamim fonts for Arabic too. Since those fonts fully support Arabic and have been used in other projects in Arabic, I won't be a bad idea if we support both.

I can provide range of unicode in Persian and Arabic together if needed.

Just like English and German, Persian and Arabic have common characters. We would not be able to cut down Arabic by `unicode-range`. However, I suggest using Vazir and Shamim fonts for Arabic too. Since those fonts fully support Arabic and have been used in other projects in Arabic, I won't be a bad idea if we support both. I can provide range of unicode in Persian and Arabic together if needed.
DearRude (github.comから移行) がレビュー 2020-06-22 03:21:11 +00:00
assets/themes/default/_variables.scss
DearRude (github.comから移行) がコメント 2020-06-22 03:21:11 +00:00
リンクをコピー

I believe using non-Latin one would have the same effect. If we prioritize it, only Persian and Arabic chars will be effected.

I believe using [non-Latin](https://github.com/rastikerdar/vazir-font/tree/master/dist/Farsi-Digits-Without-Latin) one would have the same effect. If we prioritize it, only Persian and Arabic chars will be effected.
igalic (github.comから移行) がレビュー 2020-06-22 05:17:38 +00:00
assets/themes/default/fonts/Vazir_WOL/Vazir_WOL.css
@ -0,0 +6,4 @@
url('Vazir-WOL.woff') format('woff'),
url('Vazir-WOL.ttf') format('truetype');
font-weight: normal;
font-style: normal;
igalic (github.comから移行) がコメント 2020-06-22 05:17:38 +00:00
リンクをコピー

the ranges are well documented, https://en.m.wikipedia.org/wiki/Arabic_script_in_Unicode but excessive
so i think we should use the non-Latin variants of the scripts.

the ranges are well documented, https://en.m.wikipedia.org/wiki/Arabic_script_in_Unicode but excessive so i think we should use the non-Latin variants of the scripts.
theMasix (github.comから移行) がレビュー 2020-06-22 09:48:27 +00:00
assets/themes/default/fonts/Vazir_WOL/Vazir_WOL.css
@ -0,0 +6,4 @@
url('Vazir-WOL.woff') format('woff'),
url('Vazir-WOL.ttf') format('truetype');
font-weight: normal;
font-style: normal;
theMasix (github.comから移行) がコメント 2020-06-22 09:48:26 +00:00
リンクをコピー

This Vazir-WOL is a non-latin package. But as @dearrude said, Persian and Arabic has some common characters.

This ```Vazir-WOL``` is a non-latin package. But as @dearrude said, Persian and Arabic has some common characters.
igalic (github.comから移行) がレビュー 2020-06-22 10:36:25 +00:00
assets/themes/default/fonts/Vazir_WOL/Vazir_WOL.css
@ -0,0 +6,4 @@
url('Vazir-WOL.woff') format('woff'),
url('Vazir-WOL.ttf') format('truetype');
font-weight: normal;
font-style: normal;
igalic (github.comから移行) がコメント 2020-06-22 10:36:25 +00:00
リンクをコピー

WOL ➡️ Without Latin

so how come @elegaanz noticed those issues with the centering of the text? what's going on?

WOL ➡️ Without Latin so how come @elegaanz noticed those issues with the centering of the text? what's going on?
theMasix (github.comから移行) がレビュー 2020-06-22 11:21:58 +00:00
assets/themes/default/fonts/Vazir_WOL/Vazir_WOL.css
@ -0,0 +6,4 @@
url('Vazir-WOL.woff') format('woff'),
url('Vazir-WOL.ttf') format('truetype');
font-weight: normal;
font-style: normal;
theMasix (github.comから移行) がコメント 2020-06-22 11:21:58 +00:00
リンクをコピー

As @elegaanz said, It's an strange issue and I don't know if Shabnam could fix it or not!

As @elegaanz said, It's an strange issue and I don't know if ```Shabnam``` could fix it or not!
igalic (github.comから移行) がレビュー 2020-06-22 11:39:15 +00:00
assets/themes/default/fonts/Vazir_WOL/Vazir_WOL.css
@ -0,0 +6,4 @@
url('Vazir-WOL.woff') format('woff'),
url('Vazir-WOL.ttf') format('truetype');
font-weight: normal;
font-style: normal;
igalic (github.comから移行) がコメント 2020-06-22 11:39:15 +00:00
リンクをコピー

let's try!

let's try!
theMasix (github.comから移行) がレビュー 2020-06-23 19:55:48 +00:00
assets/themes/default/fonts/Vazir_WOL/Vazir_WOL.css
@ -0,0 +6,4 @@
url('Vazir-WOL.woff') format('woff'),
url('Vazir-WOL.ttf') format('truetype');
font-weight: normal;
font-style: normal;
theMasix (github.comから移行) がコメント 2020-06-23 19:55:48 +00:00
リンクをコピー

Shabnam-WOL Added. @igalic @elegaanz

```Shabnam-WOL``` Added. @igalic @elegaanz
elegaanz (github.comから移行) が変更を承認 2020-06-24 13:47:56 +00:00
elegaanz (github.comから移行) がコメント
リンクをコピー

Perfect! Thank you!

Perfect! Thank you!
サインインしてこの会話に参加。
レビューア
レビューアなし
elegaanz
ラベル
ラベルをクリア   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

ラベルなし
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
マイルストーン
マイルストーンをクリア
項目なし
マイルストーンなし
プロジェクト
プロジェクトをクリア
項目なし
プロジェクトなし
担当者
担当者をクリア
担当者なし
1 人の参加者
通知
期日
期日が正しくないか範囲を超えています。 "yyyy-mm-dd" の形式で入力してください。

期日は未設定です。

依存関係

依存関係が設定されていません。

リファレンス: Plume/Plume#787
説明はありません。
ブランチ "theMasix" の削除

ブランチの削除は恒久的です。 実際に削除されるまでの短い期間、ブランチが存在したままになることもありますが、たいていは元に戻すことはできません。 続行しますか？