Force interface language by config file #792
No reviewers
Labels
No labels
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: Plume/Plume#792
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "DearRude/force-lang"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
As explained in #785, trying to force the language interface which specified in
.env
file.I tried the commented code below and re-compiled the front, but nothing happened. Since I didn't find any other piece which gets browser language, I assume my method of recompilation is flawed. (Only do
cargo web deploy -p plume-front --release
)So I made this WIP PR as @igalic suggested. 😁
Codecov Report
The issue with the front-end is that it runs in the browser: it can't access the environment variables of the server.
I think the solution would be to:
lang
property to every<html>
tag we render, containing the language code that we chose to render the pagelang
attribute to detect the language instead of relying onnavigator.language
as we currently do.I hope this isn't too much. I can try to guide you more if need detailed steps, I know it can be hard to get started on a codebase you know nothing about. Feel free to ask me here or on Matrix if you have any questions.
The feature is missing, so it's not the issue at hand, but doing just that was actually not sufficient. You must also rebuild Plume, as it's build script (build.rs) is the one copying files from
target/
to where static files should bePull request closed