Better caching #794

trinity-1686a · 2020-06-25T19:51:46Z

elegaanz commented

2020-06-25 19:51:46 +00:00

(Migrated from github.com)

Based on @trinity-1686a's patch.

I'm not sure it is a fix for #786 but it is better than nothing.

Based on @trinity-1686a's patch. I'm not sure it is a fix for #786 but it is better than nothing.

elegaanz commented

2020-06-25 19:52:07 +00:00

(Migrated from github.com)

OK, my git history is broken, I need to fix that.

igalic (Migrated from github.com) reviewed 2020-06-25 20:02:06 +00:00

igalic (Migrated from github.com) left a comment

🙋️

src/template_utils.rs Outdated

					
				@ -67,1 +67,4 @@

				            // NGINX (and maybe other software) sometimes sends ETags with a

				            // "W/" prefix, that we ignore here

				            .any(|s| s[1..s.len() - 1] == etag || s[3..s.len() - 1] == etag)

				        {

igalic (Migrated from github.com) commented

2020-06-25 20:01:31 +00:00

can one of you two explain what this does?

igalic commented

2020-06-25 20:02:46 +00:00

(Migrated from github.com)

don't we still have to to change the subscribe/follow/blah button from a form… to… well… a button?

trinity-1686a reviewed 2020-06-25 20:10:42 +00:00

src/template_utils.rs Outdated

					
				@ -67,1 +67,4 @@

				            // NGINX (and maybe other software) sometimes sends ETags with a

				            // "W/" prefix, that we ignore here

				            .any(|s| s[1..s.len() - 1] == etag || s[3..s.len() - 1] == etag)

				        {

trinity-1686a commented

2020-06-25 20:10:42 +00:00

this should probably get it's comment actually.
We send Etags as 'some_tag', the old match does not verify the ', but check that whatever in-between is the right tag. Nginx apparently change the Etag to W/'some_tag', W/ indicating it's a weak Etag, the content may not be byte-equal, but is semantically identical (which is imo a shitty but correct interpretation of the RFC, as Nginx send compressed data)

The new match ignore that W/ saying it's a weak etag and so match if Nginx modified the header we sent previously

Comment might looks like : // if a strong or weak etag matches

this should probably get it's comment actually. We send Etags as `'some_tag'`, the old match does not verify the `'`, but check that whatever in-between is the right tag. Nginx apparently change the Etag to `W/'some_tag'`, W/ indicating it's a weak Etag, the content may not be byte-equal, but is semantically identical (which is imo a shitty but correct interpretation of the RFC, as Nginx send compressed data) The new match ignore that W/ saying it's a weak etag and so match if Nginx modified the header we sent previously Comment might looks like : // if a strong or weak etag matches

trinity-1686a commented

2020-06-25 20:12:11 +00:00

well there is that too, but these buttons are not here on the front page or a blog or user page. Anyway for post a better caching solution that does not require to query the database should be added

codecov[bot] commented

2020-06-25 20:57:34 +00:00

(Migrated from github.com)

Codecov Report

Merging #794 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #794      +/-   ##
==========================================
- Coverage   39.09%   39.07%   -0.03%     
==========================================
  Files          73       73              
  Lines        9756     9756              
  Branches     2233     2233              
==========================================
- Hits         3814     3812       -2     
- Misses       4885     4886       +1     
- Partials     1057     1058       +1

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/794?src=pr&el=h1) Report > Merging [#794](https://codecov.io/gh/Plume-org/Plume/pull/794?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/28576c1fa3ce5f3259952faa8af1ca1647aedaa5&el=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `0.00%`. ```diff @@ Coverage Diff @@ ## master #794 +/- ## ========================================== - Coverage 39.09% 39.07% -0.03% ========================================== Files 73 73 Lines 9756 9756 Branches 2233 2233 ========================================== - Hits 3814 3812 -2 - Misses 4885 4886 +1 - Partials 1057 1058 +1 ```

KitaitiMakoto referenced this pull request

2020-12-06 17:31:24 +00:00

better-caching #840

KitaitiMakoto commented

2020-12-06 17:33:09 +00:00

Merged into main branch as #840

Merged into `main` branch as #840

KitaitiMakoto closed this pull request

2020-12-06 17:33:09 +00:00