#825 CSS Fix: My title is displayed at the wrong position on Webkit browsers

Merged
igalic merged 1 commits from quentin/Plume:pr/flex into main 6 months ago
quentin commented 6 months ago

On Firefox (Gecko), the following CSS instruction puts the title block at the bottom of the header:

main header.article>div:not(.shadow) {
  justify-content: end;
}

But under Webkit Browsers, such instruction is ignored:

broken header

Patching it to the following however solves the problem:

main header.article>div:not(.shadow) {
  justify-content: flex-end;
}

fixed!

Some disclaimers about this pull request:

  • I have not yet tested the patch and this fix might have been done at the wrong place
  • The fix might be needed in other places, especially in the other included theme
  • I don’t understand exactly why Gecko and Webkit do not behave the same in this case
On Firefox (Gecko), the following CSS instruction puts the title block at the bottom of the header: ```css main header.article>div:not(.shadow) { justify-content: end; } ``` But under Webkit Browsers, such instruction is ignored: ![broken header](https://git.joinplu.me/attachments/a12d6162-9eca-4134-88c8-01007eb8b41e) Patching it to the following however solves the problem: ```css main header.article>div:not(.shadow) { justify-content: flex-end; } ``` ![fixed!](https://git.joinplu.me/attachments/4f49100d-a3e7-45a3-b80e-9e04ef56253e) Some disclaimers about this pull request: - I have not yet tested the patch and this fix might have been done at the wrong place - The fix might be needed in other places, especially in the other included theme - I don't understand exactly why Gecko and Webkit do not behave the same in this case
igalic approved these changes 6 months ago
igalic merged commit 003dcf861a into main 6 months ago

Reviewers

igalic approved these changes 6 months ago
The pull request has been merged as 003dcf861a.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.