CSS Fix: My title is displayed at the wrong position on Webkit browsers #825

Unito manualmente

igalic ha unito 1 commit da quentin/Plume:pr/flex a main

quentin ha commentato

On Firefox (Gecko), the following CSS instruction puts the title block at the bottom of the header:

main header.article>div:not(.shadow) {
  justify-content: end;
}

But under Webkit Browsers, such instruction is ignored:

Patching it to the following however solves the problem:

main header.article>div:not(.shadow) {
  justify-content: flex-end;
}

Some disclaimers about this pull request:

I have not yet tested the patch and this fix might have been done at the wrong place
The fix might be needed in other places, especially in the other included theme
I don't understand exactly why Gecko and Webkit do not behave the same in this case

On Firefox (Gecko), the following CSS instruction puts the title block at the bottom of the header: ```css main header.article>div:not(.shadow) { justify-content: end; } ``` But under Webkit Browsers, such instruction is ignored: ![broken header](https://git.joinplu.me/attachments/a12d6162-9eca-4134-88c8-01007eb8b41e) Patching it to the following however solves the problem: ```css main header.article>div:not(.shadow) { justify-content: flex-end; } ``` ![fixed!](https://git.joinplu.me/attachments/4f49100d-a3e7-45a3-b80e-9e04ef56253e) Some disclaimers about this pull request: - I have not yet tested the patch and this fix might have been done at the wrong place - The fix might be needed in other places, especially in the other included theme - I don't understand exactly why Gecko and Webkit do not behave the same in this case

Capture d’écran de 2020-09-25 11-26-03.png

1.7 MiB

Capture d’écran de 2020-09-25 11-25-39.png

1.7 MiB

igalic hanno approvato queste modifiche

igalic ha fatto riferimento a questa issue dal commit

Merge pull request 'CSS Fix: My title is displayed at the wrong position on Webkit browsers' (#825) from quentin/Plume:pr/flex into main Reviewed-on: https://git.joinplu.me/Plume/Plume/pulls/825 Reviewed-by: Mina Galić <me+git@igalic.co>

igalic merged commit 003dcf861a in main manualmente 4 anni fa

quentin branch pr/flex eliminato

Revisori

igalic hanno approvato queste modifiche

La pull request è stata unita manualmente come 003dcf861a.

Effettua l'accesso per partecipare alla conversazione.

Nessun revisore

Nessuna milestone

Nessuna assegnatario

2 Partecipanti

Notifiche

Data di scadenza

La data di scadenza non è valida o fuori intervallo. Si prega di utilizzare il formato 'aaaa-mm-dd'.

Nessuna data di scadenza impostata.

Dipendenze

Nessuna dipendenza impostata.

Caricamento…

Non ci sono ancora contenuti.

Etichette Traguardi

CSS Fix: My title is displayed at the wrong position on Webkit browsers #825

Revisori