Remove link to unimplemented page(timeline edit) #827

Manually merged

KitaitiMakoto merged 2 commits from KitaitiMakoto/Plume:feed-edit-button into main

2020-11-15 17:10:56 +00:00

KitaitiMakoto commented

2020-10-06 10:52:12 +00:00

Owner

Hi, long time no see.

As reported at Beginner questions. on GitHub, there's a link to unimplemented page. This patch removes it.

Hi, long time no see. As reported at [Beginner questions.](https://github.com/Plume-org/Plume/issues/815) on GitHub, there's a link to unimplemented page. This patch removes it.

KitaitiMakoto changed title from ~~Remove link to unimplemented page~~ to Remove link to unimplemented page(timeline edit)

2020-10-06 10:54:02 +00:00

igalic approved these changes 2020-10-07 18:00:04 +00:00

igalic left a comment

Owner

if we can't expose timelines::edit as easy as we can get rid of this; then it's the right way to go.

if we can't expose `timelines::edit` as easy as we can get rid of this; then it's the right way to go.

KitaitiMakoto commented

2020-11-15 15:41:46 +00:00

Author

Owner

Gitea says " Some required checks are missing. ". But, I have no idea what are required. Somebody knows?

Gitea says " Some required checks are missing. ". ![](https://i.gyazo.com/9c6bfab80c9d1bd14cc73e1911d8d6d7.png) But, I have no idea what are required. Somebody knows?

KitaitiMakoto commented

2020-11-15 16:52:08 +00:00

Author

Owner

this is because we have configured that Drone CI needs to pass builds, but it's not working, #798

https://matrix.to/#/!jUjMbitzgAikcTaCDG:disroot.org/$_PL_3aL0ug0EHmAj5VKhJAWGlNH-iajEj533gBiOB3w?via=disroot.org&via=pixie.town&via=matrix.org

> this is because we have configured that Drone CI needs to pass builds, but it's not working, https://git.joinplu.me/Plume/Plume/pulls/798 https://matrix.to/#/!jUjMbitzgAikcTaCDG:disroot.org/$_PL_3aL0ug0EHmAj5VKhJAWGlNH-iajEj533gBiOB3w?via=disroot.org&via=pixie.town&via=matrix.org

KitaitiMakoto referenced this pull request from a commit

2020-11-15 17:10:56 +00:00

Merge pull request 'Remove link to unimplemented page(timeline edit)' (#827) from KitaitiMakoto/Plume:feed-edit-button into main Reviewed-on: https://git.joinplu.me/Plume/Plume/pulls/827 Reviewed-by: Mina Galić <me+git@igalic.co>

KitaitiMakoto manually merged commit 6dd4080d65 into main

2020-11-15 17:10:56 +00:00

KitaitiMakoto deleted branch feed-edit-button

2020-11-15 23:39:06 +00:00