#832 Keep tags as-is

Merged
KitaitiMakoto merged 1 commits from KitaitiMakoto/Plume:keep-tag into main 2 months ago

This fixes issue #825 on GitHub.

This fixes [issue #825 on GitHub](https://github.com/Plume-org/Plume/issues/825).
kiwii approved these changes 2 months ago
kiwii left a comment

I wonder if heck is still needed in our dependencies? Maybe to generate blog identifiers from their title? Otherwise LGTM 👍

kiwii commented 2 months ago
Owner

Also fixes #721 and one item of #348

Also fixes #721 and one item of #348
KitaitiMakoto commented 2 months ago
Owner

Current patch doesn’t fix #721 because it doesn’t touch slug matters. heck is required for slug. Slug requires more consideration if we want to use only ASCII characters in URI.

Current patch doesn't fix #721 because it doesn't touch slug matters. heck is required for slug. Slug requires more consideration if we want to use only ASCII characters in URI.
KitaitiMakoto commented 2 months ago
Owner

Will merge this pull request. About cases in slug, keep discussing at #721.

Will merge this pull request. About cases in slug, keep discussing at #721.
KitaitiMakoto merged commit 3c666080a9 into main 2 months ago
KitaitiMakoto deleted branch keep-tag 2 months ago

Reviewers

kiwii approved these changes 2 months ago
The pull request has been merged as 3c666080a9.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.