Labels Milestones

New Pull Request

Close #888 Extract DbConn from PlumeRocket #889

Manually merged

KitaitiMakoto merged 14 commits from extract-dbconn into main 2 years ago

Conversation 1 Commits 14 Files Changed 36

KitaitiMakoto commented 2 years ago

Owner

A part of #888 and revival of #805.

A part of #888 and revival of #805.

KitaitiMakoto changed title from WIP: Extract DbConn from PlumeRocket to WIP: Close #797 Extract DbConn from PlumeRocket 2 years ago

KitaitiMakoto changed title from WIP: Close #797 Extract DbConn from PlumeRocket to WIP: Extract DbConn from PlumeRocket 2 years ago

KitaitiMakoto commented 2 years ago

Poster

Owner

I gave up to use Rocket's #[database] decorator because Rocket cannot share its database connection pool with our actors (see https://github.com/SergioBenitez/Rocket/issues/1187).

I gave up to use Rocket's `#[database]` decorator because Rocket cannot share its database connection pool with our actors (see https://github.com/SergioBenitez/Rocket/issues/1187).

KitaitiMakoto referenced this pull request 2 years ago

Reduce database connnections required for routes::users::details #888

KitaitiMakoto changed title from WIP: Extract DbConn from PlumeRocket to WIP: Close #888 Extract DbConn from PlumeRocket 2 years ago

KitaitiMakoto changed title from WIP: Close #888 Extract DbConn from PlumeRocket to Close #888 Extract DbConn from PlumeRocket 2 years ago

KitaitiMakoto referenced this issue from a commit 2 years ago

Merge pull request 'Close #888 Extract DbConn from PlumeRocket' (#889) from extract-dbconn into main Reviewed-on: https://git.joinplu.me/Plume/Plume/pulls/889

KitaitiMakoto merged commit e68ca1151d into main 2 years ago manually

KitaitiMakoto deleted branch extract-dbconn 2 years ago

The pull request has been manually merged as e68ca1151d.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels

A: API
Related to the REST API A: Backend
Code running on the server A: Federation
Stuff related to Federation A: Front-End
Related to the front-end A: I18N
Translations, and related code A: Meta
More about project management or code than the project itself A: Security Build
The building, or installation process of Plume C: Bug
Something isn't working C: Discussion
We need to talk C: Enhancement
New feature or request C: Feature
This is a new feature Compatibility
Compatibility with different browsers, readers and OS Dependency
Related to an external package that Plume uses Design
UI/UX related issues and PRs Documentation Good first issue
Good for newcomers Help welcome
Extra attention is needed Mobile
Issues affecting only mobile UX Rendering
How elements're rendered out for the end user S: Blocked
Something else needs to be fixed first S: Duplicate
This issue or pull request already exists S: Incomplete
This PR is not complete yet S: Instance specific
Issues concern a limited number of instances S: Invalid
This doesn't seem right S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio) S: Ready for review
This PR is ready to be reviewed Suggestion
Proposed ideas worth considering S: Voted on Loomio
This is issue has been created after a vote on Loomio S: Wontfix
This will not be worked on

No Label A: API A: Backend A: Federation A: Front-End A: I18N A: Meta A: Security Build C: Bug C: Discussion C: Enhancement C: Feature Compatibility Dependency Design Documentation Good first issue Help welcome Mobile Rendering S: Blocked S: Duplicate S: Incomplete S: Instance specific S: Invalid S: Needs Voting/Discussion S: Ready for review Suggestion S: Voted on Loomio S: Wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview

Loading…

Cancel

Save

There is no content yet.