Plume/Plume
9
18
Fork 24
Code Issues 177 Pull requests 8 Releases 8 Wiki Activity

Close #888 Extract DbConn from PlumeRocket #889

Manually merged
KitaitiMakoto merged 14 commits from extract-dbconn into main 2021-01-31 17:32:47 +00:00
Conversation 1 Commits 14 Files changed 36 +1174 -1063
KitaitiMakoto commented 2021-01-30 13:32:32 +00:00
Owner
Copy link

A part of #888 and revival of #805.

A part of #888 and revival of #805.
KitaitiMakoto changed title from WIP: Extract DbConn from PlumeRocket to WIP: Close #797 Extract DbConn from PlumeRocket 2021-01-30 14:28:46 +00:00
KitaitiMakoto changed title from WIP: Close #797 Extract DbConn from PlumeRocket to WIP: Extract DbConn from PlumeRocket 2021-01-31 16:45:18 +00:00
KitaitiMakoto commented 2021-01-31 16:46:58 +00:00
Author
Owner
Copy link

I gave up to use Rocket's #[database] decorator because Rocket cannot share its database connection pool with our actors (see https://github.com/SergioBenitez/Rocket/issues/1187).

I gave up to use Rocket's `#[database]` decorator because Rocket cannot share its database connection pool with our actors (see https://github.com/SergioBenitez/Rocket/issues/1187).
KitaitiMakoto changed title from WIP: Extract DbConn from PlumeRocket to WIP: Close #888 Extract DbConn from PlumeRocket 2021-01-31 16:50:36 +00:00
KitaitiMakoto changed title from WIP: Close #888 Extract DbConn from PlumeRocket to Close #888 Extract DbConn from PlumeRocket 2021-01-31 17:29:33 +00:00
KitaitiMakoto manually merged commit e68ca1151d into main 2021-01-31 17:32:47 +00:00
KitaitiMakoto deleted branch extract-dbconn 2021-01-31 17:33:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
A: API

Related to the REST API

  
A: Backend

Code running on the server

  
A: Federation

Stuff related to Federation

  
A: Front-End

Related to the front-end

  
A: I18N

Translations, and related code

  
A: Meta

More about project management or code than the project itself

  
A: Security

   
Build

The building, or installation process of Plume

  
C: Bug

Something isn't working

  
C: Discussion

We need to talk

  
C: Enhancement

New feature or request

  
C: Feature

This is a new feature

  
Compatibility

Compatibility with different browsers, readers and OS

  
Dependency

Related to an external package that Plume uses

  
Design

UI/UX related issues and PRs

  
Documentation

   
Good first issue

Good for newcomers

  
Help welcome

Extra attention is needed

  
Mobile

Issues affecting only mobile UX

  
Rendering

How elements're rendered out for the end user

  
S: Blocked

Something else needs to be fixed first

  
S: Duplicate

This issue or pull request already exists

  
S: Incomplete

This PR is not complete yet

  
S: Instance specific

Issues concern a limited number of instances

  
S: Invalid

This doesn't seem right

  
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)

  
S: Ready for review

This PR is ready to be reviewed

  
Suggestion

Proposed ideas worth considering

  
S: Voted on Loomio

This is issue has been created after a vote on Loomio

  
S: Wontfix

This will not be worked on

No labels
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#889
No description provided.
Delete branch "extract-dbconn"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?