Mina Galić igalic
  • Dortmund
  • https://igalic.co/
  • Infrastructure & Open Source (Homoiconic Ops Witch)
  • Joined on Jun 26, 2020
Loading Heatmap…

igalic suggested changes for plume/documentation#91

document ldap

small addaptation

1 month ago

igalic commented on pull request plume/documentation#91

document ldap

please add a header that we can link to from else where.

1 month ago

igalic commented on pull request plume/documentation#91

document ldap

i'd link this mention of ldap to the appropriate Environment section

1 month ago

igalic pushed to refactor/extract-actors at igalic/Plume

  • 8aa4ae4302 Make tests compile again
  • 56091c0d49 add UpdateDocument to list of SearcherActor messages how did this even work?! I've only been using UpdateDocument so far, and it wasn't listed!
  • d7e380f83e remove Searcher from Post::update() thereby decoupling the two systems (for updates, anyway) That means, consumers of Post need to update_document themselves! Post (in update) now only talks to the database) Tests for this will now be failing, as they haven't been touched yet
  • 06e20299e0 use searcher_actor for posts update route (instead of post.update())
  • 94cf4dab98 add ActorSystem member to PlumeRocket
  • Compare 48 commits »

1 month ago

igalic commented on pull request Plume/Plume#826

implement login via LDAP

@trinity-1686a >I'm not sure why gitea sais " Some required checks are missing". May I still merge it? yes, please do

1 month ago

igalic approved Plume/Plume#826

implement login via LDAP

👍

1 month ago

igalic suggested changes for Plume/Plume#826

implement login via LDAP

i've looked at this now and have left a few comments.

1 month ago

igalic commented on pull request Plume/Plume#826

implement login via LDAP

would it be possible to do these as if not tests, so we don't nest four levels deep until we get to the actual code.

1 month ago

igalic commented on pull request Plume/Plume#826

implement login via LDAP

if we use ldap as user-database, we could do the ldap bind once, and then pass around a connection…

1 month ago

igalic commented on pull request Plume/Plume#826

implement login via LDAP

can you please document where in this code we now fake the login check to prevent timing attacks?

1 month ago

igalic commented on pull request Plume/Plume#826

implement login via LDAP

…are going to be pain with async code

1 month ago

igalic commented on pull request Plume/Plume#826

implement login via LDAP

these…

1 month ago

igalic commented on pull request Plume/Plume#826

implement login via LDAP

we panic, because both of those must be set??!

1 month ago

igalic commented on pull request Plume/Plume#826

implement login via LDAP

if addr and base_dn `is_some()`…

1 month ago

igalic commented on pull request Plume/Plume#826

implement login via LDAP

we should upgrade our own dependencies of these packages to 1.x

1 month ago

igalic approved Plume/Plume#827

Remove link to unimplemented page(timeline edit)

if we can't expose `timelines::edit` as easy as we can get rid of this; then it's the right way to go.

1 month ago

igalic commented on pull request Plume/Plume#826

implement login via LDAP

``` - // Making fake password verification to avoid different - // response times that would make it possible to know - // if a username is registered or not. - User::get(conn, 1)?.auth(&query.password); ``` why would you get rid of this?

1 month ago

igalic merged pull request Plume/Plume#825

CSS Fix: My title is displayed at the wrong position on Webkit browsers

2 months ago

igalic merged pull request Plume/Plume#825

CSS Fix: My title is displayed at the wrong position on Webkit browsers

2 months ago