Plume
/
Plume
8
16
Fork 22
Code Issues 174 Pull Requests 8 Releases 8 Wiki Activity

Labels Milestones

Snapcraft updates #731

Merged
RAOF merged 4 commits from snapcraft-updates into master 4 years ago
Conversation 1 Commits 4 Files Changed 1
RAOF commented 4 years ago (Migrated from github.com)

Should now work again (😠 )

Should now work again (:angry: )
trinity-1686a approved these changes 4 years ago
trinity-1686a left a comment
Owner

LGTM

LGTM
snap/snapcraft.yaml
@ -10,3 +10,3 @@
* Collaborative writing: invite other people to your blogs, and write articles together.
grade: devel # must be 'stable' to release into candidate/stable channels
grade: stable
confinement: strict
trinity-1686a commented 4 years ago
Owner

what does that change implies?

what does that change implies?
RAOF (Migrated from github.com) reviewed 4 years ago
snap/snapcraft.yaml
@ -10,3 +10,3 @@
* Collaborative writing: invite other people to your blogs, and write articles together.
grade: devel # must be 'stable' to release into candidate/stable channels
grade: stable
confinement: strict
RAOF (Migrated from github.com) commented 4 years ago

Technically, that we can promote the snap into the candidate & stable channels. Otherwise, it's just end-user messaging.

Technically, that we can promote the snap into the candidate & stable channels. Otherwise, it's just end-user messaging.
codecov[bot] commented 4 years ago (Migrated from github.com)

Codecov Report

Merging #731 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #731      +/-   ##
==========================================
- Coverage   39.17%   39.16%   -0.02%     
==========================================
  Files          73       73              
  Lines        9653     9653              
  Branches     2183     2183              
==========================================
- Hits         3782     3781       -1     
  Misses       4819     4819              
- Partials     1052     1053       +1
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/731?src=pr&el=h1) Report > Merging [#731](https://codecov.io/gh/Plume-org/Plume/pull/731?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/5f8d6b8e0e81390118c4e7eef97546252bc5a7bf?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #731 +/- ## ========================================== - Coverage 39.17% 39.16% -0.02% ========================================== Files 73 73 Lines 9653 9653 Branches 2183 2183 ========================================== - Hits 3782 3781 -1 Misses 4819 4819 - Partials 1052 1053 +1 ```

Reviewers

trinity-1686a approved these changes 4 years ago
The pull request has been merged as 2a58835f92.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b snapcraft-updates master
git pull origin snapcraft-updates

Step 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff snapcraft-updates
git push origin master
Sign in to join this conversation.
Reviewers
Request review
No reviewers
trinity-1686a
Labels
Apply labels
Clear labels   
A: API

Related to the REST API   
A: Backend

Code running on the server   
A: Federation

Stuff related to Federation   
A: Front-End

Related to the front-end   
A: I18N

Translations, and related code   
A: Meta

More about project management or code than the project itself   
A: Security
   
Build

The building, or installation process of Plume   
C: Bug

Something isn't working   
C: Discussion

We need to talk   
C: Enhancement

New feature or request   
C: Feature

This is a new feature   
Compatibility

Compatibility with different browsers, readers and OS   
Dependency

Related to an external package that Plume uses   
Design

UI/UX related issues and PRs   
Documentation
   
Good first issue

Good for newcomers   
Help welcome

Extra attention is needed   
Mobile

Issues affecting only mobile UX   
Rendering

How elements're rendered out for the end user   
S: Blocked

Something else needs to be fixed first   
S: Duplicate

This issue or pull request already exists   
S: Incomplete

This PR is not complete yet   
S: Instance specific

Issues concern a limited number of instances   
S: Invalid

This doesn't seem right   
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)   
S: Ready for review

This PR is ready to be reviewed   
Suggestion

Proposed ideas worth considering   
S: Voted on Loomio

This is issue has been created after a vote on Loomio   
S: Wontfix

This will not be worked on
No Label
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#731
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'snapcraft-updates'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes