Make database connections configurable by environment variables #768

Merged

KitaitiMakoto merged 4 commits from db-conns-conf into master

KitaitiMakoto commented (Migrated from github.com)

so that we can tune performance.

codecov[bot] commented (Migrated from github.com)

Codecov Report

Merging #768 into master will decrease coverage by 0.03%.
The diff coverage is 18.18%.

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   38.99%   38.96%   -0.04%     
==========================================
  Files          73       73              
  Lines        9721     9729       +8     
  Branches     2226     2227       +1     
==========================================
  Hits         3791     3791              
- Misses       4878     4885       +7     
- Partials     1052     1053       +1

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=h1) Report > Merging [#768](https://codecov.io/gh/Plume-org/Plume/pull/768?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/180e34b07c014a3a37b2031cf0532ee17104f47b&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `18.18%`. ```diff @@ Coverage Diff @@ ## master #768 +/- ## ========================================== - Coverage 38.99% 38.96% -0.04% ========================================== Files 73 73 Lines 9721 9729 +8 Branches 2226 2227 +1 ========================================== Hits 3791 3791 - Misses 4878 4885 +7 - Partials 1052 1053 +1 ```

elegaanz (Migrated from github.com) reviewed

elegaanz (Migrated from github.com) left a comment

Nice! I just have a small question, but otherwise it seems good to merge. Thanks!

plume-models/src/config.rs

elegaanz (Migrated from github.com) commented

Is there a reason for panicking in one case and silently failing in the other?

KitaitiMakoto (Migrated from github.com) reviewed

plume-models/src/config.rs

KitaitiMakoto (Migrated from github.com) commented

Good catch! There's no reason why. I will rewrite this and push it.

KitaitiMakoto (Migrated from github.com) reviewed

plume-models/src/config.rs

KitaitiMakoto (Migrated from github.com) commented

Done.

elegaanz (Migrated from github.com) approved these changes

elegaanz (Migrated from github.com) left a comment

Great!

KitaitiMakoto commented (Migrated from github.com)

Thank you for the merge.

kiwii referenced this issue from a commit

Make database connections configurable by environment variables (#768) * Make env DB_MAX_SIZE and DB_MIN_IDLE recognizable * Make database max size and minimum idle configurable * Restore file permission * Fail fast

Reviewers

The pull request has been merged as 3be842c653.

You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.

git checkout -b db-conns-conf master

git pull origin db-conns-conf

Step 2:

Merge the changes and update on Forgejo.

git checkout master

git merge --no-ff db-conns-conf

git push origin master

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Loading…

There is no content yet.

Labels Milestones

Make database connections configurable by environment variables #768

Codecov Report

Reviewers

Step 1:

Step 2: