Draw side line for blockquote on start #933

Merged

trinity-1686a merged 2 commits from ahangarha/Plume:ahangarha-patch-1-blockquote-line into main

ahangarha commented

By this change, the line beside blockquote would appear at start. It means if the text is in LTR language, it appears on left and if it is in RTL, the line appears on right.

trinity-1686a commented

Owner

I tried the patch and it seems to do nothing for me.
Plume generated html looks like this:

<blockquote dir="auto">
	<p dir="auto">
		سلام 
	</p>
</blockquote>

Removing the dir="auto" from the <p> makes it works as intended, so there will be need for further changes for this to work, probably in pulldown-cmark.
Shall I merge this anyway?

I tried the patch and it seems to do nothing for me. Plume generated html looks like this: ```html <blockquote dir="auto"> <p dir="auto"> سلام </p> </blockquote> ``` Removing the `dir="auto"` from the `<p>` makes it works as intended, so there will be need for further changes for this to work, probably in pulldown-cmark. Shall I merge this anyway?

ahangarha commented

Poster

Since dir="auto" was added in the forked repo, then that can be improved. It seems removing dir=auto from blockquote can help. Can you confirm this?

Since `dir="auto"` was added in the forked repo, then that can be improved. It seems removing `dir=auto` from `blockquote` can help. Can you confirm this?

trinity-1686a added 1 commit

7fe1e083e0 use newer pulldown-cmark

trinity-1686a commented

Owner

I believe I've made the required changes on the pulldown-cmark side. I'm too busy to test right now, but I'll try to come back soon

👍 1

trinity-1686a approved these changes

trinity-1686a referenced this issue from a commit

Merge pull request 'Draw side line for blockquote on start' (#933) from ahangarha/Plume:ahangarha-patch-1-blockquote-line into main

trinity-1686a merged commit d7d6d5f644 into main 3 years ago

ahangarha deleted branch ahangarha-patch-1-blockquote-line

Reviewers

trinity-1686a approved these changes

The pull request has been merged as d7d6d5f644.

No reviewers

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Loading…

There is no content yet.

Labels Milestones

Draw side line for blockquote on start #933

Reviewers