Decode unfollow activities in inbox properly #316

Merged

KokaKiwi merged 1 commits from decode-unfollow-activity into master

KokaKiwi commented (Migrated from github.com)

Actually it tried to decode Follow activity object referenced by Undo activity with Like type, surely a failed copy-and-paste but it made the whole thing unable to handle unfollow request correctly.

(Also formatted a bit imports block, like the one following just after)

Actually it tried to decode `Follow` activity object referenced by `Undo` activity with `Like` type, surely a failed copy-and-paste but it made the whole thing unable to handle unfollow request correctly. (Also formatted a bit imports block, like the one following just after)

❤️ 1

codecov[bot] commented (Migrated from github.com)

Codecov Report

Merging #316 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #316      +/-   ##
=========================================
- Coverage    5.13%   5.11%   -0.02%     
=========================================
  Files          55      55              
  Lines        3719    3733      +14     
=========================================
  Hits          191     191              
- Misses       3528    3542      +14

Impacted Files	Coverage Δ
src/inbox.rs	`0% <0%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00a205a...e78ea14. Read the comment docs.

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/316?src=pr&el=h1) Report > Merging [#316](https://codecov.io/gh/Plume-org/Plume/pull/316?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/00a205a882aa0229fe33f358a7ba1b24171899d0?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `0%`. [![Impacted file tree graph](https://codecov.io/gh/Plume-org/Plume/pull/316/graphs/tree.svg?width=650&token=sHtxmDuZ06&height=150&src=pr)](https://codecov.io/gh/Plume-org/Plume/pull/316?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #316 +/- ## ========================================= - Coverage 5.13% 5.11% -0.02% ========================================= Files 55 55 Lines 3719 3733 +14 ========================================= Hits 191 191 - Misses 3528 3542 +14 ``` | [Impacted Files](https://codecov.io/gh/Plume-org/Plume/pull/316?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/inbox.rs](https://codecov.io/gh/Plume-org/Plume/pull/316/diff?src=pr&el=tree#diff-c3JjL2luYm94LnJz) | `0% <0%> (ø)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/Plume-org/Plume/pull/316?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/316?src=pr&el=footer). Last update [00a205a...e78ea14](https://codecov.io/gh/Plume-org/Plume/pull/316?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

trinity-1686a approved these changes

Reviewers

trinity-1686a approved these changes

The pull request has been merged as 67fe28177e.

You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.

git checkout -b decode-unfollow-activity master

git pull origin decode-unfollow-activity

Step 2:

Merge the changes and update on Forgejo.

git checkout master

git merge --no-ff decode-unfollow-activity

git push origin master

No reviewers

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Loading…

There is no content yet.

Labels Milestones

Decode unfollow activities in inbox properly #316

Codecov Report

Reviewers

Step 1:

Step 2: