An attempt to fix disorted submit button on mobile devices like iPhone - please review #370

已合併

marek-lach 將 3 次提交從 patch-1 合併至 master

marek-lach 已留言 (已從 github.com 遷移)

尚未有任何內容

elegaanz 已留言 (已從 github.com 遷移)

@marek-lach Hello! What was the issue you are trying to fix? I can't find anything similar to what you describe in the title…

codecov[bot] 已留言 (已從 github.com 遷移)

Codecov Report

Merging #370 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #370   +/-   ##
=======================================
  Coverage   28.47%   28.47%           
=======================================
  Files          62       62           
  Lines        5706     5706           
=======================================
  Hits         1625     1625           
  Misses       4081     4081

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/370?src=pr&el=h1) Report > Merging [#370](https://codecov.io/gh/Plume-org/Plume/pull/370?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/5c5cf36b0d6609127793e22ed315edf5a5c689d2?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #370 +/- ## ======================================= Coverage 28.47% 28.47% ======================================= Files 62 62 Lines 5706 5706 ======================================= Hits 1625 1625 Misses 4081 4081 ```

marek-lach 已留言 (已從 github.com 遷移)

Problem:
When on a mobile device, like an iPhone, the submit comment button gets disorted (i.e. out of shape, squashed) when you press submit. As far as I know, this isn't the case on the desktop.

Before pressing the submit button for a comment on an iPhone (though I suspect Android's the same):

After pressing the submit button on an iPhone (it works, the distortion is just a visual CSS problem):

I am sure the fix for this has to do with responsivness of the submit button, and it must be easy to do, but addmitedly I have no idea, what precisely would fix it, just took a guess.

**Problem:** When on a mobile device, like an iPhone, the submit comment button gets disorted (i.e. out of shape, squashed) when you press submit. As far as I know, this isn't the case on the desktop. Before pressing the submit button for a comment on an iPhone (though I suspect Android's the same): ![img_0551](https://user-images.githubusercontent.com/45913977/50384758-19a1ce00-06c1-11e9-89f4-7e85ca6bcd03.PNG) After pressing the submit button on an iPhone (it works, the distortion is just a visual CSS problem): ![img_0552](https://user-images.githubusercontent.com/45913977/50384770-51107a80-06c1-11e9-92df-8088fd998695.PNG) I am sure the fix for this has to do with responsivness of the submit button, and it must be easy to do, but addmitedly I have no idea, what precisely would fix it, just took a guess.

elegaanz 已留言 (已從 github.com 遷移)

This seems to be related to Safari's rendering engine (I cant' reproduce on my Android phone), and I have no iPhone to test. If it doesn't break anything I'll merge your change, hoping it will fix the issue…

elegaanz (已從 github.com 遷移) 請求了變更

elegaanz (已從 github.com 遷移) 留下了回應

It doesn't work: no border is displayed at all… 😕

It doesn't work: no border is displayed at all… :confused:

marek-lach 已留言 (已從 github.com 遷移)

Right, couldn't reproduce the problem on Android. Will try to modify specifically for Safari only then.

marek-lach 已留言 (已從 github.com 遷移)

Hmm... reverted the change and tried a Safari-specific style. Let me know if the border is back as before with this last commit.

elegaanz (已從 github.com 遷移) 請求了變更

elegaanz (已從 github.com 遷移) 留下了回應

I don't have the issue with borders anymore, but I have some other issues, for instance on the user page:

I think this is the same issue as here: https://stackoverflow.com/a/5438653

I don't have the issue with borders anymore, but I have some other issues, for instance on the user page: ![2018-12-23-163432_362x492_scrot](https://user-images.githubusercontent.com/16254623/50385167-dc453c80-06d0-11e9-9f9c-338a29ba4c4f.png) I think this is the same issue as here: https://stackoverflow.com/a/5438653

marek-lach 已留言 (已從 github.com 遷移)

I have reverted all of the changes up to now, and added the suggested webkit-specific fix as advised on stack owerflow. As long as this does not disort anything anywhere else, it might work as a quick solution to the problem for now...

elegaanz (已從 github.com 遷移) 核可了這些變更

elegaanz (已從 github.com 遷移) 留下了回應

Thanks! Looks good now. I hope it will fix your issue.

審核者

此合併請求已被合併為 2621549f5e。

您也可以查看命令列指南。

第一步：

在您的儲存庫中切換到新分支並測試變更。

git checkout -b patch-1 master

git pull origin patch-1

第二步：

合併變更並更新到 Forgejo。

git checkout master

git merge --no-ff patch-1

git push origin master

登入才能加入這對話。

沒有審核者

未選擇里程碑

沒有負責人

1 參與者

通知

截止日期

截止日期無效或超出範圍，請使用「yyyy-mm-dd」的格式。

未設定截止日期。

先決條件

未設定先決條件。

載入中…

尚未有任何內容

標籤 里程碑

An attempt to fix disorted submit button on mobile devices like iPhone - please review #370

Codecov Report

審核者

第一步：

第二步：

標籤里程碑