Plume
/
Plume
8
16
Bifurcation 22
Code Tickets 174 Demandes d'ajout 8 Versions 8 Wiki Activité

Étiquettes Jalons

Add a page listing people someone follows #444

Fusionnée
elegaanz a fusionné 5 révision(s) à partir de follows-page vers master il y a 5 ans
Discussion 2 Révisions 5 Fichiers Modifiés 24
elegaanz a commenté il y a 5 ans (Migré de github.com)

Nothing exceptional, the layout is the same as the followers page.

Fixes #325

Nothing exceptional, the layout is the same as the followers page. Fixes #325
codecov[bot] a commenté il y a 5 ans (Migré de github.com)

Codecov Report

Merging #444 into master will increase coverage by 0.18%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #444      +/-   ##
==========================================
+ Coverage   25.58%   25.76%   +0.18%     
==========================================
  Files          63       63              
  Lines        6254     6477     +223     
==========================================
+ Hits         1600     1669      +69     
- Misses       4654     4808     +154
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/444?src=pr&el=h1) Report > Merging [#444](https://codecov.io/gh/Plume-org/Plume/pull/444?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/576a4ed49946545af1e2ef8db5058f840c05c8df?src=pr&el=desc) will **increase** coverage by `0.18%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #444 +/- ## ========================================== + Coverage 25.58% 25.76% +0.18% ========================================== Files 63 63 Lines 6254 6477 +223 ========================================== + Hits 1600 1669 +69 - Misses 4654 4808 +154 ```
trinity-1686a révisé il y a 5 ans
trinity-1686a laisser un commentaire
Propriétaire

👍

:+1:
igalic (Migré de github.com) révisé il y a 5 ans
igalic (Migré de github.com) laisser un commentaire

words are hard…

words are hard…
plume-models/src/users.rs
@ -580,0 +586,4 @@
.map_err(Error::from)
}
pub fn get_followed_page(&self, conn: &Connection, (min, max): (i32, i32)) -> Result<Vec<User>> {
igalic (Migré de github.com) a commenté il y a 5 ans

n.b.: many people on the fediverse are not happy with the "clout" that comes from these numbers

do we offer an option to disable it?

i would also suggest considering "subscribe" instead of "follow".
it fits better with a blog, and has slightly less of a cult meaning

n.b.: many people on the fediverse are not happy with the "clout" that comes from these numbers do we offer an option to disable it? i would also suggest considering "subscribe" instead of "follow". it fits better with a blog, and has slightly less of a cult meaning
elegaanz (Migré de github.com) révisé il y a 5 ans
plume-models/src/users.rs
@ -580,0 +586,4 @@
.map_err(Error::from)
}
pub fn get_followed_page(&self, conn: &Connection, (min, max): (i32, i32)) -> Result<Vec<User>> {
elegaanz (Migré de github.com) a commenté il y a 5 ans

These numbers are not currently displayed in the UI, we only use this function to know how many pages listing followers/followed we need. If we display them one day, I totally agree that we should be able to hide them (maybe even hide them by default?), or that they should only be shown for your own profile.

And I agree on "follow"/"subscribe" too, I will change it. 🙂

These numbers are not currently displayed in the UI, we only use this function to know how many pages listing followers/followed we need. If we display them one day, I totally agree that we should be able to hide them (maybe even hide them by default?), or that they should only be shown for your own profile. And I agree on "follow"/"subscribe" too, I will change it. :slightly_smiling_face:
igalic (Migré de github.com) révisé il y a 5 ans
igalic (Migré de github.com) laisser un commentaire

🇩🇪 / 🇦🇹

🇩🇪 / 🇦🇹
po/plume/de.po
igalic (Migré de github.com) a commenté il y a 5 ans

not quite… "Abonoment" would be a better translation.

not quite… "Abonoment" would be a better translation.
igalic (Migré de github.com) a commenté il y a 5 ans

"Abonomenten"

"Abonomenten"
po/plume/de.po
@ -338,15 +341,19 @@ msgstr "Ändere dein Profil"
msgid "Open on {0}"
igalic (Migré de github.com) a commenté il y a 5 ans

"abonieren"

"abonieren"
igalic (Migré de github.com) a commenté il y a 5 ans

"abbestellen"

"abbestellen"
elegaanz (Migré de github.com) révisé il y a 5 ans
po/plume/de.po
elegaanz (Migré de github.com) a commenté il y a 5 ans

Yes, these strings have probably been automatically translated by GetText… 😕 I will edit them.

Yes, these strings have probably been automatically translated by GetText… :confused: I will edit them.
trinity-1686a révisé il y a 5 ans
trinity-1686a laisser un commentaire
Propriétaire

(there are still 7 times the word "follow" and it's derivative in translations, so I believe it must not be gone everywhere, but this is not the main point of this pr)

(there are still 7 times the word "follow" and it's derivative in translations, so I believe it must not be gone everywhere, but this is not the main point of this pr)
elegaanz a commenté il y a 5 ans (Migré de github.com)

I replaced the other occurrences of "follow" while we are at it.

I replaced the other occurrences of "follow" while we are at it.
trinity-1686a ces changements ont été approuvés il y a 5 ans
trinity-1686a laisser un commentaire
Propriétaire

👍

:+1:

Relecteurs

trinity-1686a ces changements ont été approuvés il y a 5 ans
La demande d'ajout a été fusionnée en e28371bbe4.
Vous pouvez également voir les instructions en ligne de commande.

Étape 1:

Depuis le dépôt de votre projet, sélectionnez une nouvelle branche et testez les modifications.
git checkout -b follows-page master
git pull origin follows-page

Étape 2:

Fusionner les modifications et mettre à jour sur Forgejo.
git checkout master
git merge --no-ff follows-page
git push origin master
Connectez-vous pour rejoindre cette conversation.
Relecteurs
Demander une revue
Aucune évaluation
trinity-1686a
Étiquettes
Appliquer une étiquette
Effacer les étiquettes   
A: API

Related to the REST API   
A: Backend

Code running on the server   
A: Federation

Stuff related to Federation   
A: Front-End

Related to the front-end   
A: I18N

Translations, and related code   
A: Meta

More about project management or code than the project itself   
A: Security
   
Build

The building, or installation process of Plume   
C: Bug

Something isn't working   
C: Discussion

We need to talk   
C: Enhancement

New feature or request   
C: Feature

This is a new feature   
Compatibility

Compatibility with different browsers, readers and OS   
Dependency

Related to an external package that Plume uses   
Design

UI/UX related issues and PRs   
Documentation
   
Good first issue

Good for newcomers   
Help welcome

Extra attention is needed   
Mobile

Issues affecting only mobile UX   
Rendering

How elements're rendered out for the end user   
S: Blocked

Something else needs to be fixed first   
S: Duplicate

This issue or pull request already exists   
S: Incomplete

This PR is not complete yet   
S: Instance specific

Issues concern a limited number of instances   
S: Invalid

This doesn't seem right   
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)   
S: Ready for review

This PR is ready to be reviewed   
Suggestion

Proposed ideas worth considering   
S: Voted on Loomio

This is issue has been created after a vote on Loomio   
S: Wontfix

This will not be worked on
Pas d'étiquette
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Jalon
Affecter un jalon
Effacer le jalon
Pas d'élément
Aucun jalon
Affecté à
Assigner des utilisateurs
Supprimer les affectations
Pas d'assignataires
2 participants
Notifications
Échéance
La date d’échéance est invalide ou hors plage. Veuillez utiliser le format 'aaaa-mm-dd'.

Aucune échéance n'a été définie.

Dépendances

No dependencies set.

Reference: Plume/Plume#444
Écrire Aperçu
Chargement…
Annuler
Enregistrer
Il n'existe pas encore de contenu.
Supprimer la branche 'follows-page'

Supprimer une branche est permanent. Cela NE PEUVENT être annulées. Continuer ?

Non
Oui