rewrite circleci config #558

已合併
Plume_migration_agent merged 12 commit from rework-ci into master 2019-05-04 13:35:22 +00:00
  • use better syntax
  • grcov for coverage
  • automatize crowdin interactions
- [x] use better syntax - [x] grcov for coverage - [x] automatize crowdin interactions
elegaanz (Migrated from github.com) reviewed 2019-05-01 20:17:06 +00:00
@ -1,3 +1,3 @@
[target.x86_64-unknown-linux-gnu]
# link dead code for coverage, attempt to reduce linking memory usage to not get killed
rustflags = ["-Clink-dead-code", "-Clink-args=-Xlinker --no-keep-memory -Xlinker --reduce-memory-overheads"]
rustflags = ["-Clink-args=-Xlinker --no-keep-memory -Xlinker --reduce-memory-overheads"]
elegaanz (Migrated from github.com) 評論 2019-05-01 20:17:05 +00:00

Don't we need to link dead code anymore?

Don't we need to link dead code anymore?
trinity-1686a reviewed 2019-05-01 20:49:49 +00:00
@ -1,3 +1,3 @@
[target.x86_64-unknown-linux-gnu]
# link dead code for coverage, attempt to reduce linking memory usage to not get killed
rustflags = ["-Clink-dead-code", "-Clink-args=-Xlinker --no-keep-memory -Xlinker --reduce-memory-overheads"]
rustflags = ["-Clink-args=-Xlinker --no-keep-memory -Xlinker --reduce-memory-overheads"]
Author
管理員

It's somewhere it this line now https://github.com/Plume-org/Plume/pull/558/files#diff-1d37e48f9ceff6d8030570cd36286a61R74 , and having that here was an error : release builds were run with linked dead code too (not a problem, but it makes for bigger binaries)

It's somewhere it this line now https://github.com/Plume-org/Plume/pull/558/files#diff-1d37e48f9ceff6d8030570cd36286a61R74 , and having that here was an error : release builds were run with linked dead code too (not a problem, but it makes for bigger binaries)
elegaanz (Migrated from github.com) reviewed 2019-05-01 21:54:09 +00:00
elegaanz (Migrated from github.com) 評論 2019-05-01 21:52:19 +00:00

Could it be possible to give more distinct name to these? I think that because of that we get one job called "clippy" (or whatever) and another one "cliipy-1", but it is not clear which one uses SQlite or PostgreSQL.

Could it be possible to give more distinct name to these? I think that because of that we get one job called "clippy" (or whatever) and another one "cliipy-1", but it is not clear which one uses SQlite or PostgreSQL.
trinity-1686a reviewed 2019-05-01 22:02:13 +00:00
Author
管理員

not without having to duplicate config sadly :/

not without having to duplicate config sadly :/
elegaanz (Migrated from github.com) reviewed 2019-05-01 22:05:45 +00:00
elegaanz (Migrated from github.com) 評論 2019-05-01 22:05:45 +00:00

OK, let's forget about it then, it was more bonus.

OK, let's forget about it then, it was more bonus.
codecov[bot] 評論 2019-05-02 11:02:28 +00:00 (Migrated from github.com)

Codecov Report

Merging #558 into master will decrease coverage by 6.9%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #558      +/-   ##
==========================================
- Coverage   41.96%   35.05%   -6.91%     
==========================================
  Files          70       67       -3     
  Lines        8839     7825    -1014     
  Branches        0     1876    +1876     
==========================================
- Hits         3709     2743     -966     
+ Misses       5130     4323     -807     
- Partials        0      759     +759
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/558?src=pr&el=h1) Report > Merging [#558](https://codecov.io/gh/Plume-org/Plume/pull/558?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/33a0c7dcd3c4377db338ed380ab33c88caeed4bf?src=pr&el=desc) will **decrease** coverage by `6.9%`. > The diff coverage is `100%`. ```diff @@ Coverage Diff @@ ## master #558 +/- ## ========================================== - Coverage 41.96% 35.05% -6.91% ========================================== Files 70 67 -3 Lines 8839 7825 -1014 Branches 0 1876 +1876 ========================================== - Hits 3709 2743 -966 + Misses 5130 4323 -807 - Partials 0 759 +759 ```
trinity-1686a reviewed 2019-05-02 13:43:47 +00:00
Author
管理員

kinda related, I'd prefer to use an enum telling we should use sqlite or postgres, but there is no way to do conditional based on other things than boolean :/
And there is no way to select if we use a docker or not, just to select which one, so I run empty alpine when nothing is needed.
I feel like this new syntax is better than the previous, but it misses some core features to not feel hacky in many places

kinda related, I'd prefer to use an enum telling we should use sqlite or postgres, but there is no way to do conditional based on other things than boolean :/ And there is no way to select if we use a docker or not, just to select which one, so I run empty alpine when nothing is needed. I feel like this new syntax is better than the previous, but it misses some core features to not feel hacky in many places
igalic (Migrated from github.com) reviewed 2019-05-03 14:22:13 +00:00
igalic (Migrated from github.com) left a comment

😵

😵
@ -199,0 +92,4 @@
parameters:
package:
type: string
default: plume
igalic (Migrated from github.com) 評論 2019-05-03 14:21:35 +00:00

that seems excessive

that seems excessive
elegaanz (Migrated from github.com) reviewed 2019-05-03 14:26:18 +00:00
@ -199,0 +92,4 @@
parameters:
package:
type: string
default: plume
elegaanz (Migrated from github.com) 評論 2019-05-03 14:26:18 +00:00

Yeah, but don't worry, this was an old version, now we only repeat it a few times:

for i in 36 4 2 1 1; do
   ...

where i is the number of threads of the command.

It is to avoid job failures because of OOM errors.

Yeah, but don't worry, this was an old version, now we only repeat it a few times: ```bash for i in 36 4 2 1 1; do ... ``` where `i` is the number of threads of the command. It is to avoid job failures because of OOM errors.
trinity-1686a reviewed 2019-05-03 14:27:11 +00:00
@ -199,0 +92,4 @@
parameters:
package:
type: string
default: plume
Author
管理員

I think you're reviewing an older commit

I think you're reviewing an older commit
elegaanz (Migrated from github.com) approved these changes 2019-05-04 10:55:10 +00:00
elegaanz (Migrated from github.com) left a comment

Seems to work as expected (sorry for the long time, I didn't saw this was ready for review). Thank you!

Seems to work as expected (sorry for the long time, I didn't saw this was ready for review). Thank you!
登入 才能加入這對話。
No reviewers
未選擇里程碑
No project
No assignees
2 participant
訊息
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#558
No description provided.