rewrite circleci config #558

trinity-1686a · 2019-05-01T19:37:54Z

trinity-1686a оставлен комментарий

2019-05-01 19:37:54 +00:00

Владелец

use better syntax
grcov for coverage
automatize crowdin interactions

- [x] use better syntax - [x] grcov for coverage - [x] automatize crowdin interactions

👍 1 ❤️ 1 🎉 1

elegaanz (Перенесено из github.com) оставлена рецензия 2019-05-01 20:17:06 +00:00

.circleci/images/plume-buildenv/cargo_config

					
				@ -1,3 +1,3 @@

				[target.x86_64-unknown-linux-gnu]

				# link dead code for coverage, attempt to reduce linking memory usage to not get killed

				rustflags = ["-Clink-dead-code", "-Clink-args=-Xlinker --no-keep-memory -Xlinker --reduce-memory-overheads"]

				rustflags = ["-Clink-args=-Xlinker --no-keep-memory -Xlinker --reduce-memory-overheads"]

elegaanz (Перенесено из github.com) оставлен комментарий

2019-05-01 20:17:05 +00:00

Don't we need to link dead code anymore?

trinity-1686a оставлена рецензия 2019-05-01 20:49:49 +00:00

.circleci/images/plume-buildenv/cargo_config

					
				@ -1,3 +1,3 @@

				[target.x86_64-unknown-linux-gnu]

				# link dead code for coverage, attempt to reduce linking memory usage to not get killed

				rustflags = ["-Clink-dead-code", "-Clink-args=-Xlinker --no-keep-memory -Xlinker --reduce-memory-overheads"]

				rustflags = ["-Clink-args=-Xlinker --no-keep-memory -Xlinker --reduce-memory-overheads"]

trinity-1686a оставлен комментарий

2019-05-01 20:49:49 +00:00

Автор

Владелец

It's somewhere it this line now https://github.com/Plume-org/Plume/pull/558/files#diff-1d37e48f9ceff6d8030570cd36286a61R74 , and having that here was an error : release builds were run with linked dead code too (not a problem, but it makes for bigger binaries)

elegaanz (Перенесено из github.com) оставлена рецензия 2019-05-01 21:54:09 +00:00

.circleci/config.yml

elegaanz (Перенесено из github.com) оставлен комментарий

2019-05-01 21:52:19 +00:00

Could it be possible to give more distinct name to these? I think that because of that we get one job called "clippy" (or whatever) and another one "cliipy-1", but it is not clear which one uses SQlite or PostgreSQL.

trinity-1686a оставлена рецензия 2019-05-01 22:02:13 +00:00

.circleci/config.yml

trinity-1686a оставлен комментарий

2019-05-01 22:02:13 +00:00

Автор

Владелец

not without having to duplicate config sadly :/

elegaanz (Перенесено из github.com) оставлена рецензия 2019-05-01 22:05:45 +00:00

.circleci/config.yml

elegaanz (Перенесено из github.com) оставлен комментарий

2019-05-01 22:05:45 +00:00

OK, let's forget about it then, it was more bonus.

codecov[bot] оставлен комментарий

2019-05-02 11:02:28 +00:00

(Перенесено из github.com)

Codecov Report

Merging #558 into master will decrease coverage by 6.9%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #558      +/-   ##
==========================================
- Coverage   41.96%   35.05%   -6.91%     
==========================================
  Files          70       67       -3     
  Lines        8839     7825    -1014     
  Branches        0     1876    +1876     
==========================================
- Hits         3709     2743     -966     
+ Misses       5130     4323     -807     
- Partials        0      759     +759

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/558?src=pr&el=h1) Report > Merging [#558](https://codecov.io/gh/Plume-org/Plume/pull/558?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/33a0c7dcd3c4377db338ed380ab33c88caeed4bf?src=pr&el=desc) will **decrease** coverage by `6.9%`. > The diff coverage is `100%`. ```diff @@ Coverage Diff @@ ## master #558 +/- ## ========================================== - Coverage 41.96% 35.05% -6.91% ========================================== Files 70 67 -3 Lines 8839 7825 -1014 Branches 0 1876 +1876 ========================================== - Hits 3709 2743 -966 + Misses 5130 4323 -807 - Partials 0 759 +759 ```

trinity-1686a оставлена рецензия 2019-05-02 13:43:47 +00:00

.circleci/config.yml

trinity-1686a оставлен комментарий

2019-05-02 13:43:47 +00:00

Автор

Владелец

kinda related, I'd prefer to use an enum telling we should use sqlite or postgres, but there is no way to do conditional based on other things than boolean :/
And there is no way to select if we use a docker or not, just to select which one, so I run empty alpine when nothing is needed.
I feel like this new syntax is better than the previous, but it misses some core features to not feel hacky in many places

kinda related, I'd prefer to use an enum telling we should use sqlite or postgres, but there is no way to do conditional based on other things than boolean :/ And there is no way to select if we use a docker or not, just to select which one, so I run empty alpine when nothing is needed. I feel like this new syntax is better than the previous, but it misses some core features to not feel hacky in many places

igalic (Перенесено из github.com) оставлена рецензия 2019-05-03 14:22:13 +00:00

igalic (Перенесено из github.com) оставил комментарий

😵

.circleci/config.yml

					
				@ -199,0 +92,4 @@

				    parameters:

				      package:

				        type: string

				        default: plume

igalic (Перенесено из github.com) оставлен комментарий

2019-05-03 14:21:35 +00:00

that seems excessive

elegaanz (Перенесено из github.com) оставлена рецензия 2019-05-03 14:26:18 +00:00

.circleci/config.yml

					
				@ -199,0 +92,4 @@

				    parameters:

				      package:

				        type: string

				        default: plume

elegaanz (Перенесено из github.com) оставлен комментарий

2019-05-03 14:26:18 +00:00

Yeah, but don't worry, this was an old version, now we only repeat it a few times:

for i in 36 4 2 1 1; do
   ...

where i is the number of threads of the command.

It is to avoid job failures because of OOM errors.

Yeah, but don't worry, this was an old version, now we only repeat it a few times: ```bash for i in 36 4 2 1 1; do ... ``` where `i` is the number of threads of the command. It is to avoid job failures because of OOM errors.

trinity-1686a оставлена рецензия 2019-05-03 14:27:11 +00:00

.circleci/config.yml

					
				@ -199,0 +92,4 @@

				    parameters:

				      package:

				        type: string

				        default: plume

trinity-1686a оставлен комментарий

2019-05-03 14:27:11 +00:00

Автор

Владелец

I think you're reviewing an older commit

elegaanz (Перенесено из github.com) изменения одобрены 2019-05-04 10:55:10 +00:00

elegaanz (Перенесено из github.com) оставил комментарий

Seems to work as expected (sorry for the long time, I didn't saw this was ready for review). Thank you!

Войдите, чтобы присоединиться к обсуждению.

Нет рецензентов

elegaanz

Нет этапа

Нет проекта

Нет назначенных

2 участников

Уведомления

Срок выполнения

Срок выполнения недействителен или находится за пределами допустимого диапазона. Пожалуйста, используйте формат «гггг-мм-дд».

Срок выполнения не установлен.

Зависимости

Зависимостей нет.

Ссылка: Plume/Plume#558

Кол-во строк
Кол-во столбцов