Plume
/
Plume
8
16
Форкнуть 22
Код Задачи 174 Запросы на слияние 8 Релизы 8 Вики Активность

Метки Этапы

rewrite circleci config #558

Слито
Plume_migration_agent слито 12 коммит(ов) из rework-ci в master 5 лет назад
Обсуждение 1 Коммиты 12 Изменённые файлы 8
trinity-1686a прокомментировал(а) 5 лет назад
Владелец
  • use better syntax
  • grcov for coverage
  • automatize crowdin interactions
- [x] use better syntax - [x] grcov for coverage - [x] automatize crowdin interactions
👍 1 ❤️ 1 🎉 1
elegaanz (Перенесено из github.com) рассмотрел(а) изменения 5 лет назад
.circleci/images/plume-buildenv/cargo_config
@ -1,3 +1,3 @@
[target.x86_64-unknown-linux-gnu]
# link dead code for coverage, attempt to reduce linking memory usage to not get killed
rustflags = ["-Clink-dead-code", "-Clink-args=-Xlinker --no-keep-memory -Xlinker --reduce-memory-overheads"]
rustflags = ["-Clink-args=-Xlinker --no-keep-memory -Xlinker --reduce-memory-overheads"]
elegaanz (Перенесено из github.com) прокомментировал(а) 5 лет назад

Don't we need to link dead code anymore?

Don't we need to link dead code anymore?
trinity-1686a рассмотрел(а) изменения 5 лет назад
.circleci/images/plume-buildenv/cargo_config
@ -1,3 +1,3 @@
[target.x86_64-unknown-linux-gnu]
# link dead code for coverage, attempt to reduce linking memory usage to not get killed
rustflags = ["-Clink-dead-code", "-Clink-args=-Xlinker --no-keep-memory -Xlinker --reduce-memory-overheads"]
rustflags = ["-Clink-args=-Xlinker --no-keep-memory -Xlinker --reduce-memory-overheads"]
trinity-1686a прокомментировал(а) 5 лет назад
Автор
Владелец

It's somewhere it this line now https://github.com/Plume-org/Plume/pull/558/files#diff-1d37e48f9ceff6d8030570cd36286a61R74 , and having that here was an error : release builds were run with linked dead code too (not a problem, but it makes for bigger binaries)

It's somewhere it this line now https://github.com/Plume-org/Plume/pull/558/files#diff-1d37e48f9ceff6d8030570cd36286a61R74 , and having that here was an error : release builds were run with linked dead code too (not a problem, but it makes for bigger binaries)
elegaanz (Перенесено из github.com) рассмотрел(а) изменения 5 лет назад
.circleci/config.yml
elegaanz (Перенесено из github.com) прокомментировал(а) 5 лет назад

Could it be possible to give more distinct name to these? I think that because of that we get one job called "clippy" (or whatever) and another one "cliipy-1", but it is not clear which one uses SQlite or PostgreSQL.

Could it be possible to give more distinct name to these? I think that because of that we get one job called "clippy" (or whatever) and another one "cliipy-1", but it is not clear which one uses SQlite or PostgreSQL.
trinity-1686a рассмотрел(а) изменения 5 лет назад
.circleci/config.yml
trinity-1686a прокомментировал(а) 5 лет назад
Автор
Владелец

not without having to duplicate config sadly :/

not without having to duplicate config sadly :/
elegaanz (Перенесено из github.com) рассмотрел(а) изменения 5 лет назад
.circleci/config.yml
elegaanz (Перенесено из github.com) прокомментировал(а) 5 лет назад

OK, let's forget about it then, it was more bonus.

OK, let's forget about it then, it was more bonus.
codecov[bot] прокомментировал(а) 5 лет назад (Перенесено из github.com)

Codecov Report

Merging #558 into master will decrease coverage by 6.9%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #558      +/-   ##
==========================================
- Coverage   41.96%   35.05%   -6.91%     
==========================================
  Files          70       67       -3     
  Lines        8839     7825    -1014     
  Branches        0     1876    +1876     
==========================================
- Hits         3709     2743     -966     
+ Misses       5130     4323     -807     
- Partials        0      759     +759
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/558?src=pr&el=h1) Report > Merging [#558](https://codecov.io/gh/Plume-org/Plume/pull/558?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/33a0c7dcd3c4377db338ed380ab33c88caeed4bf?src=pr&el=desc) will **decrease** coverage by `6.9%`. > The diff coverage is `100%`. ```diff @@ Coverage Diff @@ ## master #558 +/- ## ========================================== - Coverage 41.96% 35.05% -6.91% ========================================== Files 70 67 -3 Lines 8839 7825 -1014 Branches 0 1876 +1876 ========================================== - Hits 3709 2743 -966 + Misses 5130 4323 -807 - Partials 0 759 +759 ```
trinity-1686a рассмотрел(а) изменения 5 лет назад
.circleci/config.yml
trinity-1686a прокомментировал(а) 5 лет назад
Автор
Владелец

kinda related, I'd prefer to use an enum telling we should use sqlite or postgres, but there is no way to do conditional based on other things than boolean :/
And there is no way to select if we use a docker or not, just to select which one, so I run empty alpine when nothing is needed.
I feel like this new syntax is better than the previous, but it misses some core features to not feel hacky in many places

kinda related, I'd prefer to use an enum telling we should use sqlite or postgres, but there is no way to do conditional based on other things than boolean :/ And there is no way to select if we use a docker or not, just to select which one, so I run empty alpine when nothing is needed. I feel like this new syntax is better than the previous, but it misses some core features to not feel hacky in many places
igalic (Перенесено из github.com) рассмотрел(а) изменения 5 лет назад
igalic (Перенесено из github.com) оставил комментарий

😵

😵
.circleci/config.yml
@ -199,0 +92,4 @@
parameters:
package:
type: string
default: plume
igalic (Перенесено из github.com) прокомментировал(а) 5 лет назад

that seems excessive

that seems excessive
elegaanz (Перенесено из github.com) рассмотрел(а) изменения 5 лет назад
.circleci/config.yml
@ -199,0 +92,4 @@
parameters:
package:
type: string
default: plume
elegaanz (Перенесено из github.com) прокомментировал(а) 5 лет назад

Yeah, but don't worry, this was an old version, now we only repeat it a few times:

for i in 36 4 2 1 1; do
   ...

where i is the number of threads of the command.

It is to avoid job failures because of OOM errors.

Yeah, but don't worry, this was an old version, now we only repeat it a few times: ```bash for i in 36 4 2 1 1; do ... ``` where `i` is the number of threads of the command. It is to avoid job failures because of OOM errors.
trinity-1686a рассмотрел(а) изменения 5 лет назад
.circleci/config.yml
@ -199,0 +92,4 @@
parameters:
package:
type: string
default: plume
trinity-1686a прокомментировал(а) 5 лет назад
Автор
Владелец

I think you're reviewing an older commit

I think you're reviewing an older commit
elegaanz (Перенесено из github.com) одобрил(а) эти изменения 5 лет назад
elegaanz (Перенесено из github.com) оставил комментарий

Seems to work as expected (sorry for the long time, I didn't saw this was ready for review). Thank you!

Seems to work as expected (sorry for the long time, I didn't saw this was ready for review). Thank you!

Рецензенты

elegaanz
Запрос на слияние был объединен как 918bda14ec.
Вы также можете просмотреть инструкции командной строки.

Шаг 1:

В репозитории вашего проекта посмотрите новую ветку и протестируйте изменения.
git checkout -b rework-ci master
git pull origin rework-ci

Шаг 2:

Объединить изменения и обновить на Forgejo.
git checkout master
git merge --no-ff rework-ci
git push origin master
Войдите, чтобы присоединиться к обсуждению.
Рецензенты
Запросить отзыв
Нет рецензентов
elegaanz
Метки
Применить метки
Очистить метки   
A: API

Related to the REST API   
A: Backend

Code running on the server   
A: Federation

Stuff related to Federation   
A: Front-End

Related to the front-end   
A: I18N

Translations, and related code   
A: Meta

More about project management or code than the project itself   
A: Security
   
Build

The building, or installation process of Plume   
C: Bug

Something isn't working   
C: Discussion

We need to talk   
C: Enhancement

New feature or request   
C: Feature

This is a new feature   
Compatibility

Compatibility with different browsers, readers and OS   
Dependency

Related to an external package that Plume uses   
Design

UI/UX related issues and PRs   
Documentation
   
Good first issue

Good for newcomers   
Help welcome

Extra attention is needed   
Mobile

Issues affecting only mobile UX   
Rendering

How elements're rendered out for the end user   
S: Blocked

Something else needs to be fixed first   
S: Duplicate

This issue or pull request already exists   
S: Incomplete

This PR is not complete yet   
S: Instance specific

Issues concern a limited number of instances   
S: Invalid

This doesn't seem right   
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)   
S: Ready for review

This PR is ready to be reviewed   
Suggestion

Proposed ideas worth considering   
S: Voted on Loomio

This is issue has been created after a vote on Loomio   
S: Wontfix

This will not be worked on
Нет меток
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Этап
Установить этап
Очистить этап
Нет элементов
Нет этапа
Назначенные
Назначить пользователей
Убрать ответственных
Нет назначенных лиц
2 участников
Уведомления
Срок выполнения
Срок действия недействителен или находится за пределами допустимого диапазона. Пожалуйста, используйте формат 'гггг-мм-дд'.

Срок выполнения не установлен.

Зависимости

Зависимостей нет.

Reference: Plume/Plume#558
Редактирование Предпросмотр
Загрузка…
Отмена
Сохранить
Пока нет содержимого.
Удалить ветку 'rework-ci'

Удаление ветки НЕОБРАТИМО. Действительно удалить?

Нет
Да