Plume
/
Plume
8
16
Fork 22
Code Issues 174 Pull Requests 8 Releases 8 Wiki Activity

Labels Milestones

rewrite circleci config #558

Merged
Plume_migration_agent merged 12 commits from rework-ci into master 5 years ago
Conversation 1 Commits 12 Files Changed 8
trinity-1686a commented 5 years ago
Owner
  • use better syntax
  • grcov for coverage
  • automatize crowdin interactions
- [x] use better syntax - [x] grcov for coverage - [x] automatize crowdin interactions
👍 1 ❤️ 1 🎉 1
elegaanz (Migrated from github.com) reviewed 5 years ago
.circleci/images/plume-buildenv/cargo_config
@ -1,3 +1,3 @@
[target.x86_64-unknown-linux-gnu]
# link dead code for coverage, attempt to reduce linking memory usage to not get killed
rustflags = ["-Clink-dead-code", "-Clink-args=-Xlinker --no-keep-memory -Xlinker --reduce-memory-overheads"]
rustflags = ["-Clink-args=-Xlinker --no-keep-memory -Xlinker --reduce-memory-overheads"]
elegaanz (Migrated from github.com) commented 5 years ago

Don't we need to link dead code anymore?

Don't we need to link dead code anymore?
trinity-1686a reviewed 5 years ago
.circleci/images/plume-buildenv/cargo_config
@ -1,3 +1,3 @@
[target.x86_64-unknown-linux-gnu]
# link dead code for coverage, attempt to reduce linking memory usage to not get killed
rustflags = ["-Clink-dead-code", "-Clink-args=-Xlinker --no-keep-memory -Xlinker --reduce-memory-overheads"]
rustflags = ["-Clink-args=-Xlinker --no-keep-memory -Xlinker --reduce-memory-overheads"]
trinity-1686a commented 5 years ago
Poster
Owner

It's somewhere it this line now https://github.com/Plume-org/Plume/pull/558/files#diff-1d37e48f9ceff6d8030570cd36286a61R74 , and having that here was an error : release builds were run with linked dead code too (not a problem, but it makes for bigger binaries)

It's somewhere it this line now https://github.com/Plume-org/Plume/pull/558/files#diff-1d37e48f9ceff6d8030570cd36286a61R74 , and having that here was an error : release builds were run with linked dead code too (not a problem, but it makes for bigger binaries)
elegaanz (Migrated from github.com) reviewed 5 years ago
.circleci/config.yml
elegaanz (Migrated from github.com) commented 5 years ago

Could it be possible to give more distinct name to these? I think that because of that we get one job called "clippy" (or whatever) and another one "cliipy-1", but it is not clear which one uses SQlite or PostgreSQL.

Could it be possible to give more distinct name to these? I think that because of that we get one job called "clippy" (or whatever) and another one "cliipy-1", but it is not clear which one uses SQlite or PostgreSQL.
trinity-1686a reviewed 5 years ago
.circleci/config.yml
trinity-1686a commented 5 years ago
Poster
Owner

not without having to duplicate config sadly :/

not without having to duplicate config sadly :/
elegaanz (Migrated from github.com) reviewed 5 years ago
.circleci/config.yml
elegaanz (Migrated from github.com) commented 5 years ago

OK, let's forget about it then, it was more bonus.

OK, let's forget about it then, it was more bonus.
codecov[bot] commented 5 years ago (Migrated from github.com)

Codecov Report

Merging #558 into master will decrease coverage by 6.9%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #558      +/-   ##
==========================================
- Coverage   41.96%   35.05%   -6.91%     
==========================================
  Files          70       67       -3     
  Lines        8839     7825    -1014     
  Branches        0     1876    +1876     
==========================================
- Hits         3709     2743     -966     
+ Misses       5130     4323     -807     
- Partials        0      759     +759
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/558?src=pr&el=h1) Report > Merging [#558](https://codecov.io/gh/Plume-org/Plume/pull/558?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/33a0c7dcd3c4377db338ed380ab33c88caeed4bf?src=pr&el=desc) will **decrease** coverage by `6.9%`. > The diff coverage is `100%`. ```diff @@ Coverage Diff @@ ## master #558 +/- ## ========================================== - Coverage 41.96% 35.05% -6.91% ========================================== Files 70 67 -3 Lines 8839 7825 -1014 Branches 0 1876 +1876 ========================================== - Hits 3709 2743 -966 + Misses 5130 4323 -807 - Partials 0 759 +759 ```
trinity-1686a reviewed 5 years ago
.circleci/config.yml
trinity-1686a commented 5 years ago
Poster
Owner

kinda related, I'd prefer to use an enum telling we should use sqlite or postgres, but there is no way to do conditional based on other things than boolean :/
And there is no way to select if we use a docker or not, just to select which one, so I run empty alpine when nothing is needed.
I feel like this new syntax is better than the previous, but it misses some core features to not feel hacky in many places

kinda related, I'd prefer to use an enum telling we should use sqlite or postgres, but there is no way to do conditional based on other things than boolean :/ And there is no way to select if we use a docker or not, just to select which one, so I run empty alpine when nothing is needed. I feel like this new syntax is better than the previous, but it misses some core features to not feel hacky in many places
igalic (Migrated from github.com) reviewed 5 years ago
igalic (Migrated from github.com) left a comment

😵

😵
.circleci/config.yml
@ -199,0 +92,4 @@
parameters:
package:
type: string
default: plume
igalic (Migrated from github.com) commented 5 years ago

that seems excessive

that seems excessive
elegaanz (Migrated from github.com) reviewed 5 years ago
.circleci/config.yml
@ -199,0 +92,4 @@
parameters:
package:
type: string
default: plume
elegaanz (Migrated from github.com) commented 5 years ago

Yeah, but don't worry, this was an old version, now we only repeat it a few times:

for i in 36 4 2 1 1; do
   ...

where i is the number of threads of the command.

It is to avoid job failures because of OOM errors.

Yeah, but don't worry, this was an old version, now we only repeat it a few times: ```bash for i in 36 4 2 1 1; do ... ``` where `i` is the number of threads of the command. It is to avoid job failures because of OOM errors.
trinity-1686a reviewed 5 years ago
.circleci/config.yml
@ -199,0 +92,4 @@
parameters:
package:
type: string
default: plume
trinity-1686a commented 5 years ago
Poster
Owner

I think you're reviewing an older commit

I think you're reviewing an older commit
elegaanz (Migrated from github.com) approved these changes 5 years ago
elegaanz (Migrated from github.com) left a comment

Seems to work as expected (sorry for the long time, I didn't saw this was ready for review). Thank you!

Seems to work as expected (sorry for the long time, I didn't saw this was ready for review). Thank you!

Reviewers

elegaanz
The pull request has been merged as 918bda14ec.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b rework-ci master
git pull origin rework-ci

Step 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff rework-ci
git push origin master
Sign in to join this conversation.
Reviewers
Request review
No reviewers
elegaanz
Labels
Apply labels
Clear labels   
A: API

Related to the REST API   
A: Backend

Code running on the server   
A: Federation

Stuff related to Federation   
A: Front-End

Related to the front-end   
A: I18N

Translations, and related code   
A: Meta

More about project management or code than the project itself   
A: Security
   
Build

The building, or installation process of Plume   
C: Bug

Something isn't working   
C: Discussion

We need to talk   
C: Enhancement

New feature or request   
C: Feature

This is a new feature   
Compatibility

Compatibility with different browsers, readers and OS   
Dependency

Related to an external package that Plume uses   
Design

UI/UX related issues and PRs   
Documentation
   
Good first issue

Good for newcomers   
Help welcome

Extra attention is needed   
Mobile

Issues affecting only mobile UX   
Rendering

How elements're rendered out for the end user   
S: Blocked

Something else needs to be fixed first   
S: Duplicate

This issue or pull request already exists   
S: Incomplete

This PR is not complete yet   
S: Instance specific

Issues concern a limited number of instances   
S: Invalid

This doesn't seem right   
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)   
S: Ready for review

This PR is ready to be reviewed   
Suggestion

Proposed ideas worth considering   
S: Voted on Loomio

This is issue has been created after a vote on Loomio   
S: Wontfix

This will not be worked on
No Label
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#558
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'rework-ci'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes