WIP - initial RTL support #575 #577

Merged

ahangarha merged 9 commits from add-rtl-support into master

2019-07-11 07:34:28 +00:00

ahangarha commented

2019-05-13 18:13:59 +00:00

(Migrated from github.com)

In regard to #575, few fixes have been done so far. Yet, there are many others to be made, including:

BIDI to be applied to form fields (which are rendered dynamically)
fix css styles and remove text-align, modify margin/madding left/right
BIDI to be applied to every elements inside article for post content

In regard to #575, few fixes have been done so far. Yet, there are many others to be made, including: - [x] BIDI to be applied to form fields (which are rendered dynamically) - [ ] fix css styles and remove text-align, modify margin/madding left/right - [ ] BIDI to be applied to every elements inside article for post content

🎉 4

trinity-1686a commented

2019-05-13 19:36:08 +00:00

Owner

if you want to tinker that, forms are rendered using what's in src/template_utils.rs on line 241-249 and 335-336

if you want to tinker that, forms are rendered using what's in `src/template_utils.rs` on line 241-249 and 335-336

👍 1

codecov[bot] commented

2019-05-13 19:40:21 +00:00

(Migrated from github.com)

Codecov Report

Merging #577 into master will decrease coverage by 0.76%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #577      +/-   ##
==========================================
- Coverage   35.28%   34.51%   -0.77%     
==========================================
  Files          68       67       -1     
  Lines        7899     7872      -27     
  Branches     1891     1890       -1     
==========================================
- Hits         2787     2717      -70     
- Misses       4334     4394      +60     
+ Partials      778      761      -17

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/577?src=pr&el=h1) Report > Merging [#577](https://codecov.io/gh/Plume-org/Plume/pull/577?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/c031804464a22c550ff621483811a202ecbb238c?src=pr&el=desc) will **decrease** coverage by `0.76%`. > The diff coverage is `50%`. ```diff @@ Coverage Diff @@ ## master #577 +/- ## ========================================== - Coverage 35.28% 34.51% -0.77% ========================================== Files 68 67 -1 Lines 7899 7872 -27 Branches 1891 1890 -1 ========================================== - Hits 2787 2717 -70 - Misses 4334 4394 +60 + Partials 778 761 -17 ```

ahangarha commented

2019-05-16 17:43:45 +00:00

(Migrated from github.com)

if you want to tinker that, forms are rendered using what's in src/template_utils.rs on line 241-249 and 335-336

this was really helpful. I made changes and pushed it up. CI ended in failure. was it because of my changes?

> if you want to tinker that, forms are rendered using what's in `src/template_utils.rs` on line 241-249 and 335-336 this was really helpful. I made changes and pushed it up. CI ended in failure. was it because of my changes?

elegaanz commented

2019-05-16 18:23:43 +00:00

(Migrated from github.com)

No it was not your fault, CI fails for no good reasons sometimes. I restarted the failed job, let's hope it will work this time.

👍 1

trinity-1686a commented

2019-07-07 16:28:13 +00:00

Owner

BIDI to be applied to form fields (which are rendered dynamically)

fix css styles and remove text-align, modify margin/madding left/right

BIDI to be applied to every elements inside article for post content

I've merged master back to this branch, would you like to work on fixing css before we merge this, or can we merge it, and this would be for a further pr?

> * [x] BIDI to be applied to form fields (which are rendered dynamically) > * [ ] fix css styles and remove text-align, modify margin/madding left/right > * [ ] BIDI to be applied to every elements inside article for post content I've merged master back to this branch, would you like to work on fixing css before we merge this, or can we merge it, and this would be for a further pr?

👍 1

ahangarha commented

2019-07-08 09:53:27 +00:00

(Migrated from github.com)

It you don't mind, merge it. I will send another PR for the following improvements.

👍 1

trinity-1686a approved these changes 2019-07-10 19:09:38 +00:00

trinity-1686a left a comment

Owner

👍

:+1: