Plume/Plume

Fork 24

Update textarea overflow to scroll #609

Merged

marek-lach merged 3 commits from scrollable-textarea into master

2019-06-02 20:35:10 +00:00

marek-lach commented

2019-06-02 11:47:49 +00:00

(Migrated from github.com)

Partial fix for #604.

👍 1

codecov[bot] commented

2019-06-02 12:03:00 +00:00

(Migrated from github.com)

Codecov Report

Merging #609 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #609      +/-   ##
=========================================
+ Coverage   34.56%   34.6%   +0.03%     
=========================================
  Files          67      67              
  Lines        7840    7840              
  Branches     1883    1883              
=========================================
+ Hits         2710    2713       +3     
  Misses       4367    4367              
+ Partials      763     760       -3

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/609?src=pr&el=h1) Report > Merging [#609](https://codecov.io/gh/Plume-org/Plume/pull/609?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/bffce041d76b04e0daee38f915909fc35f159ae4?src=pr&el=desc) will **increase** coverage by `0.03%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #609 +/- ## ========================================= + Coverage 34.56% 34.6% +0.03% ========================================= Files 67 67 Lines 7840 7840 Branches 1883 1883 ========================================= + Hits 2710 2713 +3 Misses 4367 4367 + Partials 763 760 -3 ```

elegaanz (Migrated from github.com) reviewed 2019-06-02 16:39:28 +00:00

elegaanz (Migrated from github.com) left a comment

I didn't tested (for some reason it is not deployed on pr-609.joinplu.me 😕), but it seems reasonable.

I didn't tested (for some reason it is not deployed on pr-609.joinplu.me :confused:), but it seems reasonable.

marek-lach commented

2019-06-02 16:46:07 +00:00

(Migrated from github.com)

I didn't tested (for some reason it is not deployed on pr-609.joinplu.me 😕), but it seems reasonable.

It does... I mean testing it live would probably be a good idea still, but there's really no reason why it should cause any problems. Pretty basic stuff overall...

> I didn't tested (for some reason it is not deployed on pr-609.joinplu.me 😕), but it seems reasonable. It does... I mean testing it live would probably be a good idea still, but there's really no reason why it should cause any problems. Pretty basic stuff overall...

elegaanz (Migrated from github.com) reviewed 2019-06-02 17:15:11 +00:00

static/css/_forms.scss

elegaanz (Migrated from github.com) commented

2019-06-02 17:15:11 +00:00

This line should be removed, otherwise there is a weird and useless scrollbar on the right of the whole form:

This line should be removed, otherwise there is a weird and useless scrollbar on the right of the whole form: ![image](https://user-images.githubusercontent.com/16254623/58764689-57552d80-8562-11e9-8db3-0e7e41e44198.png)

marek-lach commented

2019-06-02 20:18:23 +00:00

(Migrated from github.com)

Right. Done.

elegaanz (Migrated from github.com) approved these changes 2019-06-02 20:34:57 +00:00

No reviewers

elegaanz

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#609

No description provided.

Rows
Columns