Use futures and tokio to send activities #620

Merged

elegaanz merged 4 commits from async-federation into master

2019-06-27 16:46:05 +00:00

elegaanz commented

2019-06-18 21:21:28 +00:00

(Migrated from github.com)

Fixes #252

Publishing an article and having it federated to the whole fediverse only takes a few seconds now (instead of minutes before, on big Plume instances connected to many other ones).

Fixes #252 Publishing an article and having it federated to the whole fediverse only takes a few seconds now (instead of minutes before, on big Plume instances connected to many other ones).

igalic (Migrated from github.com) reviewed 2019-06-18 22:50:35 +00:00

igalic (Migrated from github.com) left a comment

👀

plume-common/src/activity_pub/mod.rs

igalic (Migrated from github.com) commented

2019-06-18 22:48:23 +00:00

is this comment still relevant?

igalic (Migrated from github.com) commented

2019-06-18 22:49:00 +00:00

if this fails, we panic with "new rt".??

igalic (Migrated from github.com) commented

2019-06-18 22:50:19 +00:00

i think we should talk about our logging strategy sometime 😅

elegaanz (Migrated from github.com) reviewed 2019-06-19 07:25:47 +00:00

plume-common/src/activity_pub/mod.rs

elegaanz (Migrated from github.com) commented

2019-06-19 07:25:47 +00:00

Not really, but it is for the background jobs in general, for the moment we just spawn them in a separate thread and that's it. I will remove it and create a more general issue.

elegaanz (Migrated from github.com) reviewed 2019-06-19 07:26:33 +00:00

plume-common/src/activity_pub/mod.rs

elegaanz (Migrated from github.com) commented

2019-06-19 07:26:33 +00:00

Hum… yes, I could probably change that. To be honest I copied this line from reqwest examples without really thinking about it 😅

Hum… yes, I could probably change that. To be honest I copied this line from reqwest examples without really thinking about it :sweat_smile:

elegaanz (Migrated from github.com) reviewed 2019-06-19 07:27:26 +00:00

plume-common/src/activity_pub/mod.rs

elegaanz (Migrated from github.com) commented

2019-06-19 07:27:26 +00:00

Indeed, we should probably use log and env_logger or something like that. Should I create an issue?

Indeed, we should probably use `log` and `env_logger` or something like that. Should I create an issue?

codecov[bot] commented

2019-06-19 07:44:46 +00:00

(Migrated from github.com)

Codecov Report

Merging #620 into master will increase coverage by 0.08%.
The diff coverage is 26.66%.

@@            Coverage Diff             @@
##           master     #620      +/-   ##
==========================================
+ Coverage   35.28%   35.37%   +0.08%     
==========================================
  Files          68       68              
  Lines        7907     7904       -3     
  Branches     1893     1887       -6     
==========================================
+ Hits         2790     2796       +6     
+ Misses       4345     4338       -7     
+ Partials      772      770       -2

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/620?src=pr&el=h1) Report > Merging [#620](https://codecov.io/gh/Plume-org/Plume/pull/620?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/6dbc043a7e4d1757851599859683804bf36a3409?src=pr&el=desc) will **increase** coverage by `0.08%`. > The diff coverage is `26.66%`. ```diff @@ Coverage Diff @@ ## master #620 +/- ## ========================================== + Coverage 35.28% 35.37% +0.08% ========================================== Files 68 68 Lines 7907 7904 -3 Branches 1893 1887 -6 ========================================== + Hits 2790 2796 +6 + Misses 4345 4338 -7 + Partials 772 770 -2 ```