#620 Use futures and tokio to send activities

Merged
elegaanz merged 4 commits from async-federation into master 1 year ago
elegaanz commented 1 year ago (Migrated from github.com)

Fixes #252

Publishing an article and having it federated to the whole fediverse only takes a few seconds now (instead of minutes before, on big Plume instances connected to many other ones).

Fixes #252 Publishing an article and having it federated to the whole fediverse only takes a few seconds now (instead of minutes before, on big Plume instances connected to many other ones).
igalic (Migrated from github.com) reviewed 1 year ago
igalic (Migrated from github.com) left a comment

👀

Plume_migration_agent commented 1 year ago

is this comment still relevant?

is this comment still relevant?
Plume_migration_agent commented 1 year ago

if this fails, we panic with “new rt”.??

if this fails, we panic with "new rt".??
Plume_migration_agent commented 1 year ago

i think we should talk about our logging strategy sometime 😅

i think we should talk about our logging strategy sometime 😅
elegaanz (Migrated from github.com) reviewed 1 year ago
Plume_migration_agent commented 1 year ago

Not really, but it is for the background jobs in general, for the moment we just spawn them in a separate thread and that’s it. I will remove it and create a more general issue.

Not really, but it is for the background jobs in general, for the moment we just spawn them in a separate thread and that's it. I will remove it and create a more general issue.
elegaanz (Migrated from github.com) reviewed 1 year ago
Plume_migration_agent commented 1 year ago

Hum… yes, I could probably change that. To be honest I copied this line from reqwest examples without really thinking about it 😅

Hum… yes, I could probably change that. To be honest I copied this line from reqwest examples without really thinking about it :sweat_smile:
elegaanz (Migrated from github.com) reviewed 1 year ago
Plume_migration_agent commented 1 year ago

Indeed, we should probably use log and env_logger or something like that. Should I create an issue?

Indeed, we should probably use `log` and `env_logger` or something like that. Should I create an issue?
codecov[bot] commented 1 year ago (Migrated from github.com)
Owner

Codecov Report

Merging #620 into master will increase coverage by 0.08%.
The diff coverage is 26.66%.

@@            Coverage Diff             @@
##           master     #620      +/-   ##
==========================================
+ Coverage   35.28%   35.37%   +0.08%     
==========================================
  Files          68       68              
  Lines        7907     7904       -3     
  Branches     1893     1887       -6     
==========================================
+ Hits         2790     2796       +6     
+ Misses       4345     4338       -7     
+ Partials      772      770       -2
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/620?src=pr&el=h1) Report > Merging [#620](https://codecov.io/gh/Plume-org/Plume/pull/620?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/6dbc043a7e4d1757851599859683804bf36a3409?src=pr&el=desc) will **increase** coverage by `0.08%`. > The diff coverage is `26.66%`. ```diff @@ Coverage Diff @@ ## master #620 +/- ## ========================================== + Coverage 35.28% 35.37% +0.08% ========================================== Files 68 68 Lines 7907 7904 -3 Branches 1893 1887 -6 ========================================== + Hits 2790 2796 +6 + Misses 4345 4338 -7 + Partials 772 770 -2 ```
trinity-1686a reviewed 1 year ago
trinity-1686a left a comment

👀

trinity-1686a commented 1 year ago

I think this print should be done in the map just under, otherwise output could get mixed quickly, making both logs useless

I think this print should be done in the map just under, otherwise output could get mixed quickly, making both logs useless
trinity-1686a commented 1 year ago

(what is that comma for?)

(what is that comma for?)
elegaanz (Migrated from github.com) reviewed 1 year ago
Plume_migration_agent commented 1 year ago

(no idea, I will remove it)

(no idea, I will remove it)
elegaanz (Migrated from github.com) reviewed 1 year ago
Plume_migration_agent commented 1 year ago

Actually, it is added by cargo-fmt, because this whole expression is the argument of a function.

Actually, it is added by cargo-fmt, because this whole expression is the argument of a function.
trinity-1686a approved these changes 1 year ago

Reviewers

trinity-1686a approved these changes 1 year ago
The pull request has been merged as 7ea4acc289.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.