Plume
/
Plume
7
9
Fork 8
Code Issues 131 Pull Requests 13 Releases 4 Wiki Activity
Labels Milestones
New Pull Request

#620 Use futures and tokio to send activities

Merged
elegaanz merged 4 commits from async-federation into master 1 year ago
Conversation 1 Commits 4 Files Changed 4
elegaanz commented 1 year ago (Migrated from github.com)

Fixes #252

Publishing an article and having it federated to the whole fediverse only takes a few seconds now (instead of minutes before, on big Plume instances connected to many other ones).

Fixes #252 Publishing an article and having it federated to the whole fediverse only takes a few seconds now (instead of minutes before, on big Plume instances connected to many other ones).
igalic (Migrated from github.com) reviewed 1 year ago
igalic (Migrated from github.com) left a comment

👀

plume-common/src/activity_pub/mod.rs
Plume_migration_agent commented 1 year ago

is this comment still relevant?

is this comment still relevant?
Plume_migration_agent commented 1 year ago

if this fails, we panic with “new rt”.??

if this fails, we panic with "new rt".??
Plume_migration_agent commented 1 year ago

i think we should talk about our logging strategy sometime 😅

i think we should talk about our logging strategy sometime 😅
elegaanz (Migrated from github.com) reviewed 1 year ago
plume-common/src/activity_pub/mod.rs
Plume_migration_agent commented 1 year ago

Not really, but it is for the background jobs in general, for the moment we just spawn them in a separate thread and that’s it. I will remove it and create a more general issue.

Not really, but it is for the background jobs in general, for the moment we just spawn them in a separate thread and that's it. I will remove it and create a more general issue.
elegaanz (Migrated from github.com) reviewed 1 year ago
plume-common/src/activity_pub/mod.rs
Plume_migration_agent commented 1 year ago

Hum… yes, I could probably change that. To be honest I copied this line from reqwest examples without really thinking about it 😅

Hum… yes, I could probably change that. To be honest I copied this line from reqwest examples without really thinking about it :sweat_smile:
elegaanz (Migrated from github.com) reviewed 1 year ago
plume-common/src/activity_pub/mod.rs
Plume_migration_agent commented 1 year ago

Indeed, we should probably use log and env_logger or something like that. Should I create an issue?

Indeed, we should probably use `log` and `env_logger` or something like that. Should I create an issue?
codecov[bot] commented 1 year ago (Migrated from github.com)
Owner

Codecov Report

Merging #620 into master will increase coverage by 0.08%.
The diff coverage is 26.66%.

@@            Coverage Diff             @@
##           master     #620      +/-   ##
==========================================
+ Coverage   35.28%   35.37%   +0.08%     
==========================================
  Files          68       68              
  Lines        7907     7904       -3     
  Branches     1893     1887       -6     
==========================================
+ Hits         2790     2796       +6     
+ Misses       4345     4338       -7     
+ Partials      772      770       -2
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/620?src=pr&el=h1) Report > Merging [#620](https://codecov.io/gh/Plume-org/Plume/pull/620?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/6dbc043a7e4d1757851599859683804bf36a3409?src=pr&el=desc) will **increase** coverage by `0.08%`. > The diff coverage is `26.66%`. ```diff @@ Coverage Diff @@ ## master #620 +/- ## ========================================== + Coverage 35.28% 35.37% +0.08% ========================================== Files 68 68 Lines 7907 7904 -3 Branches 1893 1887 -6 ========================================== + Hits 2790 2796 +6 + Misses 4345 4338 -7 + Partials 772 770 -2 ```
trinity-1686a reviewed 1 year ago
trinity-1686a left a comment

👀

plume-common/src/activity_pub/mod.rs
trinity-1686a commented 1 year ago

I think this print should be done in the map just under, otherwise output could get mixed quickly, making both logs useless

I think this print should be done in the map just under, otherwise output could get mixed quickly, making both logs useless
plume-common/src/activity_pub/mod.rs
trinity-1686a commented 1 year ago

(what is that comma for?)

(what is that comma for?)
elegaanz (Migrated from github.com) reviewed 1 year ago
plume-common/src/activity_pub/mod.rs
Plume_migration_agent commented 1 year ago

(no idea, I will remove it)

(no idea, I will remove it)
elegaanz (Migrated from github.com) reviewed 1 year ago
plume-common/src/activity_pub/mod.rs
Plume_migration_agent commented 1 year ago

Actually, it is added by cargo-fmt, because this whole expression is the argument of a function.

Actually, it is added by cargo-fmt, because this whole expression is the argument of a function.
trinity-1686a reviewed 1 year ago
plume-common/src/activity_pub/mod.rs
trinity-1686a commented 1 year ago

okay...

okay...
trinity-1686a approved these changes 1 year ago

Reviewers

trinity-1686a approved these changes 1 year ago
The pull request has been merged as 7ea4acc289.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
 trinity-1686a
Labels
Apply labels
Clear labels
A: API
Related to the REST API A: Backend
Code running on the server A: Federation
Stuff related to Federation A: Front-End
Related to the front-end A: I18N
Translations, and related code A: Meta
More about project management or code than the project itself A: Security Build
The building, or installation process of Plume C: Bug
Something isn't working C: Discussion
We need to talk C: Enhancement
New feature or request C: Feature
This is a new feature Compatibility
Compatibility with different browsers, readers and OS Dependency
Related to an external package that Plume uses Design
UI/UX related issues and PRs Documentation Good first issue
Good for newcomers Help welcome
Extra attention is needed Mobile
Issues affecting only mobile UX Rendering
How elements're rendered out for the end user S: Blocked
Something else needs to be fixed first S: Duplicate
This issue or pull request already exists S: Incomplete
This PR is not complete yet S: Instance specific
Issues concern a limited number of instances S: Invalid
This doesn't seem right S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio) S: Ready for review
This PR is ready to be reviewed Suggestion
Proposed ideas worth considering S: Voted on Loomio
This is issue has been created after a vote on Loomio S: Wontfix
This will not be worked on
No Label
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
1.0
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'async-federation'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes