Plume
/
Plume
8
16
Fork 22
Código Incidencias 174 Pull Requests 8 Lanzamientos 8 Wiki Actividad

Etiquetas Hitos

delete notification on user deletion #658

Fusionado
Plume_migration_agent fusionados 5 commits de bugfix/651 en master hace 5 años
Conversación 2 Commits 5 Archivos modificados 2
trinity-1686a comentado hace 5 años
Propietario

fix #651

before merging, I'd like to add a regression test

fix #651 before merging, I'd like to add a regression test
👍 1
codecov[bot] comentado hace 5 años (Migrado desde github.com)

Codecov Report

Merging #658 into master will increase coverage by 0.58%.
The diff coverage is 70%.

@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
+ Coverage   34.58%   35.17%   +0.58%     
==========================================
  Files          68       68              
  Lines        8020     7952      -68     
  Branches     1890     1893       +3     
==========================================
+ Hits         2774     2797      +23     
+ Misses       4468     4374      -94     
- Partials      778      781       +3
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/658?src=pr&el=h1) Report > Merging [#658](https://codecov.io/gh/Plume-org/Plume/pull/658?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/d46af6fe5bb472d0aa9435520690c3b94a3ec577?src=pr&el=desc) will **increase** coverage by `0.58%`. > The diff coverage is `70%`. ```diff @@ Coverage Diff @@ ## master #658 +/- ## ========================================== + Coverage 34.58% 35.17% +0.58% ========================================== Files 68 68 Lines 8020 7952 -68 Branches 1890 1893 +3 ========================================== + Hits 2774 2797 +23 + Misses 4468 4374 -94 - Partials 778 781 +3 ```
elegaanz (Migrado desde github.com) cambios solicitados hace 5 años
plume-models/src/notifications.rs
elegaanz (Migrado desde github.com) comentado hace 5 años

object_id is the ID of the Follow object actually.

`object_id` is the ID of the `Follow` object actually.
elegaanz (Migrado desde github.com) revisado hace 5 años
elegaanz (Migrado desde github.com) dejó un comentario

If the tests pass, you can merge!

If the tests pass, you can merge!
trinity-1686a comentado hace 5 años
Autor
Propietario

this has been stall for a bit, and I don't have time to fix the CI (the problem is not related to the fix, but to the way integration tests are run). I'll revert latests commit so we can merge it as is

this has been stall for a bit, and I don't have time to fix the CI (the problem is not related to the fix, but to the way integration tests are run). I'll revert latests commit so we can merge it as is
igalic (Migrado desde github.com) aprobado estos cambios hace 5 años
igalic (Migrado desde github.com) dejó un comentario

👍

👍

Revisores

elegaanz
igalic
El Pull Request se ha fusionado como 12c80f9981.
También puede ver instrucciones de línea de comandos.

Paso 1:

Desde el repositorio de su proyecto, revisa una nueva rama y prueba los cambios.
git checkout -b bugfix/651 master
git pull origin bugfix/651

Paso 2:

Combine los cambios y actualice en Forgejo.
git checkout master
git merge --no-ff bugfix/651
git push origin master
Inicie sesión para unirse a esta conversación.
Revisores
Solicitar revisión
No hay revisores
elegaanz
igalic
Etiquetas
Aplicar etiquetas
Limpiar etiquetas   
A: API

Related to the REST API   
A: Backend

Code running on the server   
A: Federation

Stuff related to Federation   
A: Front-End

Related to the front-end   
A: I18N

Translations, and related code   
A: Meta

More about project management or code than the project itself   
A: Security
   
Build

The building, or installation process of Plume   
C: Bug

Something isn't working   
C: Discussion

We need to talk   
C: Enhancement

New feature or request   
C: Feature

This is a new feature   
Compatibility

Compatibility with different browsers, readers and OS   
Dependency

Related to an external package that Plume uses   
Design

UI/UX related issues and PRs   
Documentation
   
Good first issue

Good for newcomers   
Help welcome

Extra attention is needed   
Mobile

Issues affecting only mobile UX   
Rendering

How elements're rendered out for the end user   
S: Blocked

Something else needs to be fixed first   
S: Duplicate

This issue or pull request already exists   
S: Incomplete

This PR is not complete yet   
S: Instance specific

Issues concern a limited number of instances   
S: Invalid

This doesn't seem right   
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)   
S: Ready for review

This PR is ready to be reviewed   
Suggestion

Proposed ideas worth considering   
S: Voted on Loomio

This is issue has been created after a vote on Loomio   
S: Wontfix

This will not be worked on
Sin etiquetas
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Fijar hito
Limpiar Milestone
No hay elementos
Sin Milestone
Asignados
Asignar usuarios
Limpiar asignados
No asignados
2 participantes
Notificaciones
Fecha de vencimiento
La fecha de vencimiento es inválida o está fuera de rango. Por favor utilice el formato 'aaaa-mm-dd'.

Sin fecha de vencimiento.

Dependencias

No se han establecido dependencias.

Referencia: Plume/Plume#658
Escribir Vista previa
Cargando…
Cancelar
Guardar
Aún no existe contenido.
Eliminar la rama con el nombre 'bugfix/651'

Eliminar una rama es permanente. NO PUEDE deshacerse. ¿Continuar?

No
Sí