Plume
/
Plume
8
16
Förgrening 22
Kod Ärenden 174 Pull-förfrågningar 8 Släpp 8 Wiki Aktiviteter

Etiketter Milstenar

order media so that latest added are top #660

Sammanfogat
Plume_migration_agent sammanfogade 2 incheckningar från feature/621 in i master 5 år sedan
Konversation 1 Incheckningar 2 Ändrade Filer 1
trinity-1686a kommenterad 5 år sedan
Ägare

partial fix for #621

partial fix for #621
codecov[bot] kommenterad 5 år sedan (Migrerad från github.com)

Codecov Report

Merging #660 into master will increase coverage by 0.04%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
+ Coverage   35.11%   35.15%   +0.04%     
==========================================
  Files          68       68              
  Lines        7943     7950       +7     
  Branches     1889     1889              
==========================================
+ Hits         2789     2795       +6     
- Misses       4374     4375       +1     
  Partials      780      780
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/660?src=pr&el=h1) Report > Merging [#660](https://codecov.io/gh/Plume-org/Plume/pull/660?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/935d331e971bc19019a4cbc271b3a59719b6be93?src=pr&el=desc) will **increase** coverage by `0.04%`. > The diff coverage is `85.71%`. ```diff @@ Coverage Diff @@ ## master #660 +/- ## ========================================== + Coverage 35.11% 35.15% +0.04% ========================================== Files 68 68 Lines 7943 7950 +7 Branches 1889 1889 ========================================== + Hits 2789 2795 +6 - Misses 4374 4375 +1 Partials 780 780 ```
igalic (Migrerad från github.com) granskad av 5 år sedan
igalic (Migrerad från github.com) lämnade en kommentar

❓

❓
plume-models/src/medias.rs
@ -66,0 +67,4 @@
medias::table
.filter(medias::owner_id.eq(owner))
.order(medias::id.desc())
.load::<Self>(conn)
igalic (Migrerad från github.com) kommenterad 5 år sedan

is this guaranteed to be such?
do we have a create date anywhere?

is this guaranteed to be such? do we have a create date anywhere?
trinity-1686a granskad av 5 år sedan
plume-models/src/medias.rs
@ -66,0 +67,4 @@
medias::table
.filter(medias::owner_id.eq(owner))
.order(medias::id.desc())
.load::<Self>(conn)
trinity-1686a kommenterad 5 år sedan
Skapare
Ägare

we don't have date, and the ids we use are monotonic counter, unless we overflow that 64b signed counter (not likely to happen)

we don't have date, and the ids we use are monotonic counter, unless we overflow that 64b signed counter (not likely to happen)
igalic (Migrerad från github.com) granskad av 5 år sedan
plume-models/src/medias.rs
@ -66,0 +67,4 @@
medias::table
.filter(medias::owner_id.eq(owner))
.order(medias::id.desc())
.load::<Self>(conn)
igalic (Migrerad från github.com) kommenterad 5 år sedan

i wonder if anyone expects that editing a media pushes it to the top again…

i wonder if anyone expects that editing a media pushes it to the top again…
elegaanz (Migrerad från github.com) granskad av 5 år sedan
plume-models/src/medias.rs
@ -66,0 +67,4 @@
medias::table
.filter(medias::owner_id.eq(owner))
.order(medias::id.desc())
.load::<Self>(conn)
elegaanz (Migrerad från github.com) kommenterad 5 år sedan

We can't edit media information for the moment, so…

We can't edit media information for the moment, so…
igalic (Migrerad från github.com) granskad av 5 år sedan
plume-models/src/medias.rs
@ -66,0 +67,4 @@
medias::table
.filter(medias::owner_id.eq(owner))
.order(medias::id.desc())
.load::<Self>(conn)
igalic (Migrerad från github.com) kommenterad 5 år sedan

well then… pushes [resolve] button

well then… *pushes [resolve] button*
elegaanz (Migrerad från github.com) granskad av 5 år sedan
elegaanz (Migrerad från github.com) lämnade en kommentar

Ideally, it should be done for the paginated version too, so that /media lists them in the correct order.

Ideally, it should be done for the paginated version too, so that `/media` lists them in the correct order.
igalic (Migrerad från github.com) godkände dessa ändringar 5 år sedan
igalic (Migrerad från github.com) lämnade en kommentar

👍

:+1:

Granskare

igalic
Pull-förfrågan har sammanfogats som d46af6fe5b.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b feature/621 master
git pull origin feature/621

Step 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff feature/621
git push origin master
Logga in för att delta i denna konversation.
Granskare
Begär granskning
Inga granskare
igalic
Etiketter
Tillämpa etiketter
Rensa etiketter   
A: API

Related to the REST API   
A: Backend

Code running on the server   
A: Federation

Stuff related to Federation   
A: Front-End

Related to the front-end   
A: I18N

Translations, and related code   
A: Meta

More about project management or code than the project itself   
A: Security
   
Build

The building, or installation process of Plume   
C: Bug

Something isn't working   
C: Discussion

We need to talk   
C: Enhancement

New feature or request   
C: Feature

This is a new feature   
Compatibility

Compatibility with different browsers, readers and OS   
Dependency

Related to an external package that Plume uses   
Design

UI/UX related issues and PRs   
Documentation
   
Good first issue

Good for newcomers   
Help welcome

Extra attention is needed   
Mobile

Issues affecting only mobile UX   
Rendering

How elements're rendered out for the end user   
S: Blocked

Something else needs to be fixed first   
S: Duplicate

This issue or pull request already exists   
S: Incomplete

This PR is not complete yet   
S: Instance specific

Issues concern a limited number of instances   
S: Invalid

This doesn't seem right   
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)   
S: Ready for review

This PR is ready to be reviewed   
Suggestion

Proposed ideas worth considering   
S: Voted on Loomio

This is issue has been created after a vote on Loomio   
S: Wontfix

This will not be worked on
Ingen Etikett
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milsten
Ange milstolpe
Rensa milstenar
Inga objekt
Ingen Milsten
Tilldelade
Tilldela användare
Rensa tilldelade
Ingen tilldelad
2 Deltagare
Notiser
Förfallodatum
Förfallodatumet är ogiltigt eller utanför gränserna. Använd formatet 'åååå-mm-dd'.

Inget förfallodatum satt.

Beroenden

No dependencies set.

Reference: Plume/Plume#660
Skriv Förhandsgranska
Laddar…
Avbryt
Spara
Det finns inget innehåll än.
Ta bort branch 'feature/621'

Borttagning utav en branch är permanent. Detta KAN INTE ångras. Vill du fortsätta?

Nej
Ja