Plume
/
Plume
8
16
複製 22
程式碼 問題管理 174 合併請求 8 版本發佈 8 Wiki Activity

標籤 里程碑

order media so that latest added are top #660

已合併
Plume_migration_agent 於 5 年之前 將 2 次代碼提交從 feature/621 合併至 master
對話內容 1 程式碼提交 2 Files Changed 1
trinity-1686a " 評論 5 年之前"
所有者

partial fix for #621

partial fix for #621
codecov[bot] " 評論 5 年之前" (Migrated from github.com)

Codecov Report

Merging #660 into master will increase coverage by 0.04%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
+ Coverage   35.11%   35.15%   +0.04%     
==========================================
  Files          68       68              
  Lines        7943     7950       +7     
  Branches     1889     1889              
==========================================
+ Hits         2789     2795       +6     
- Misses       4374     4375       +1     
  Partials      780      780
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/660?src=pr&el=h1) Report > Merging [#660](https://codecov.io/gh/Plume-org/Plume/pull/660?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/935d331e971bc19019a4cbc271b3a59719b6be93?src=pr&el=desc) will **increase** coverage by `0.04%`. > The diff coverage is `85.71%`. ```diff @@ Coverage Diff @@ ## master #660 +/- ## ========================================== + Coverage 35.11% 35.15% +0.04% ========================================== Files 68 68 Lines 7943 7950 +7 Branches 1889 1889 ========================================== + Hits 2789 2795 +6 - Misses 4374 4375 +1 Partials 780 780 ```
igalic (Migrated from github.com) reviewed 5 年之前
igalic (Migrated from github.com) left a comment

❓

❓
plume-models/src/medias.rs
@ -66,0 +67,4 @@
medias::table
.filter(medias::owner_id.eq(owner))
.order(medias::id.desc())
.load::<Self>(conn)
igalic (Migrated from github.com) " 評論 5 年之前"

is this guaranteed to be such?
do we have a create date anywhere?

is this guaranteed to be such? do we have a create date anywhere?
trinity-1686a reviewed 5 年之前
plume-models/src/medias.rs
@ -66,0 +67,4 @@
medias::table
.filter(medias::owner_id.eq(owner))
.order(medias::id.desc())
.load::<Self>(conn)
trinity-1686a " 評論 5 年之前"
發佈者
所有者

we don't have date, and the ids we use are monotonic counter, unless we overflow that 64b signed counter (not likely to happen)

we don't have date, and the ids we use are monotonic counter, unless we overflow that 64b signed counter (not likely to happen)
igalic (Migrated from github.com) reviewed 5 年之前
plume-models/src/medias.rs
@ -66,0 +67,4 @@
medias::table
.filter(medias::owner_id.eq(owner))
.order(medias::id.desc())
.load::<Self>(conn)
igalic (Migrated from github.com) " 評論 5 年之前"

i wonder if anyone expects that editing a media pushes it to the top again…

i wonder if anyone expects that editing a media pushes it to the top again…
elegaanz (Migrated from github.com) reviewed 5 年之前
plume-models/src/medias.rs
@ -66,0 +67,4 @@
medias::table
.filter(medias::owner_id.eq(owner))
.order(medias::id.desc())
.load::<Self>(conn)
elegaanz (Migrated from github.com) " 評論 5 年之前"

We can't edit media information for the moment, so…

We can't edit media information for the moment, so…
igalic (Migrated from github.com) reviewed 5 年之前
plume-models/src/medias.rs
@ -66,0 +67,4 @@
medias::table
.filter(medias::owner_id.eq(owner))
.order(medias::id.desc())
.load::<Self>(conn)
igalic (Migrated from github.com) " 評論 5 年之前"

well then… pushes [resolve] button

well then… *pushes [resolve] button*
elegaanz (Migrated from github.com) reviewed 5 年之前
elegaanz (Migrated from github.com) left a comment

Ideally, it should be done for the paginated version too, so that /media lists them in the correct order.

Ideally, it should be done for the paginated version too, so that `/media` lists them in the correct order.
igalic (Migrated from github.com) approved these changes 5 年之前
igalic (Migrated from github.com) left a comment

👍

:+1:

Reviewers

igalic
The pull request has been merged as d46af6fe5b.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b feature/621 master
git pull origin feature/621

Step 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff feature/621
git push origin master
登入 才能加入這對話。
Reviewers
Request review
No reviewers
igalic
標籤
Apply labels
清除已選取標籤   
A: API

Related to the REST API   
A: Backend

Code running on the server   
A: Federation

Stuff related to Federation   
A: Front-End

Related to the front-end   
A: I18N

Translations, and related code   
A: Meta

More about project management or code than the project itself   
A: Security
   
Build

The building, or installation process of Plume   
C: Bug

Something isn't working   
C: Discussion

We need to talk   
C: Enhancement

New feature or request   
C: Feature

This is a new feature   
Compatibility

Compatibility with different browsers, readers and OS   
Dependency

Related to an external package that Plume uses   
Design

UI/UX related issues and PRs   
Documentation
   
Good first issue

Good for newcomers   
Help welcome

Extra attention is needed   
Mobile

Issues affecting only mobile UX   
Rendering

How elements're rendered out for the end user   
S: Blocked

Something else needs to be fixed first   
S: Duplicate

This issue or pull request already exists   
S: Incomplete

This PR is not complete yet   
S: Instance specific

Issues concern a limited number of instances   
S: Invalid

This doesn't seem right   
S: Needs Voting/Discussion

Need to be discussed by the community (on Loomio)   
S: Ready for review

This PR is ready to be reviewed   
Suggestion

Proposed ideas worth considering   
S: Voted on Loomio

This is issue has been created after a vote on Loomio   
S: Wontfix

This will not be worked on
未選擇標籤
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
里程碑
Set milestone
清除已選取里程碑
No items
未選擇里程碑
Assignees
Assign users
Clear assignees
No Assignees
2 參與者
訊息
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#660
Write Preview
Loading…
取消
儲存
尚未有任何內容
Delete Branch 'feature/621'

Deleting a branch is permanent. It CANNOT be undone. Continue?

取消操作
確認操作