Plume
/
Plume
7
9
Fork 8
Code Issues 131 Pull Requests 13 Releases 4 Wiki Activity
Labels Milestones
New Pull Request

#677 Don't split sentences for translations

Merged
ryonakano merged 1 commits from no-split-sentences into master 1 year ago
Conversation 3 Commits 1 Files Changed 1
ryonakano commented 1 year ago (Migrated from github.com)

Fixes #675

Also I’ve included the trailing period to the translatable string.

Fixes #675 Also I've included the trailing period to the translatable string.
codecov[bot] commented 1 year ago (Migrated from github.com)
Owner

Codecov Report

Merging #677 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #677   +/-   ##
=======================================
  Coverage   39.83%   39.83%           
=======================================
  Files          72       72           
  Lines        9368     9368           
  Branches     2219     2219           
=======================================
  Hits         3732     3732           
  Misses       4580     4580           
  Partials     1056     1056
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/677?src=pr&el=h1) Report > Merging [#677](https://codecov.io/gh/Plume-org/Plume/pull/677?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/006b44f580083f501c677b511c7c4d84f9848adf?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #677 +/- ## ======================================= Coverage 39.83% 39.83% ======================================= Files 72 72 Lines 9368 9368 Branches 2219 2219 ======================================= Hits 3732 3732 Misses 4580 4580 Partials 1056 1056 ```
igalic (Migrated from github.com) approved these changes 1 year ago
igalic (Migrated from github.com) left a comment

👍

elegaanz commented 1 year ago (Migrated from github.com)
Owner

The string should be updated on Crowdin too, now!

The string should be updated on Crowdin too, now!
🎉 1
ryonakano commented 1 year ago (Migrated from github.com)
Owner

Screenshot from 2019-10-17 07-23-33

I should have escaped the href quotation marks 🙇‍♀️

![Screenshot from 2019-10-17 07-23-33](https://user-images.githubusercontent.com/26003928/66963614-0ed08380-f0af-11e9-8445-fd3656bead14.png) I should have escaped the href quotation marks :bowing_woman:

Reviewers

Plume_migration_agent approved these changes 1 year ago
The pull request has been merged as fc9e69d811.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
 Plume_migration_agent
Labels
Apply labels
Clear labels
A: API
Related to the REST API A: Backend
Code running on the server A: Federation
Stuff related to Federation A: Front-End
Related to the front-end A: I18N
Translations, and related code A: Meta
More about project management or code than the project itself A: Security Build
The building, or installation process of Plume C: Bug
Something isn't working C: Discussion
We need to talk C: Enhancement
New feature or request C: Feature
This is a new feature Compatibility
Compatibility with different browsers, readers and OS Dependency
Related to an external package that Plume uses Design
UI/UX related issues and PRs Documentation Good first issue
Good for newcomers Help welcome
Extra attention is needed Mobile
Issues affecting only mobile UX Rendering
How elements're rendered out for the end user S: Blocked
Something else needs to be fixed first S: Duplicate
This issue or pull request already exists S: Incomplete
This PR is not complete yet S: Instance specific
Issues concern a limited number of instances S: Invalid
This doesn't seem right S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio) S: Ready for review
This PR is ready to be reviewed Suggestion
Proposed ideas worth considering S: Voted on Loomio
This is issue has been created after a vote on Loomio S: Wontfix
This will not be worked on
No Label
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'no-split-sentences'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes