Don't split sentences for translations #677

Merged

ryonakano merged 1 commit from no-split-sentences into master

2019-10-16 18:07:59 +00:00

ryonakano commented

2019-10-15 12:11:02 +00:00

(Migrated from github.com)

Fixes #675

Also I've included the trailing period to the translatable string.

Fixes #675 Also I've included the trailing period to the translatable string.

codecov[bot] commented

2019-10-15 12:26:28 +00:00

(Migrated from github.com)

Codecov Report

Merging #677 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #677   +/-   ##
=======================================
  Coverage   39.83%   39.83%           
=======================================
  Files          72       72           
  Lines        9368     9368           
  Branches     2219     2219           
=======================================
  Hits         3732     3732           
  Misses       4580     4580           
  Partials     1056     1056

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/677?src=pr&el=h1) Report > Merging [#677](https://codecov.io/gh/Plume-org/Plume/pull/677?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/006b44f580083f501c677b511c7c4d84f9848adf?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #677 +/- ## ======================================= Coverage 39.83% 39.83% ======================================= Files 72 72 Lines 9368 9368 Branches 2219 2219 ======================================= Hits 3732 3732 Misses 4580 4580 Partials 1056 1056 ```

igalic (Migrated from github.com) approved these changes 2019-10-15 14:25:53 +00:00

igalic (Migrated from github.com) left a comment

👍

elegaanz commented

2019-10-16 18:11:26 +00:00

(Migrated from github.com)

The string should be updated on Crowdin too, now!

🎉 1

ryonakano commented

2019-10-16 22:25:13 +00:00

(Migrated from github.com)

I should have escaped the href quotation marks 🙇‍♀️

![Screenshot from 2019-10-17 07-23-33](https://user-images.githubusercontent.com/26003928/66963614-0ed08380-f0af-11e9-8445-fd3656bead14.png) I should have escaped the href quotation marks :bowing_woman:

No reviewers

igalic

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/Plume#677

No description provided.

Rows
Columns