Plume
/
Plume
7
9
Fork 8
Code Issues 131 Pull Requests 13 Releases 4 Wiki Activity
Labels Milestones
New Pull Request

#720 Fix RSS issues

Merged
papey merged 2 commits from fix/#673-date-id-rss into master 10 months ago
Conversation 3 Commits 2 Files Changed 1
papey commented 10 months ago (Migrated from github.com)

Here is a PR relative to issue #673.

At this state, the PR adds id and published field for each blog entry inside the RSS feed.

I’m not sure but it’s look like there is no method or field attached to post struct to get information about update metadata.

I can add this but I want to be sure that it’s in the scope of this PR.

Thanks for you’re reply.

Here is a PR relative to issue #673. At this state, the PR adds `id` and `published` field for each blog entry inside the RSS feed. I'm not sure but it's look like there is no method or field attached to `post` struct to get information about update metadata. I can add this but I want to be sure that it's in the scope of this PR. Thanks for you're reply.
👍 2
codecov[bot] commented 10 months ago (Migrated from github.com)
Owner

Codecov Report

Merging #720 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #720      +/-   ##
==========================================
- Coverage    39.3%   39.29%   -0.01%     
==========================================
  Files          72       72              
  Lines        9534     9536       +2     
  Branches     2275     2275              
==========================================
  Hits         3747     3747              
- Misses       4714     4716       +2     
  Partials     1073     1073
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/720?src=pr&el=h1) Report > Merging [#720](https://codecov.io/gh/Plume-org/Plume/pull/720?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/458baf5f78daec1b823e0bbd17eaa96c23ae92f8?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #720 +/- ## ========================================== - Coverage 39.3% 39.29% -0.01% ========================================== Files 72 72 Lines 9534 9536 +2 Branches 2275 2275 ========================================== Hits 3747 3747 - Misses 4714 4716 +2 Partials 1073 1073 ```
epsilon-phase commented 10 months ago (Migrated from github.com)
Owner

Our personal feeling is that you are correct in that adding an updated field is outside of the scope of the pull request.

We’ll review this after dinner, thanks for contributing :)

Our personal feeling is that you are correct in that adding an updated field is outside of the scope of the pull request. We'll review this after dinner, thanks for contributing :)
epsilon-phase (Migrated from github.com) approved these changes 10 months ago
papey commented 10 months ago (Migrated from github.com)
Owner

Here is the issue related to update field for blog entries https://github.com/Plume-org/Plume/issues/722

Here is the issue related to update field for blog entries https://github.com/Plume-org/Plume/issues/722
👍 1

Reviewers

Plume_migration_agent approved these changes 10 months ago
The pull request has been merged as 23049b638c.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
 Plume_migration_agent
Labels
Apply labels
Clear labels
A: API
Related to the REST API A: Backend
Code running on the server A: Federation
Stuff related to Federation A: Front-End
Related to the front-end A: I18N
Translations, and related code A: Meta
More about project management or code than the project itself A: Security Build
The building, or installation process of Plume C: Bug
Something isn't working C: Discussion
We need to talk C: Enhancement
New feature or request C: Feature
This is a new feature Compatibility
Compatibility with different browsers, readers and OS Dependency
Related to an external package that Plume uses Design
UI/UX related issues and PRs Documentation Good first issue
Good for newcomers Help welcome
Extra attention is needed Mobile
Issues affecting only mobile UX Rendering
How elements're rendered out for the end user S: Blocked
Something else needs to be fixed first S: Duplicate
This issue or pull request already exists S: Incomplete
This PR is not complete yet S: Instance specific
Issues concern a limited number of instances S: Invalid
This doesn't seem right S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio) S: Ready for review
This PR is ready to be reviewed Suggestion
Proposed ideas worth considering S: Voted on Loomio
This is issue has been created after a vote on Loomio S: Wontfix
This will not be worked on
No Label
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'fix/#673-date-id-rss'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes