Fix RSS issues #720

Fusionnée

papey a fusionné 2 révision(s) à partir de fix/#673-date-id-rss vers master

2020-01-14 00:30:33 +00:00

papey a commenté

2020-01-13 15:37:35 +00:00

. (Migré de github.com)

Here is a PR relative to issue #673.

At this state, the PR adds id and published field for each blog entry inside the RSS feed.

I'm not sure but it's look like there is no method or field attached to post struct to get information about update metadata.

I can add this but I want to be sure that it's in the scope of this PR.

Thanks for you're reply.

Here is a PR relative to issue #673. At this state, the PR adds `id` and `published` field for each blog entry inside the RSS feed. I'm not sure but it's look like there is no method or field attached to `post` struct to get information about update metadata. I can add this but I want to be sure that it's in the scope of this PR. Thanks for you're reply.

👍 2

codecov[bot] a commenté

2020-01-13 15:57:24 +00:00

. (Migré de github.com)

Codecov Report

Merging #720 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #720      +/-   ##
==========================================
- Coverage    39.3%   39.29%   -0.01%     
==========================================
  Files          72       72              
  Lines        9534     9536       +2     
  Branches     2275     2275              
==========================================
  Hits         3747     3747              
- Misses       4714     4716       +2     
  Partials     1073     1073

# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/720?src=pr&el=h1) Report > Merging [#720](https://codecov.io/gh/Plume-org/Plume/pull/720?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/458baf5f78daec1b823e0bbd17eaa96c23ae92f8?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `0%`. ```diff @@ Coverage Diff @@ ## master #720 +/- ## ========================================== - Coverage 39.3% 39.29% -0.01% ========================================== Files 72 72 Lines 9534 9536 +2 Branches 2275 2275 ========================================== Hits 3747 3747 - Misses 4714 4716 +2 Partials 1073 1073 ```

epsilon-phase a commenté

2020-01-13 23:55:50 +00:00

. (Migré de github.com)

Our personal feeling is that you are correct in that adding an updated field is outside of the scope of the pull request.

We'll review this after dinner, thanks for contributing :)

Our personal feeling is that you are correct in that adding an updated field is outside of the scope of the pull request. We'll review this after dinner, thanks for contributing :)

epsilon-phase (Migré de github.com) a approuvé ces modifications 2020-01-14 00:29:57 +00:00

papey a commenté

2020-01-14 10:04:33 +00:00

. (Migré de github.com)

Here is the issue related to update field for blog entries https://github.com/Plume-org/Plume/issues/722

👍 1