snap: Fix build process for Tier 2 platforms #732

Stängd
RAOF vill sammanfoga 1 incheckningar från s[2]s in i master
RAOF kommenterad 4 år sedan (Migrerad från github.com)

Unfortunately this only actually fixes the build for arm64;
it seems that we hit various bugs in Rust on ppc64 and armhf.

Unfortunately this only actually *fixes* the build for arm64; it seems that we hit various bugs in Rust on ppc64 and armhf.
igalic (Migrerad från github.com) granskad av 4 år sedan
@ -37,3 +35,4 @@
- lld-9
override-build: |
snapcraftctl set-version $(git describe --tags)
export PATH=$PATH:$HOME/.cargo/bin
igalic (Migrerad från github.com) kommenterad 4 år sedan

maybe we should get rid of these dependencies again, so we can have broader platform support

maybe we should get rid of these dependencies again, so we can have broader platform support
codecov[bot] kommenterad 4 år sedan (Migrerad från github.com)

Codecov Report

Merging #732 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #732      +/-   ##
==========================================
+ Coverage   39.16%   39.17%   +0.01%     
==========================================
  Files          73       73              
  Lines        9653     9653              
  Branches     2183     2183              
==========================================
+ Hits         3781     3782       +1     
  Misses       4819     4819              
+ Partials     1053     1052       -1
# [Codecov](https://codecov.io/gh/Plume-org/Plume/pull/732?src=pr&el=h1) Report > Merging [#732](https://codecov.io/gh/Plume-org/Plume/pull/732?src=pr&el=desc) into [master](https://codecov.io/gh/Plume-org/Plume/commit/2a58835f9291729076dc06febf050e47e08d73c1?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #732 +/- ## ========================================== + Coverage 39.16% 39.17% +0.01% ========================================== Files 73 73 Lines 9653 9653 Branches 2183 2183 ========================================== + Hits 3781 3782 +1 Misses 4819 4819 + Partials 1053 1052 -1 ```
RAOF (Migrerad från github.com) granskad av 4 år sedan
@ -37,3 +35,4 @@
- lld-9
override-build: |
snapcraftctl set-version $(git describe --tags)
export PATH=$PATH:$HOME/.cargo/bin
RAOF (Migrerad från github.com) kommenterad 4 år sedan

These actuality exist everywhere (on Linux); I just dropped the (attempted) “only install lld on tier 2 platforms” logic.

With lld-9 the build failures on ppc64 and armhf are elsewhere.

These actuality exist everywhere (on Linux); I just dropped the (attempted) “*only* install lld on tier 2 platforms” logic. With lld-9 the build failures on ppc64 and armhf are elsewhere.
KitaitiMakoto closed this pull request 3 år sedan
Denna pull-förfrågan kan inte öppnas igen eftersom branchen tagits bort.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b RAOF/fix-arm64-build master
git pull origin RAOF/fix-arm64-build

Step 2:

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff RAOF/fix-arm64-build
git push origin master
Logga in för att delta i denna konversation.
Inga granskare
Ingen Milsten
Ingen tilldelad
1 Deltagare
Notiser
Förfallodatum
Förfallodatumet är ogiltigt eller utanför gränserna. Använd formatet 'åååå-mm-dd'.

Inget förfallodatum satt.

Beroenden

No dependencies set.

Reference: Plume/Plume#732
Laddar…
Det finns inget innehåll än.