cargo release helper
#790
Suljettu
igalic haluaa yhdistää 50 committia lähteestä igalic/fix/cargo-release-helper
kohteeseen master
vedä kohteesta: igalic/fix/cargo-release-helper
merge into: Plume:master
Plume:paginate-search-init
Plume:main
Plume:s3
Plume:fix-delete-user
Plume:timeline-cli
Plume:blog-title
Plume:signature
Plume:remove-dup-images
Plume:ldap-non-anon
Plume:drone-ci
Plume:DearRude/force-lang
Plume:igalic/go/async-all-mut
Plume:go/async
Plume:floreal/translations-update
Plume:missing-docs
Plume:RAOF/fix-arm64-build
Plume:epsilon-phase/authorized-fetch
Plume:upgrade
Plume:improve-the-editor-once-again
Plume:igalic/feat/custom-fairing-domains
Plume:feature/ldap
Plume:test/dotenv_error
Plume:fix-mobile-margin
Reviewers
Request review
No reviewers
Tunnisteet
Tyhjennä tunnisteet
Related to the REST API
Code running on the server
Stuff related to Federation
Related to the front-end
Translations, and related code
More about project management or code than the project itself
The building, or installation process of Plume
Something isn't working
We need to talk
New feature or request
This is a new feature
Compatibility with different browsers, readers and OS
Related to an external package that Plume uses
UI/UX related issues and PRs
Good for newcomers
Extra attention is needed
Issues affecting only mobile UX
How elements're rendered out for the end user
Something else needs to be fixed first
This issue or pull request already exists
This PR is not complete yet
Issues concern a limited number of instances
This doesn't seem right
Need to be discussed by the community (on Loomio)
This PR is ready to be reviewed
Proposed ideas worth considering
This is issue has been created after a vote on Loomio
This will not be worked on
Aseta tunniste
A: API
Related to the REST API
A: Backend
Code running on the server
A: Federation
Stuff related to Federation
A: Front-End
Related to the front-end
A: I18N
Translations, and related code
A: Meta
More about project management or code than the project itself
A: Security
Build
The building, or installation process of Plume
C: Bug
Something isn't working
C: Discussion
We need to talk
C: Enhancement
New feature or request
C: Feature
This is a new feature
Compatibility
Compatibility with different browsers, readers and OS
Dependency
Related to an external package that Plume uses
Design
UI/UX related issues and PRs
Documentation
Good first issue
Good for newcomers
Help welcome
Extra attention is needed
Mobile
Issues affecting only mobile UX
Rendering
How elements're rendered out for the end user
S: Blocked
Something else needs to be fixed first
S: Duplicate
This issue or pull request already exists
S: Incomplete
This PR is not complete yet
S: Instance specific
Issues concern a limited number of instances
S: Invalid
This doesn't seem right
S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio)
S: Ready for review
This PR is ready to be reviewed
Suggestion
Proposed ideas worth considering
S: Voted on Loomio
This is issue has been created after a vote on Loomio
S: Wontfix
This will not be worked on
Ei tunnistetta
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Merkkipaalu
Aseta merkkipaalu
Tyhjennä merkkipaalu
Ei kohteita
Ei merkkipaalua
Käsittelijä
Osoita käyttäjille
Tyhjennä käsittelijä
Ei käsittelijää
2 osallistujaa
Ilmoitukset
Määräpäivä
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.
Määräpäivää ei asetettu.
Riippuvuudet
Riippuvuuksia ei asetettu.
Reference: Plume/Plume#790
Viittaa uudesa ongelmassa
Sisältöä ei vielä ole.
Poista haara 'igalic/fix/cargo-release-helper'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Ei
Kyllä
how to use?
Codecov Report
uh… will we need to add it as development dependency?
Shouldn't the repo URL be changed here?
Also, maybe we could unify the headers in the changelog to follow what https://keepachangelog.com/ recommends, to keep it coherent.
And for the development dependency, I don't think so. It should be documented here that people who want to publish a new release should use this tool tho.
how?
To something like
https://github.com/Plume-org/Plume/compare/{{tag_name}}...HEAD
, so that the changelog links to our commit history.Also, is there a
<!-- next-url -->
somewhere in the changelog you added? I can't find it.n. b. : i've back-filled the changelog by copy-pasting the text from our github releases page
for the future of the changelog, i absolutely agree
I know you copied what is on GitHub, but maybe we could change this text? Would it be a problem to have texts that are a bit different on Github and in the changelog? I would prefer to have the whole changelog have the same format (but that's arguable).
Also, could it be possible to add
pre-release-hook
to runcrowdin pull
(I don't remember the exact arguments, but basically : the command to pull the latest version of translations)? Or do you think it should be done manually before runningcargo release
?the only problem was time and energy
y'all have access to write to this PR, so, please, by all means, help me!!
that's a very good idea!
how do i make it work?
I don't remember how the Crowdin CLI works, I'll check that and edit the PR. I'll also edit the changelog.
So the translations should be pulled now, if you have a
CROWDIN_API_KEY
in your env. We should remember to document how to get one before making a release.let's create a doc issue right now, and link it here
https://github.com/Plume-org/docs/issues/88
what about docker?
I think the release should be automatic, I'll check.
It is not, I'll a hook.
The thing is, the docker tag needs to be pushed after the git tag, and there is no
post-release-hook
in cargo release, apparently.So maybe we can document that this has to be done manually, and do it by hand for the moment?
or we could add docker tag to the CI build process, only on tag
yunohost relies on docker, right?
and it's one of the platforms that we recommend, thru our installation guide
It doesn't, it uses Bash scripts. I'm not sure if it is better tho… 😅
i didn't add it to our current changelog
We can tag to Docker images automatically by setting automate build properly.
A test succeeded:
(v0.5.1-test2 was pushed by plumeorg)
Remaining issue is how do we notify YunoHost maintainer. It is not an issue of cargo helper (this pul request's theme) but an issue of CI. So this pull request is ready to be merged.
Closed as #835
Reviewers
Vaihe 1:
From your project repository, check out a new branch and test the changes.Vaihe 2:
Merge the changes and update on Forgejo.