extract DbConn from PlumeRocket #805
No reviewers
Labels
No labels
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: Plume/Plume#805
Loading…
Reference in a new issue
No description provided.
Delete branch "igalic/Plume:refactor/extract-dbconn"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
in the following Pull Request, we'lle extract
DbConn
fromPlumeRocket
, as suggested in #797#[database]
to implement ourDbConn
#[database]
's connection setup, retaining our owninit_pool()
andConnectionCustomization
!DbConn
in asref
instead ofCopy
ing it around.@ -41,3 +12,1 @@
&self.0
}
}
#[database("plume")]
I think you'll have to edit
plume-models/src/config.rs
so that Rocket knows the URL of this "plume" database.yesno… we want to retain our
ConnectionCustomization
, so we're keeping our owninit_pool()
.9c7af7dcd4
to3d8785e97b
add rocket_contrib as dependencyto extract DbConn from PlumeRocketThis will help with the
async
migration, as we're currently passing all of PlumeRocket around asref
, which means that it ends up sitting somewhere in a function, until it's.await
ed.This can create lead us into a big mess, which may be impossible to untangle, so this should help not running into that to begin with.
closing in favour of #813
Pull request closed