Plume
/
Plume
7
9
Fork 8
Code Issues 131 Pull-Requests 13 Releases 4 Wiki Aktivität
Label Meilensteine
Neuer Pull-Request

#805 extract DbConn from PlumeRocket

Geschlossen
igalic möchte 2 Commits von igalic/Plume:refactor/extract-dbconn nach main zusammenführen
Diskussion 2 Commits 2 Geänderte Dateien 6
igalic hat vor 4 Monaten kommentiert

in the following Pull Request, we’lle extract DbConn from PlumeRocket, as suggested in #797

  • use rocket_contrib’s #[database] to implement our DbConn
  • we do not use #[database]'s connection setup, retaining our own init_pool() and ConnectionCustomization!
  • pass DbConn in as ref instead of Copying it around.
in the following Pull Request, we'lle extract `DbConn` from `PlumeRocket`, as suggested in https://git.joinplu.me/Plume/Plume/issues/797 - use rocket_contrib's `#[database]` to implement our `DbConn` - we do *not* use `#[database]`'s connection setup, retaining our own `init_pool()` and `ConnectionCustomization`! - pass `DbConn` in as `ref` instead of `Copy`ing it around.
👍 1
kiwii hat vor 4 Monaten überprüft
plume-models/src/db_conn.rs
@@ -41,3 +12,1 @@
&self.0
}
}
#[database("plume")]
kiwii hat vor 4 Monaten kommentiert

I think you’ll have to edit plume-models/src/config.rs so that Rocket knows the URL of this “plume” database.

I think you'll have to edit `plume-models/src/config.rs` so that Rocket knows the URL of this "plume" database.
igalic hat vor 4 Monaten kommentiert

yesno… we want to retain our ConnectionCustomization, so we’re keeping our own init_pool().

yesno… we want to retain our `ConnectionCustomization`, so we're keeping our own `init_pool()`.
igalic markierte diese Unterhaltung als gelöst
igalic hat den Titel von add rocket_contrib as dependency zu extract DbConn from PlumeRocket vor 4 Monaten geändert
igalic hat vor 4 Monaten kommentiert
Besitzer
  • pass DbConn in as ref instead of Copying it around.

This will help with the async migration, as we’re currently passing all of PlumeRocket around as ref, which means that it ends up sitting somewhere in a function, until it’s .awaited.

This can create lead us into a big mess, which may be impossible to untangle, so this should help not running into that to begin with.

> - pass `DbConn` in as `ref` instead of `Copy`ing it around. This will help with the `async` migration, as we're currently passing all of PlumeRocket around as `ref`, which means that it ends up sitting *somewhere* in a function, until it's `.await`ed. This can create lead us into a big mess, which may be impossible to untangle, so this should help *not* running into that to begin with.
igalic hat vor 4 Monaten kommentiert
Besitzer

closing in favour of #813

closing in favour of #813
igalic hat diesen Pull-Request vor 4 Monaten geschlossen
Bitte diesen Pull-Request wieder öffnen, um die Merge-Operation auszuführen.
Anmelden, um an der Diskussion teilzunehmen.
Reviewer
Überprüfung anfordern
Keine Reviewer
Label
Label anwenden
Label entfernen
A: API
Related to the REST API A: Backend
Code running on the server A: Federation
Stuff related to Federation A: Front-End
Related to the front-end A: I18N
Translations, and related code A: Meta
More about project management or code than the project itself A: Security Build
The building, or installation process of Plume C: Bug
Something isn't working C: Discussion
We need to talk C: Enhancement
New feature or request C: Feature
This is a new feature Compatibility
Compatibility with different browsers, readers and OS Dependency
Related to an external package that Plume uses Design
UI/UX related issues and PRs Documentation Good first issue
Good for newcomers Help welcome
Extra attention is needed Mobile
Issues affecting only mobile UX Rendering
How elements're rendered out for the end user S: Blocked
Something else needs to be fixed first S: Duplicate
This issue or pull request already exists S: Incomplete
This PR is not complete yet S: Instance specific
Issues concern a limited number of instances S: Invalid
This doesn't seem right S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio) S: Ready for review
This PR is ready to be reviewed Suggestion
Proposed ideas worth considering S: Voted on Loomio
This is issue has been created after a vote on Loomio S: Wontfix
This will not be worked on
Kein Label
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Meilenstein
Meilenstein setzen
Meilenstein entfernen
Keine Einträge
Kein Meilenstein
Zuständig
Benutzer zuweisen
Zuständige entfernen
Niemand zuständig
2 Beteiligte
Nachrichten
Fällig am

Kein Fälligkeitsdatum gesetzt.

Abhängigkeiten

Dieser Pull-Request hat momentan keine Abhängigkeiten.

Verfassen Vorschau
Laden…
Abbrechen
Speichern
Hier gibt es bis jetzt noch keinen Inhalt.
Branch „igalic/Plume:refactor/extract-dbconn“ löschen

Das Löschen eines Branches ist permanent. Es KANN NICHT rückgängig gemacht werden. Fortfahren?

Abbrechen
Ja