extract DbConn from PlumeRocket #805

igalic · 2020-07-19T11:37:20Z

igalic comentado

2020-07-19 11:37:20 +00:00

Propietario

in the following Pull Request, we'lle extract DbConn from PlumeRocket, as suggested in #797

use rocket_contrib's #[database] to implement our DbConn
we do not use #[database]'s connection setup, retaining our own init_pool() and ConnectionCustomization!
pass DbConn in as ref instead of Copying it around.

in the following Pull Request, we'lle extract `DbConn` from `PlumeRocket`, as suggested in https://git.joinplu.me/Plume/Plume/issues/797 - use rocket_contrib's `#[database]` to implement our `DbConn` - we do *not* use `#[database]`'s connection setup, retaining our own `init_pool()` and `ConnectionCustomization`! - pass `DbConn` in as `ref` instead of `Copy`ing it around.

👍 1

kiwii revisó 2020-07-19 12:08:57 +00:00

plume-models/src/db_conn.rs Obsoleto

					
				@ -41,3 +12,1 @@

				        &self.0

				    }

				}

				#[database("plume")]

kiwii comentado

2020-07-19 12:08:57 +00:00

Propietario

I think you'll have to edit plume-models/src/config.rs so that Rocket knows the URL of this "plume" database.

I think you'll have to edit `plume-models/src/config.rs` so that Rocket knows the URL of this "plume" database.

igalic comentado

2020-07-20 12:01:43 +00:00

Autoría

Propietario

yesno… we want to retain our ConnectionCustomization, so we're keeping our own init_pool().

yesno… we want to retain our `ConnectionCustomization`, so we're keeping our own `init_pool()`.

igalic ha marcado esta conversación como resuelta

igalic hizo push forzado refactor/extract-dbconn de 9c7af7dcd4 a 3d8785e97b

2020-07-19 17:02:38 +00:00

Comparar

igalic cambió el título de ~~add rocket_contrib as dependency~~ a extract DbConn from PlumeRocket

2020-07-20 11:56:24 +00:00

igalic comentado

2020-07-20 12:00:01 +00:00

Autoría

Propietario

pass DbConn in as ref instead of Copying it around.

This will help with the async migration, as we're currently passing all of PlumeRocket around as ref, which means that it ends up sitting somewhere in a function, until it's .awaited.

This can create lead us into a big mess, which may be impossible to untangle, so this should help not running into that to begin with.

> - pass `DbConn` in as `ref` instead of `Copy`ing it around. This will help with the `async` migration, as we're currently passing all of PlumeRocket around as `ref`, which means that it ends up sitting *somewhere* in a function, until it's `.await`ed. This can create lead us into a big mess, which may be impossible to untangle, so this should help *not* running into that to begin with.

igalic añadió 1 commit 2020-07-20 14:12:51 +00:00

remove DbConn from PlumeRocket e19069f750

this means compilation fails, and for the next while, we'll try to make
it compile again ;)

igalic referenció este pull request

2020-07-26 19:36:17 +00:00

WIP: Extract DbConn, Searcher & Worker into Riker Actors #813

igalic comentado

2020-07-26 19:37:55 +00:00

Autoría

Propietario

closing in favour of #813

igalic cerró este pull request

2020-07-26 19:37:56 +00:00

KitaitiMakoto referenció este pull request

2021-01-30 08:00:25 +00:00

Reduce database connnections required for routes::users::details #888

KitaitiMakoto referenció este pull request

2021-01-30 13:32:32 +00:00

Close #888 Extract DbConn from PlumeRocket #889

Se cerró la solicitud de incorporación

Vuelva a abrir este Pull Request para realizar una fusión.

Inicie sesión para unirse a esta conversación.

No hay revisores

Sin hito

Ningún proyecto

Sin encargados

2 participantes

Notificaciones

Fecha límite

La fecha límite es inválida o está fuera de rango. Por favor utiliza el formato "aaaa-mm-dd".

Fecha límite no definida.

Dependencias

No se han establecido dependencias.

Referencia: Plume/Plume#805

Filas
Columnas