#805 extract DbConn from PlumeRocket

Fermé
igalic veut fusionner 2 révision(s) depuis igalic/Plume:refactor/extract-dbconn vers main
igalic a commenté il y a 4 mois

in the following Pull Request, we’lle extract DbConn from PlumeRocket, as suggested in #797

  • use rocket_contrib’s #[database] to implement our DbConn
  • we do not use #[database]'s connection setup, retaining our own init_pool() and ConnectionCustomization!
  • pass DbConn in as ref instead of Copying it around.
in the following Pull Request, we'lle extract `DbConn` from `PlumeRocket`, as suggested in https://git.joinplu.me/Plume/Plume/issues/797 - use rocket_contrib's `#[database]` to implement our `DbConn` - we do *not* use `#[database]`'s connection setup, retaining our own `init_pool()` and `ConnectionCustomization`! - pass `DbConn` in as `ref` instead of `Copy`ing it around.
kiwii révisé il y a 4 mois
plume-models/src/db_conn.rs
@@ -41,3 +12,1 @@
&self.0
}
}
#[database("plume")]
kiwii a commenté il y a 4 mois

I think you’ll have to edit plume-models/src/config.rs so that Rocket knows the URL of this “plume” database.

I think you'll have to edit `plume-models/src/config.rs` so that Rocket knows the URL of this "plume" database.
igalic a commenté il y a 4 mois

yesno… we want to retain our ConnectionCustomization, so we’re keeping our own init_pool().

yesno… we want to retain our `ConnectionCustomization`, so we're keeping our own `init_pool()`.
igalic marquer cette conversation comme résolue
igalic a modifié le titre de add rocket_contrib as dependency à extract DbConn from PlumeRocket il y a 4 mois
igalic a commenté il y a 4 mois
Propriétaire
  • pass DbConn in as ref instead of Copying it around.

This will help with the async migration, as we’re currently passing all of PlumeRocket around as ref, which means that it ends up sitting somewhere in a function, until it’s .awaited.

This can create lead us into a big mess, which may be impossible to untangle, so this should help not running into that to begin with.

> - pass `DbConn` in as `ref` instead of `Copy`ing it around. This will help with the `async` migration, as we're currently passing all of PlumeRocket around as `ref`, which means that it ends up sitting *somewhere* in a function, until it's `.await`ed. This can create lead us into a big mess, which may be impossible to untangle, so this should help *not* running into that to begin with.
igalic a commenté il y a 4 mois
Propriétaire

closing in favour of #813

closing in favour of #813
igalic a fermé cette pull request il y a 4 mois
Veuillez rouvrir cette demande d'ajout pour effectuer l'opération de fusion.
Connectez-vous pour rejoindre cette conversation.
Pas de relecteur
Aucun jalon
Pas d'assignataires
2 participants
Notifications
Échéance

Aucune échéance n'a été définie.

Dépendances

La demande de fusion n'a actuellement pas de dépendance.

Chargement…
Il n'existe pas encore de contenu.