extract DbConn from PlumeRocket #805
Sans évaluateur
Labels
Sans labels
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Sans jalon
Sans projet
Sans assignation
2 participants
Notifications
Échéance
Aucune échéance n'a été définie.
Dépendances
Aucune dépendance définie.
Référence : Plume/Plume#805
Chargement…
Ajouter une table
Référencer dans un nouveau ticket
Sans contenu.
Supprimer la branche "igalic/Plume:refactor/extract-dbconn"
La suppression d’une branche est permanente. Bien qu’une branche supprimée puisse temporairement subsister, elle NE PEUT PAS être facilement restaurée. Continuer ?
in the following Pull Request, we'lle extract
DbConn
fromPlumeRocket
, as suggested in #797#[database]
to implement ourDbConn
#[database]
's connection setup, retaining our owninit_pool()
andConnectionCustomization
!DbConn
in asref
instead ofCopy
ing it around.@ -41,3 +12,1 @@
&self.0
}
}
#[database("plume")]
I think you'll have to edit
plume-models/src/config.rs
so that Rocket knows the URL of this "plume" database.yesno… we want to retain our
ConnectionCustomization
, so we're keeping our owninit_pool()
.9c7af7dcd4
à3d8785e97b
add rocket_contrib as dependencypar extract DbConn from PlumeRocketThis will help with the
async
migration, as we're currently passing all of PlumeRocket around asref
, which means that it ends up sitting somewhere in a function, until it's.await
ed.This can create lead us into a big mess, which may be impossible to untangle, so this should help not running into that to begin with.
closing in favour of #813
Demande d’ajout fermée