extract DbConn from PlumeRocket #805

igalic · 2020-07-19T11:37:20Z

igalic がコメント

2020-07-19 11:37:20 +00:00

オーナー

in the following Pull Request, we'lle extract DbConn from PlumeRocket, as suggested in #797

use rocket_contrib's #[database] to implement our DbConn
we do not use #[database]'s connection setup, retaining our own init_pool() and ConnectionCustomization!
pass DbConn in as ref instead of Copying it around.

in the following Pull Request, we'lle extract `DbConn` from `PlumeRocket`, as suggested in https://git.joinplu.me/Plume/Plume/issues/797 - use rocket_contrib's `#[database]` to implement our `DbConn` - we do *not* use `#[database]`'s connection setup, retaining our own `init_pool()` and `ConnectionCustomization`! - pass `DbConn` in as `ref` instead of `Copy`ing it around.

👍 1

kiwii がレビュー 2020-07-19 12:08:57 +00:00

plume-models/src/db_conn.rs 古い内容

					
				@ -41,3 +12,1 @@

				        &self.0

				    }

				}

				#[database("plume")]

kiwii がコメント

2020-07-19 12:08:57 +00:00

オーナー

I think you'll have to edit plume-models/src/config.rs so that Rocket knows the URL of this "plume" database.

I think you'll have to edit `plume-models/src/config.rs` so that Rocket knows the URL of this "plume" database.

igalic がコメント

2020-07-20 12:01:43 +00:00

作成者

オーナー

yesno… we want to retain our ConnectionCustomization, so we're keeping our own init_pool().

yesno… we want to retain our `ConnectionCustomization`, so we're keeping our own `init_pool()`.

igalic がこの会話を解決済みにしました

igalic が refactor/extract-dbconn を強制プッシュ ( 9c7af7dcd4 から 3d8785e97b へ ) 2020-07-19 17:02:38 +00:00 比較

igalic がタイトルを ~~add rocket_contrib as dependency~~ から extract DbConn from PlumeRocket に変更 2020-07-20 11:56:24 +00:00

igalic がコメント

2020-07-20 12:00:01 +00:00

作成者

オーナー

pass DbConn in as ref instead of Copying it around.

This will help with the async migration, as we're currently passing all of PlumeRocket around as ref, which means that it ends up sitting somewhere in a function, until it's .awaited.

This can create lead us into a big mess, which may be impossible to untangle, so this should help not running into that to begin with.

> - pass `DbConn` in as `ref` instead of `Copy`ing it around. This will help with the `async` migration, as we're currently passing all of PlumeRocket around as `ref`, which means that it ends up sitting *somewhere* in a function, until it's `.await`ed. This can create lead us into a big mess, which may be impossible to untangle, so this should help *not* running into that to begin with.

igalic が 1 コミット追加 2020-07-20 14:12:51 +00:00

remove DbConn from PlumeRocket e19069f750

this means compilation fails, and for the next while, we'll try to make
it compile again ;)

igalic が、このプルリクエストを参照

2020-07-26 19:36:17 +00:00

WIP: Extract DbConn, Searcher & Worker into Riker Actors #813

igalic がコメント

2020-07-26 19:37:55 +00:00

作成者

オーナー

closing in favour of #813

igalic がプルリクエストをクローズ

2020-07-26 19:37:56 +00:00

KitaitiMakoto が、このプルリクエストを参照

2021-01-30 08:00:25 +00:00

Reduce database connnections required for routes::users::details #888

KitaitiMakoto が、このプルリクエストを参照

2021-01-30 13:32:32 +00:00

Close #888 Extract DbConn from PlumeRocket #889

プルリクエストはクローズされました

このプルリクエストをマージする場合は再オープンしてください。

サインインしてこの会話に参加。

レビューアなし

マイルストーンなし

プロジェクトなし

担当者なし

2 人の参加者

通知

期日

期日が正しくないか範囲を超えています。 "yyyy-mm-dd" の形式で入力してください。

期日は未設定です。

依存関係

依存関係が設定されていません。

リファレンス: Plume/Plume#805

Rows
Columns