extract DbConn from PlumeRocket #805

igalic · 2020-07-19T11:37:20Z

igalic 코멘트함,

2020-07-19 11:37:20 +00:00

소유자

in the following Pull Request, we'lle extract DbConn from PlumeRocket, as suggested in #797

use rocket_contrib's #[database] to implement our DbConn
we do not use #[database]'s connection setup, retaining our own init_pool() and ConnectionCustomization!
pass DbConn in as ref instead of Copying it around.

in the following Pull Request, we'lle extract `DbConn` from `PlumeRocket`, as suggested in https://git.joinplu.me/Plume/Plume/issues/797 - use rocket_contrib's `#[database]` to implement our `DbConn` - we do *not* use `#[database]`'s connection setup, retaining our own `init_pool()` and `ConnectionCustomization`! - pass `DbConn` in as `ref` instead of `Copy`ing it around.

👍 1

kiwii 검토됨 2020-07-19 12:08:57 +00:00

plume-models/src/db_conn.rs Outdated

					
				@ -41,3 +12,1 @@

				        &self.0

				    }

				}

				#[database("plume")]

kiwii 코멘트함,

2020-07-19 12:08:57 +00:00

소유자

I think you'll have to edit plume-models/src/config.rs so that Rocket knows the URL of this "plume" database.

I think you'll have to edit `plume-models/src/config.rs` so that Rocket knows the URL of this "plume" database.

igalic 코멘트함,

2020-07-20 12:01:43 +00:00

작성자

소유자

yesno… we want to retain our ConnectionCustomization, so we're keeping our own init_pool().

yesno… we want to retain our `ConnectionCustomization`, so we're keeping our own `init_pool()`.

igalic marked this conversation as resolved

igalic force-pushed refactor/extract-dbconn from 9c7af7dcd4 to 3d8785e97b

2020-07-19 17:02:38 +00:00

Compare

igalic changed title from ~~add rocket_contrib as dependency~~ to extract DbConn from PlumeRocket

2020-07-20 11:56:24 +00:00

igalic 코멘트함,

2020-07-20 12:00:01 +00:00

작성자

소유자

pass DbConn in as ref instead of Copying it around.

This will help with the async migration, as we're currently passing all of PlumeRocket around as ref, which means that it ends up sitting somewhere in a function, until it's .awaited.

This can create lead us into a big mess, which may be impossible to untangle, so this should help not running into that to begin with.

> - pass `DbConn` in as `ref` instead of `Copy`ing it around. This will help with the `async` migration, as we're currently passing all of PlumeRocket around as `ref`, which means that it ends up sitting *somewhere* in a function, until it's `.await`ed. This can create lead us into a big mess, which may be impossible to untangle, so this should help *not* running into that to begin with.

igalic added 1 commit 2020-07-20 14:12:51 +00:00

remove DbConn from PlumeRocket e19069f750

this means compilation fails, and for the next while, we'll try to make
it compile again ;)

igalic referenced this pull request

2020-07-26 19:36:17 +00:00

WIP: Extract DbConn, Searcher & Worker into Riker Actors #813

igalic 코멘트함,

2020-07-26 19:37:55 +00:00

작성자

소유자

closing in favour of #813

igalic closed this pull request

2020-07-26 19:37:56 +00:00

KitaitiMakoto referenced this pull request

2021-01-30 08:00:25 +00:00

Reduce database connnections required for routes::users::details #888

KitaitiMakoto referenced this pull request

2021-01-30 13:32:32 +00:00

Close #888 Extract DbConn from PlumeRocket #889

Pull request closed

병합을 수행하려면 이 풀 리퀘스트를 다시 열어주세요.

로그인하여 이 대화에 참여하세요.

No reviewers

마일스톤 없음

프로젝트 없음

담당자 없음

참가자 2명

알림

마감일

기한이 올바르지 않거나 범위를 벗어났습니다. "yyyy-mm-dd"형식을 사용해주십시오.

마감일이 설정되지 않았습니다.

전제조건

전제조건이 설정되지 않았습니다.

Reference: Plume/Plume#805

행
열