Nieuwe Pull aanvraag

#805 extract DbConn from PlumeRocket

Closed

igalic wil 2 commits van igalic/Plume:refactor/extract-dbconn samenvoegen met main

in the following Pull Request, we’lle extract DbConn from PlumeRocket, as suggested in #797

use rocket_contrib’s #[database] to implement our DbConn
we do not use #[database]'s connection setup, retaining our own init_pool() and ConnectionCustomization!
pass DbConn in as ref instead of Copying it around.

👍 1

kiwii beoordeeld 11 maanden geleden

plume-models/src/db_conn.rs

igalic titel aangepast van ~~add rocket_contrib as dependency~~ naar extract DbConn from PlumeRocket 11 maanden geleden

pass DbConn in as ref instead of Copying it around.

This will help with the async migration, as we’re currently passing all of PlumeRocket around as ref, which means that it ends up sitting somewhere in a function, until it’s .awaited.

This can create lead us into a big mess, which may be impossible to untangle, so this should help not running into that to begin with.