#805 extract DbConn from PlumeRocket

Fechado
igalic quer aplicar o merge de 2 commits de igalic/Plume:refactor/extract-dbconn em main

in the following Pull Request, we’lle extract DbConn from PlumeRocket, as suggested in #797

  • use rocket_contrib’s #[database] to implement our DbConn
  • we do not use #[database]'s connection setup, retaining our own init_pool() and ConnectionCustomization!
  • pass DbConn in as ref instead of Copying it around.
in the following Pull Request, we'lle extract `DbConn` from `PlumeRocket`, as suggested in https://git.joinplu.me/Plume/Plume/issues/797 - use rocket_contrib's `#[database]` to implement our `DbConn` - we do *not* use `#[database]`'s connection setup, retaining our own `init_pool()` and `ConnectionCustomization`! - pass `DbConn` in as `ref` instead of `Copy`ing it around.
kiwii revisou 4 meses atrás
plume-models/src/db_conn.rs
@@ -41,3 +12,1 @@
&self.0
}
}
#[database("plume")]
kiwii comentou 4 meses atrás

I think you’ll have to edit plume-models/src/config.rs so that Rocket knows the URL of this “plume” database.

I think you'll have to edit `plume-models/src/config.rs` so that Rocket knows the URL of this "plume" database.
igalic comentou 4 meses atrás

yesno… we want to retain our ConnectionCustomization, so we’re keeping our own init_pool().

yesno… we want to retain our `ConnectionCustomization`, so we're keeping our own `init_pool()`.
igalic marked this conversation as resolved
igalic alterou o título de add rocket_contrib as dependency para extract DbConn from PlumeRocket 4 meses atrás
igalic comentou 4 meses atrás
Proprietário
  • pass DbConn in as ref instead of Copying it around.

This will help with the async migration, as we’re currently passing all of PlumeRocket around as ref, which means that it ends up sitting somewhere in a function, until it’s .awaited.

This can create lead us into a big mess, which may be impossible to untangle, so this should help not running into that to begin with.

> - pass `DbConn` in as `ref` instead of `Copy`ing it around. This will help with the `async` migration, as we're currently passing all of PlumeRocket around as `ref`, which means that it ends up sitting *somewhere* in a function, until it's `.await`ed. This can create lead us into a big mess, which may be impossible to untangle, so this should help *not* running into that to begin with.
igalic comentou 4 meses atrás
Proprietário

closing in favour of #813

closing in favour of #813
igalic closed this pull request 4 meses atrás
Por favor reabra este pull request para aplicar o merge.
Acesse para participar desta conversação.
No reviewers
Sem marco
Sem responsável
2 participante(s)
Notificações
Data limite

Data limite não informada.

Dependências

Atualmente este pull request não tem dependências.

Carregando…
Ainda não há conteúdo.