extract DbConn from PlumeRocket #805

igalic · 2020-07-19T11:37:20Z

igalic comentou

2020-07-19 11:37:20 +00:00

Proprietário(a)

in the following Pull Request, we'lle extract DbConn from PlumeRocket, as suggested in #797

use rocket_contrib's #[database] to implement our DbConn
we do not use #[database]'s connection setup, retaining our own init_pool() and ConnectionCustomization!
pass DbConn in as ref instead of Copying it around.

in the following Pull Request, we'lle extract `DbConn` from `PlumeRocket`, as suggested in https://git.joinplu.me/Plume/Plume/issues/797 - use rocket_contrib's `#[database]` to implement our `DbConn` - we do *not* use `#[database]`'s connection setup, retaining our own `init_pool()` and `ConnectionCustomization`! - pass `DbConn` in as `ref` instead of `Copy`ing it around.

👍 1

kiwii revisou 2020-07-19 12:08:57 +00:00

plume-models/src/db_conn.rs Desatualizado

					
				@ -41,3 +12,1 @@

				        &self.0

				    }

				}

				#[database("plume")]

kiwii comentou

2020-07-19 12:08:57 +00:00

Proprietário(a)

I think you'll have to edit plume-models/src/config.rs so that Rocket knows the URL of this "plume" database.

I think you'll have to edit `plume-models/src/config.rs` so that Rocket knows the URL of this "plume" database.

igalic comentou

2020-07-20 12:01:43 +00:00

Autor

Proprietário(a)

yesno… we want to retain our ConnectionCustomization, so we're keeping our own init_pool().

yesno… we want to retain our `ConnectionCustomization`, so we're keeping our own `init_pool()`.

igalic marcou esta conversa como resolvida

igalic forçou o push refactor/extract-dbconn de 9c7af7dcd4 para 3d8785e97b

2020-07-19 17:02:38 +00:00

Comparar

igalic alterou o título de ~~add rocket_contrib as dependency~~ para extract DbConn from PlumeRocket

2020-07-20 11:56:24 +00:00

igalic comentou

2020-07-20 12:00:01 +00:00

Autor

Proprietário(a)

pass DbConn in as ref instead of Copying it around.

This will help with the async migration, as we're currently passing all of PlumeRocket around as ref, which means that it ends up sitting somewhere in a function, until it's .awaited.

This can create lead us into a big mess, which may be impossible to untangle, so this should help not running into that to begin with.

> - pass `DbConn` in as `ref` instead of `Copy`ing it around. This will help with the `async` migration, as we're currently passing all of PlumeRocket around as `ref`, which means that it ends up sitting *somewhere* in a function, until it's `.await`ed. This can create lead us into a big mess, which may be impossible to untangle, so this should help *not* running into that to begin with.

igalic adicionou 1 commit 2020-07-20 14:12:51 +00:00

remove DbConn from PlumeRocket e19069f750

this means compilation fails, and for the next while, we'll try to make
it compile again ;)

igalic referenciado este pull request

2020-07-26 19:36:17 +00:00

WIP: Extract DbConn, Searcher & Worker into Riker Actors #813

igalic comentou

2020-07-26 19:37:55 +00:00

Autor

Proprietário(a)

closing in favour of #813

igalic fechou este pull request

2020-07-26 19:37:56 +00:00

KitaitiMakoto referenciado este pull request

2021-01-30 08:00:25 +00:00

Reduce database connnections required for routes::users::details #888

KitaitiMakoto referenciado este pull request

2021-01-30 13:32:32 +00:00

Close #888 Extract DbConn from PlumeRocket #889

Pull Request Fechado

Por favor reabra este pull request para aplicar o merge.

Inicie a sessão para participar desta conversa.

Sem revisor

Sem marco

Sem projeto

Sem responsáveis

2 participantes

Notificações

Data limite

A data limite é inválida ou está fora do intervalo permitido. Por favor, use o formato "yyyy-mm-dd".

Não há data limite definida.

Dependências

Não há dependências definidas.

Referência: Plume/Plume#805

Linhas
Colunas