A exclusão de uma branch é permanente. Isto NÃO PODERÁ ser desfeito. Continuar?
#805 extract DbConn from PlumeRocket
Fechado
igalic
quer aplicar o merge de 2 commits de igalic/Plume:refactor/extract-dbconn em main
Revisores
No reviewers
Etiquetas
Sem etiqueta
Marco
Sem marco
Responsáveis
Sem responsável
2 participante(s)
Notificações
Data limite
Data limite não informada.
Dependências
Atualmente este pull request não tem dependências.
Carregando…
Ainda não há conteúdo.
Excluir branch 'igalic/Plume:refactor/extract-dbconn'
in the following Pull Request, we’lle extract
DbConnfromPlumeRocket, as suggested in #797#[database]to implement ourDbConn#[database]'s connection setup, retaining our owninit_pool()andConnectionCustomization!DbConnin asrefinstead ofCopying it around.I think you’ll have to edit
plume-models/src/config.rsso that Rocket knows the URL of this “plume” database.yesno… we want to retain our
ConnectionCustomization, so we’re keeping our owninit_pool().add rocket_contrib as dependencypara extract DbConn from PlumeRocket 11 meses atrásThis will help with the
asyncmigration, as we’re currently passing all of PlumeRocket around asref, which means that it ends up sitting somewhere in a function, until it’s.awaited.This can create lead us into a big mess, which may be impossible to untangle, so this should help not running into that to begin with.
closing in favour of #813