8
16
Derivar 22

extract DbConn from PlumeRocket #805

fechada(s)
igalic quer integrar 2 cometimento(s) do ramo igalic/Plume:refactor/extract-dbconn no ramo main
Proprietário(a)

in the following Pull Request, we'lle extract DbConn from PlumeRocket, as suggested in #797

  • use rocket_contrib's #[database] to implement our DbConn
  • we do not use #[database]'s connection setup, retaining our own init_pool() and ConnectionCustomization!
  • pass DbConn in as ref instead of Copying it around.
in the following Pull Request, we'lle extract `DbConn` from `PlumeRocket`, as suggested in https://git.joinplu.me/Plume/Plume/issues/797 - use rocket_contrib's `#[database]` to implement our `DbConn` - we do *not* use `#[database]`'s connection setup, retaining our own `init_pool()` and `ConnectionCustomization`! - pass `DbConn` in as `ref` instead of `Copy`ing it around.
kiwii reviu há 4 anos
@ -41,3 +12,1 @@
&self.0
}
}
#[database("plume")]
kiwii comentou há 4 anos
Proprietário(a)

I think you'll have to edit plume-models/src/config.rs so that Rocket knows the URL of this "plume" database.

I think you'll have to edit `plume-models/src/config.rs` so that Rocket knows the URL of this "plume" database.
Remetente
Proprietário(a)

yesno… we want to retain our ConnectionCustomization, so we're keeping our own init_pool().

yesno… we want to retain our `ConnectionCustomization`, so we're keeping our own `init_pool()`.
igalic marcou este diálogo como estando concluído
igalic forçou o envio refactor/extract-dbconn de 9c7af7dcd4 para 3d8785e97b há 4 anos
igalic mudou o título de add rocket_contrib as dependency para extract DbConn from PlumeRocket há 4 anos
Remetente
Proprietário(a)
  • pass DbConn in as ref instead of Copying it around.

This will help with the async migration, as we're currently passing all of PlumeRocket around as ref, which means that it ends up sitting somewhere in a function, until it's .awaited.

This can create lead us into a big mess, which may be impossible to untangle, so this should help not running into that to begin with.

> - pass `DbConn` in as `ref` instead of `Copy`ing it around. This will help with the `async` migration, as we're currently passing all of PlumeRocket around as `ref`, which means that it ends up sitting *somewhere* in a function, until it's `.await`ed. This can create lead us into a big mess, which may be impossible to untangle, so this should help *not* running into that to begin with.
igalic adicionou 1 cometimento há 4 anos
e19069f750
remove DbConn from PlumeRocket
this means compilation fails, and for the next while, we'll try to make
it compile again ;)
Remetente
Proprietário(a)

closing in favour of #813

closing in favour of #813
igalic fechou este pedido de integração há 4 anos
Reabra este pedido de integração para executar uma integração.
Inicie a sessão para participar neste diálogo.
Sem revisores
Sem etapa
Sem encarregados
2 Participantes
Notificações
Data de vencimento
A data de vencimento é inválida ou está fora do intervalo permitido. Por favor, use o formato 'aaaa-mm-dd'.

Sem data de vencimento definida.

Dependências

Não estão definidas dependências.

Referência: Plume/Plume#805
Carregando…
Ainda não há conteúdo.