extract DbConn from PlumeRocket
#805
fechada(s)
igalic
quer integrar 2 cometimento(s) do ramo igalic/Plume:refactor/extract-dbconn
no ramo main
puxar de: igalic/Plume:refactor/extract-dbconn
integrar em: Plume:main
Plume:paginate-search-init
Plume:main
Plume:s3
Plume:fix-delete-user
Plume:timeline-cli
Plume:blog-title
Plume:signature
Plume:remove-dup-images
Plume:ldap-non-anon
Plume:drone-ci
Plume:DearRude/force-lang
Plume:igalic/go/async-all-mut
Plume:go/async
Plume:floreal/translations-update
Plume:missing-docs
Plume:RAOF/fix-arm64-build
Plume:epsilon-phase/authorized-fetch
Plume:upgrade
Plume:improve-the-editor-once-again
Plume:igalic/feat/custom-fairing-domains
Plume:feature/ldap
Plume:test/dotenv_error
Plume:fix-mobile-margin
Revisores
Solicitar revisão
Sem revisores
Rótulos
Retirar rótulos
Related to the REST API
Code running on the server
Stuff related to Federation
Related to the front-end
Translations, and related code
More about project management or code than the project itself
The building, or installation process of Plume
Something isn't working
We need to talk
New feature or request
This is a new feature
Compatibility with different browsers, readers and OS
Related to an external package that Plume uses
UI/UX related issues and PRs
Good for newcomers
Extra attention is needed
Issues affecting only mobile UX
How elements're rendered out for the end user
Something else needs to be fixed first
This issue or pull request already exists
This PR is not complete yet
Issues concern a limited number of instances
This doesn't seem right
Need to be discussed by the community (on Loomio)
This PR is ready to be reviewed
Proposed ideas worth considering
This is issue has been created after a vote on Loomio
This will not be worked on
Aplicar rótulos
A: API
Related to the REST API
A: Backend
Code running on the server
A: Federation
Stuff related to Federation
A: Front-End
Related to the front-end
A: I18N
Translations, and related code
A: Meta
More about project management or code than the project itself
A: Security
Build
The building, or installation process of Plume
C: Bug
Something isn't working
C: Discussion
We need to talk
C: Enhancement
New feature or request
C: Feature
This is a new feature
Compatibility
Compatibility with different browsers, readers and OS
Dependency
Related to an external package that Plume uses
Design
UI/UX related issues and PRs
Documentation
Good first issue
Good for newcomers
Help welcome
Extra attention is needed
Mobile
Issues affecting only mobile UX
Rendering
How elements're rendered out for the end user
S: Blocked
Something else needs to be fixed first
S: Duplicate
This issue or pull request already exists
S: Incomplete
This PR is not complete yet
S: Instance specific
Issues concern a limited number of instances
S: Invalid
This doesn't seem right
S: Needs Voting/Discussion
Need to be discussed by the community (on Loomio)
S: Ready for review
This PR is ready to be reviewed
Suggestion
Proposed ideas worth considering
S: Voted on Loomio
This is issue has been created after a vote on Loomio
S: Wontfix
This will not be worked on
Sem rótulo
A: API
A: Backend
A: Federation
A: Front-End
A: I18N
A: Meta
A: Security
Build
C: Bug
C: Discussion
C: Enhancement
C: Feature
Compatibility
Dependency
Design
Documentation
Good first issue
Help welcome
Mobile
Rendering
S: Blocked
S: Duplicate
S: Incomplete
S: Instance specific
S: Invalid
S: Needs Voting/Discussion
S: Ready for review
Suggestion
S: Voted on Loomio
S: Wontfix
Etapa
Definir etapa
Limpar etapa
Sem itens
Sem etapa
Encarregados
Definir encarregados
Retirar todos os encarregados
Sem encarregados
2 Participantes
Notificações
Data de vencimento
A data de vencimento é inválida ou está fora do intervalo permitido. Por favor, use o formato 'aaaa-mm-dd'.
Sem data de vencimento definida.
Dependências
Não estão definidas dependências.
Referência: Plume/Plume#805
Criar uma nova questão referindo esta
Ainda não há conteúdo.
Eliminar o ramo 'igalic/Plume:refactor/extract-dbconn'
Eliminar um ramo é algo permanente. NÃO PODERÁ ser revertido. Quer continuar?
Não
Sim
in the following Pull Request, we'lle extract
DbConn
fromPlumeRocket
, as suggested in #797#[database]
to implement ourDbConn
#[database]
's connection setup, retaining our owninit_pool()
andConnectionCustomization
!DbConn
in asref
instead ofCopy
ing it around.@ -41,3 +12,1 @@
&self.0
}
}
#[database("plume")]
I think you'll have to edit
plume-models/src/config.rs
so that Rocket knows the URL of this "plume" database.yesno… we want to retain our
ConnectionCustomization
, so we're keeping our owninit_pool()
.9c7af7dcd4
para3d8785e97b
há 4 anosadd rocket_contrib as dependencypara extract DbConn from PlumeRocket há 4 anosThis will help with the
async
migration, as we're currently passing all of PlumeRocket around asref
, which means that it ends up sitting somewhere in a function, until it's.await
ed.This can create lead us into a big mess, which may be impossible to untangle, so this should help not running into that to begin with.
closing in favour of #813