#805 extract DbConn from PlumeRocket

Fechadas
igalic quer integrar 2 cometimentos de %!<(string=igalic/Plume:refactor/extract-dbconn)/code> em main
igalic comentado há 4 meses

in the following Pull Request, we’lle extract DbConn from PlumeRocket, as suggested in #797

  • use rocket_contrib’s #[database] to implement our DbConn
  • we do not use #[database]'s connection setup, retaining our own init_pool() and ConnectionCustomization!
  • pass DbConn in as ref instead of Copying it around.
in the following Pull Request, we'lle extract `DbConn` from `PlumeRocket`, as suggested in https://git.joinplu.me/Plume/Plume/issues/797 - use rocket_contrib's `#[database]` to implement our `DbConn` - we do *not* use `#[database]`'s connection setup, retaining our own `init_pool()` and `ConnectionCustomization`! - pass `DbConn` in as `ref` instead of `Copy`ing it around.
kiwii reviu há 4 meses
plume-models/src/db_conn.rs
@@ -41,3 +12,1 @@
&self.0
}
}
#[database("plume")]
kiwii comentado há 4 meses

I think you’ll have to edit plume-models/src/config.rs so that Rocket knows the URL of this “plume” database.

I think you'll have to edit `plume-models/src/config.rs` so that Rocket knows the URL of this "plume" database.
igalic comentado há 4 meses

yesno… we want to retain our ConnectionCustomization, so we’re keeping our own init_pool().

yesno… we want to retain our `ConnectionCustomization`, so we're keeping our own `init_pool()`.
igalic marcou este diálogo como resolvido
igalic mudou o título de add rocket_contrib as dependency para extract DbConn from PlumeRocket há 4 meses
igalic comentado há 4 meses
Proprietário(a)
  • pass DbConn in as ref instead of Copying it around.

This will help with the async migration, as we’re currently passing all of PlumeRocket around as ref, which means that it ends up sitting somewhere in a function, until it’s .awaited.

This can create lead us into a big mess, which may be impossible to untangle, so this should help not running into that to begin with.

> - pass `DbConn` in as `ref` instead of `Copy`ing it around. This will help with the `async` migration, as we're currently passing all of PlumeRocket around as `ref`, which means that it ends up sitting *somewhere* in a function, until it's `.await`ed. This can create lead us into a big mess, which may be impossible to untangle, so this should help *not* running into that to begin with.
igalic comentado há 4 meses
Proprietário(a)

closing in favour of #813

closing in favour of #813
igalic fechou este pedido de integração há 4 meses
Reabra este pedido de integração para executar uma integração.
Inicie a sessão para participar neste diálogo.
Sem revisores
Sem etapa
Sem responsáveis
2 Participantes
Notificações
Date limite

Sem data limite definida.

Dependências

Este pedido de integração não tem quaisquer dependências, neste momento.

Carregando…
Ainda não há conteúdo.