extract DbConn from PlumeRocket #805

Закрыто
igalic хочет влить 2 коммит(ов) из igalic/Plume:refactor/extract-dbconn в main
igalic оставлен комментарий 2020-07-19 11:37:20 +00:00
Владелец

in the following Pull Request, we'lle extract DbConn from PlumeRocket, as suggested in #797

  • use rocket_contrib's #[database] to implement our DbConn
  • we do not use #[database]'s connection setup, retaining our own init_pool() and ConnectionCustomization!
  • pass DbConn in as ref instead of Copying it around.
in the following Pull Request, we'lle extract `DbConn` from `PlumeRocket`, as suggested in https://git.joinplu.me/Plume/Plume/issues/797 - use rocket_contrib's `#[database]` to implement our `DbConn` - we do *not* use `#[database]`'s connection setup, retaining our own `init_pool()` and `ConnectionCustomization`! - pass `DbConn` in as `ref` instead of `Copy`ing it around.
kiwii оставлена рецензия 2020-07-19 12:08:57 +00:00
plume-models/src/db_conn.rs Устаревшее
@ -41,3 +12,1 @@
&self.0
}
}
#[database("plume")]
kiwii оставлен комментарий 2020-07-19 12:08:57 +00:00
Владелец

I think you'll have to edit plume-models/src/config.rs so that Rocket knows the URL of this "plume" database.

I think you'll have to edit `plume-models/src/config.rs` so that Rocket knows the URL of this "plume" database.
igalic оставлен комментарий 2020-07-20 12:01:43 +00:00
Автор
Владелец

yesno… we want to retain our ConnectionCustomization, so we're keeping our own init_pool().

yesno… we want to retain our `ConnectionCustomization`, so we're keeping our own `init_pool()`.
igalic пометить это обсуждение как разрешённое
igalic форсированное обновление изменений refactor/extract-dbconn 3d8785e97b вместо 9c7af7dcd4 2020-07-19 17:02:38 +00:00 Сравнить
igalic изменил(а) заголовок с add rocket_contrib as dependency на extract DbConn from PlumeRocket 2020-07-20 11:56:24 +00:00
igalic оставлен комментарий 2020-07-20 12:00:01 +00:00
Автор
Владелец
  • pass DbConn in as ref instead of Copying it around.

This will help with the async migration, as we're currently passing all of PlumeRocket around as ref, which means that it ends up sitting somewhere in a function, until it's .awaited.

This can create lead us into a big mess, which may be impossible to untangle, so this should help not running into that to begin with.

> - pass `DbConn` in as `ref` instead of `Copy`ing it around. This will help with the `async` migration, as we're currently passing all of PlumeRocket around as `ref`, which means that it ends up sitting *somewhere* in a function, until it's `.await`ed. This can create lead us into a big mess, which may be impossible to untangle, so this should help *not* running into that to begin with.
igalic добавлен 1 коммит 2020-07-20 14:12:51 +00:00
this means compilation fails, and for the next while, we'll try to make
it compile again ;)
igalic оставлен комментарий 2020-07-26 19:37:55 +00:00
Автор
Владелец

closing in favour of #813

closing in favour of #813
igalic закрыл этот запрос на слияние 2020-07-26 19:37:56 +00:00

Запрос на слияние закрыт

Войдите, чтобы присоединиться к обсуждению.
Нет рецензентов
Нет этапа
Нет проекта
Нет назначенных
2 участников
Уведомления
Срок выполнения
Срок выполнения недействителен или находится за пределами допустимого диапазона. Пожалуйста, используйте формат «гггг-мм-дд».

Срок выполнения не установлен.

Зависимости

Зависимостей нет.

Ссылка: Plume/Plume#805
Описание отсутствует.