extract DbConn from PlumeRocket #805

Stängd
igalic vill sammanfoga 2 incheckningar från s[2]s in i main
igalic kommenterad 4 år sedan
Ägare

in the following Pull Request, we'lle extract DbConn from PlumeRocket, as suggested in #797

  • use rocket_contrib's #[database] to implement our DbConn
  • we do not use #[database]'s connection setup, retaining our own init_pool() and ConnectionCustomization!
  • pass DbConn in as ref instead of Copying it around.
in the following Pull Request, we'lle extract `DbConn` from `PlumeRocket`, as suggested in https://git.joinplu.me/Plume/Plume/issues/797 - use rocket_contrib's `#[database]` to implement our `DbConn` - we do *not* use `#[database]`'s connection setup, retaining our own `init_pool()` and `ConnectionCustomization`! - pass `DbConn` in as `ref` instead of `Copy`ing it around.
kiwii granskad av 4 år sedan
@ -41,3 +12,1 @@
&self.0
}
}
#[database("plume")]
kiwii kommenterad 4 år sedan
Ägare

I think you'll have to edit plume-models/src/config.rs so that Rocket knows the URL of this "plume" database.

I think you'll have to edit `plume-models/src/config.rs` so that Rocket knows the URL of this "plume" database.
igalic kommenterad 4 år sedan
Skapare
Ägare

yesno… we want to retain our ConnectionCustomization, so we're keeping our own init_pool().

yesno… we want to retain our `ConnectionCustomization`, so we're keeping our own `init_pool()`.
igalic markerade denna konversation som löst
igalic force-pushed refactor/extract-dbconn from 9c7af7dcd4 to 3d8785e97b 4 år sedan
igalic ändrade titeln från add rocket_contrib as dependency till extract DbConn from PlumeRocket 4 år sedan
igalic kommenterad 4 år sedan
Skapare
Ägare
  • pass DbConn in as ref instead of Copying it around.

This will help with the async migration, as we're currently passing all of PlumeRocket around as ref, which means that it ends up sitting somewhere in a function, until it's .awaited.

This can create lead us into a big mess, which may be impossible to untangle, so this should help not running into that to begin with.

> - pass `DbConn` in as `ref` instead of `Copy`ing it around. This will help with the `async` migration, as we're currently passing all of PlumeRocket around as `ref`, which means that it ends up sitting *somewhere* in a function, until it's `.await`ed. This can create lead us into a big mess, which may be impossible to untangle, so this should help *not* running into that to begin with.
igalic lade till 1 commit 4 år sedan
e19069f750
remove DbConn from PlumeRocket
this means compilation fails, and for the next while, we'll try to make
it compile again ;)
igalic kommenterad 4 år sedan
Skapare
Ägare

closing in favour of #813

closing in favour of #813
igalic closed this pull request 4 år sedan
Vänligen återöppna denna Pull-förfrågan igen för att utföra sammanfogningen.
Logga in för att delta i denna konversation.
Inga granskare
Ingen Milsten
Ingen tilldelad
2 Deltagare
Notiser
Förfallodatum
Förfallodatumet är ogiltigt eller utanför gränserna. Använd formatet 'åååå-mm-dd'.

Inget förfallodatum satt.

Beroenden

No dependencies set.

Reference: Plume/Plume#805
Laddar…
Det finns inget innehåll än.