#805 extract DbConn from PlumeRocket

Kapalı
igalic igalic/Plume:refactor/extract-dbconn içindeki 2 işlemeyi main ile birleştirmek istiyor
igalic 4 ay önce yorum yaptı

in the following Pull Request, we’lle extract DbConn from PlumeRocket, as suggested in #797

  • use rocket_contrib’s #[database] to implement our DbConn
  • we do not use #[database]'s connection setup, retaining our own init_pool() and ConnectionCustomization!
  • pass DbConn in as ref instead of Copying it around.
in the following Pull Request, we'lle extract `DbConn` from `PlumeRocket`, as suggested in https://git.joinplu.me/Plume/Plume/issues/797 - use rocket_contrib's `#[database]` to implement our `DbConn` - we do *not* use `#[database]`'s connection setup, retaining our own `init_pool()` and `ConnectionCustomization`! - pass `DbConn` in as `ref` instead of `Copy`ing it around.
kiwii 4 ay önce incelendi
plume-models/src/db_conn.rs
@@ -41,3 +12,1 @@
&self.0
}
}
#[database("plume")]
kiwii 4 ay önce yorum yaptı

I think you’ll have to edit plume-models/src/config.rs so that Rocket knows the URL of this “plume” database.

I think you'll have to edit `plume-models/src/config.rs` so that Rocket knows the URL of this "plume" database.
igalic 4 ay önce yorum yaptı

yesno… we want to retain our ConnectionCustomization, so we’re keeping our own init_pool().

yesno… we want to retain our `ConnectionCustomization`, so we're keeping our own `init_pool()`.
igalic bu konuşmayı çözümlenmiş olarak işaretledi
igalic başlık add rocket_contrib as dependency iken extract DbConn from PlumeRocket olarak değiştirildi 4 ay önce
igalic 4 ay önce yorum yaptı
Sahibi
  • pass DbConn in as ref instead of Copying it around.

This will help with the async migration, as we’re currently passing all of PlumeRocket around as ref, which means that it ends up sitting somewhere in a function, until it’s .awaited.

This can create lead us into a big mess, which may be impossible to untangle, so this should help not running into that to begin with.

> - pass `DbConn` in as `ref` instead of `Copy`ing it around. This will help with the `async` migration, as we're currently passing all of PlumeRocket around as `ref`, which means that it ends up sitting *somewhere* in a function, until it's `.await`ed. This can create lead us into a big mess, which may be impossible to untangle, so this should help *not* running into that to begin with.
igalic 4 ay önce yorum yaptı
Sahibi

closing in favour of #813

closing in favour of #813
igalic 4 ay önce değişiklik isteğini kapattı
Lütfen birleştirme gerçekleştirmek için bu değişiklik isteğini yeniden açın.
Bu konuşmaya katılmak için oturum aç.
Değerlendirici yok
Kilometre Taşı Yok
Atanan Kişi Yok
2 Katılımcı
Bildirimler
Bitiş Tarihi

Bitiş tarihi atanmadı.

Bağımlılıklar

Bu çekme isteği henüz bir bağımlılık içermiyor.

Yükleniyor…
Henüz bir içerik yok.