in the following Pull Request, we’lle extract DbConn from PlumeRocket, as suggested in #797
use rocket_contrib’s #[database] to implement our DbConn
we do not use #[database]'s connection setup, retaining our own init_pool() and ConnectionCustomization!
pass DbConn in as ref instead of Copying it around.
in the following Pull Request, we'lle extract `DbConn` from `PlumeRocket`, as suggested in https://git.joinplu.me/Plume/Plume/issues/797
- use rocket_contrib's `#[database]` to implement our `DbConn`
- we do *not* use `#[database]`'s connection setup, retaining our own `init_pool()` and `ConnectionCustomization`!
- pass `DbConn` in as `ref` instead of `Copy`ing it around.
pass DbConn in as ref instead of Copying it around.
This will help with the async migration, as we’re currently passing all of PlumeRocket around as ref, which means that it ends up sitting somewhere in a function, until it’s .awaited.
This can create lead us into a big mess, which may be impossible to untangle, so this should help not running into that to begin with.
> - pass `DbConn` in as `ref` instead of `Copy`ing it around.
This will help with the `async` migration, as we're currently passing all of PlumeRocket around as `ref`, which means that it ends up sitting *somewhere* in a function, until it's `.await`ed.
This can create lead us into a big mess, which may be impossible to untangle, so this should help *not* running into that to begin with.
in the following Pull Request, we’lle extract
DbConnfromPlumeRocket, as suggested in #797#[database]to implement ourDbConn#[database]'s connection setup, retaining our owninit_pool()andConnectionCustomization!DbConnin asrefinstead ofCopying it around.I think you’ll have to edit
plume-models/src/config.rsso that Rocket knows the URL of this “plume” database.yesno… we want to retain our
ConnectionCustomization, so we’re keeping our owninit_pool().add rocket_contrib as dependency为 extract DbConn from PlumeRocketThis will help with the
asyncmigration, as we’re currently passing all of PlumeRocket around asref, which means that it ends up sitting somewhere in a function, until it’s.awaited.This can create lead us into a big mess, which may be impossible to untangle, so this should help not running into that to begin with.
closing in favour of #813