extract DbConn from PlumeRocket #805

igalic · 2020-07-19T11:37:20Z

igalic 评论于

2020-07-19 11:37:20 +00:00

管理员

in the following Pull Request, we'lle extract DbConn from PlumeRocket, as suggested in #797

use rocket_contrib's #[database] to implement our DbConn
we do not use #[database]'s connection setup, retaining our own init_pool() and ConnectionCustomization!
pass DbConn in as ref instead of Copying it around.

in the following Pull Request, we'lle extract `DbConn` from `PlumeRocket`, as suggested in https://git.joinplu.me/Plume/Plume/issues/797 - use rocket_contrib's `#[database]` to implement our `DbConn` - we do *not* use `#[database]`'s connection setup, retaining our own `init_pool()` and `ConnectionCustomization`! - pass `DbConn` in as `ref` instead of `Copy`ing it around.

👍 1

kiwii 评审于 2020-07-19 12:08:57 +00:00

plume-models/src/db_conn.rs 已过时

					
				@ -41,3 +12,1 @@

				        &self.0

				    }

				}

				#[database("plume")]

kiwii 评论于

2020-07-19 12:08:57 +00:00

管理员

I think you'll have to edit plume-models/src/config.rs so that Rocket knows the URL of this "plume" database.

I think you'll have to edit `plume-models/src/config.rs` so that Rocket knows the URL of this "plume" database.

igalic 评论于

2020-07-20 12:01:43 +00:00

作者

管理员

yesno… we want to retain our ConnectionCustomization, so we're keeping our own init_pool().

yesno… we want to retain our `ConnectionCustomization`, so we're keeping our own `init_pool()`.

igalic 标记问题为已解决

igalic 于 2020-07-19 17:02:38 +00:00 强制推送 refactor/extract-dbconn，从 9c7af7dcd4，至 3d8785e97b 比较

igalic 于 2020-07-20 11:56:24 +00:00 修改标题 ~~add rocket_contrib as dependency~~ 为 extract DbConn from PlumeRocket

igalic 评论于

2020-07-20 12:00:01 +00:00

作者

管理员

pass DbConn in as ref instead of Copying it around.

This will help with the async migration, as we're currently passing all of PlumeRocket around as ref, which means that it ends up sitting somewhere in a function, until it's .awaited.

This can create lead us into a big mess, which may be impossible to untangle, so this should help not running into that to begin with.

> - pass `DbConn` in as `ref` instead of `Copy`ing it around. This will help with the `async` migration, as we're currently passing all of PlumeRocket around as `ref`, which means that it ends up sitting *somewhere* in a function, until it's `.await`ed. This can create lead us into a big mess, which may be impossible to untangle, so this should help *not* running into that to begin with.

igalic 于 2020-07-20 14:12:51 +00:00 推送了 1 个提交

remove DbConn from PlumeRocket e19069f750

this means compilation fails, and for the next while, we'll try to make
it compile again ;)

igalic 引用了合并请求

2020-07-26 19:36:17 +00:00

WIP: Extract DbConn, Searcher & Worker into Riker Actors #813

igalic 评论于

2020-07-26 19:37:55 +00:00

作者

管理员

closing in favour of #813

igalic 于

2020-07-26 19:37:56 +00:00

关闭此合并请求

KitaitiMakoto 引用了合并请求

2021-01-30 08:00:25 +00:00

Reduce database connnections required for routes::users::details #888

KitaitiMakoto 引用了合并请求

2021-01-30 13:32:32 +00:00

Close #888 Extract DbConn from PlumeRocket #889

合并请求已关闭

请重新创建此合并请求。

登录并参与到对话中。

无评审员

未选择里程碑

暂无项目

未指派成员

2 位参与者

通知

到期时间

到期日期无效或超出范围。请使用“yyyy-mm-dd”格式。

未设置到期时间。

依赖工单

没有设置依赖项。

引用：Plume/Plume#805

行数
列数