建立合併請求

#805 extract DbConn from PlumeRocket

已關閉

igalic wants to merge 2 commits from igalic/Plume:refactor/extract-dbconn into main

in the following Pull Request, we’lle extract DbConn from PlumeRocket, as suggested in #797

use rocket_contrib’s #[database] to implement our DbConn
we do not use #[database]'s connection setup, retaining our own init_pool() and ConnectionCustomization!
pass DbConn in as ref instead of Copying it around.

👍 1

kiwii reviewed 4 月之前

plume-models/src/db_conn.rs

igalic changed title from ~~add rocket_contrib as dependency~~ to extract DbConn from PlumeRocket 4 月之前

pass DbConn in as ref instead of Copying it around.

This will help with the async migration, as we’re currently passing all of PlumeRocket around as ref, which means that it ends up sitting somewhere in a function, until it’s .awaited.

This can create lead us into a big mess, which may be impossible to untangle, so this should help not running into that to begin with.

igalic referenced this pull request 4 月之前

WIP: Extract DbConn, Searcher & Worker into Riker Actors #813

closing in favour of #813

igalic closed this pull request 4 月之前

請重新開啟合併請求來完成合併操作。

登入才能加入這對話。

No reviewers

未選擇標籤

未選擇里程碑

No Assignees

2 參與者

訊息

截止日期

未設定截止日期。

Dependencies

This pull request currently doesn't have any dependencies.

@@ -41,3 +12,1 @@
         &self.0
     }
 }
 #[database("plume")]