Plume/pulldown-cmark
5
0
Fork 2
Code Issues Pull requests Releases Wiki Activity

Remove dir=auto from <li> #1

Closed
ahangarha wants to merge 1 commit from ahangarha/pulldown-cmark:ahangarha-patch-1 into bidi-plume
pull from: ahangarha/pulldown-cmark:ahangarha-patch-1
merge into: Plume:bidi-plume
Conversation 1 Commits 1 Files changed 1 -7
ahangarha commented 2021-06-20 15:58:41 +00:00
First-time contributor
Copy link

Currently it makes the list like the following screenshot:
image

It should become like this:
image

This is the article from which I took the screenshot: ما و نسبت‌مان با سند راهبردی

Currently it makes the list like the following screenshot: ![image](/attachments/5ee38545-f9c6-4eaf-a7fb-9cdb68273582) It should become like this: ![image](/attachments/c567d12b-6401-4a49-b63f-e34b2f0e2ca8) This is the article from which I took the screenshot: [ما و نسبت‌مان با سند راهبردی](https://fediverse.blog/~/%D8%A2%D8%B2%D8%A7%D8%AF/%D9%85%D8%A7-%D9%88-%D9%86%D8%B3%D8%A8%D8%AA%E2%80%8C%D9%85%D8%A7%D9%86-%D8%A8%D8%A7-%D8%B3%D9%86%D8%AF-%D8%B1%D8%A7%D9%87%D8%A8%D8%B1%D8%AF%DB%8C)
image.png
83 KiB
image.png
84 KiB
trinity-1686a reviewed 2021-07-06 09:26:07 +00:00
src/html.rs
@ -238,4 +235,0 @@
} else {
self.write("\n<li dir=\"auto\">")
}
}
trinity-1686a commented 2021-07-06 09:26:07 +00:00
Owner
Copy link

Don't remove the whole block as it would transform lists to plain text. Just remove dir=\"auto\" from both calls to write

Don't remove the whole block as it would transform lists to plain text. Just remove ` dir=\"auto\"` from both calls to write
👍 1
ahangarha commented 2021-07-10 07:37:08 +00:00
Author
First-time contributor
Copy link

I didn't intended to remove whole block. Frankly I don't know how this has taken place. Feel free to make the appropriate modification.

Thanks for checking the detail.

I didn't intended to remove whole block. Frankly I don't know how this has taken place. Feel free to make the appropriate modification. Thanks for checking the detail.
trinity-1686a commented 2021-07-10 11:29:01 +00:00
Owner
Copy link

I've added the changes among some other things in 58514a67a5

I've added the changes among some other things in 58514a67a5
trinity-1686a closed this pull request 2021-07-10 11:29:04 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Plume/pulldown-cmark#1
No description provided.
Delete branch "ahangarha/pulldown-cmark:ahangarha-patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?