Plume
/
pulldown-cmark
5
0
Fork 1
Code Issues Pull Requests Releases Wiki Activity

Labels Milestones

Remove dir=auto from <li> #1

Closed
ahangarha wants to merge 1 commits from ahangarha/pulldown-cmark:ahangarha-patch-1 into bidi-plume
pull from: ahangarha/pulldown-cmark:ahangarha-patch-1
merge into: Plume:bidi-plume
Conversation 1 Commits 1 Files Changed 1
ahangarha commented 3 years ago

Currently it makes the list like the following screenshot:
image

It should become like this:
image

This is the article from which I took the screenshot: ما و نسبت‌مان با سند راهبردی

Currently it makes the list like the following screenshot: ![image](/attachments/5ee38545-f9c6-4eaf-a7fb-9cdb68273582) It should become like this: ![image](/attachments/c567d12b-6401-4a49-b63f-e34b2f0e2ca8) This is the article from which I took the screenshot: [ما و نسبت‌مان با سند راهبردی](https://fediverse.blog/~/%D8%A2%D8%B2%D8%A7%D8%AF/%D9%85%D8%A7-%D9%88-%D9%86%D8%B3%D8%A8%D8%AA%E2%80%8C%D9%85%D8%A7%D9%86-%D8%A8%D8%A7-%D8%B3%D9%86%D8%AF-%D8%B1%D8%A7%D9%87%D8%A8%D8%B1%D8%AF%DB%8C)
image.png
83 KiB
image.png
84 KiB
trinity-1686a reviewed 3 years ago
src/html.rs
@ -238,4 +235,0 @@
} else {
self.write("\n<li dir=\"auto\">")
}
}
trinity-1686a commented 3 years ago
Owner

Don't remove the whole block as it would transform lists to plain text. Just remove dir=\"auto\" from both calls to write

Don't remove the whole block as it would transform lists to plain text. Just remove ` dir=\"auto\"` from both calls to write
👍 1
ahangarha commented 3 years ago
Poster

I didn't intended to remove whole block. Frankly I don't know how this has taken place. Feel free to make the appropriate modification.

Thanks for checking the detail.

I didn't intended to remove whole block. Frankly I don't know how this has taken place. Feel free to make the appropriate modification. Thanks for checking the detail.
trinity-1686a commented 3 years ago
Owner

I've added the changes among some other things in 58514a67a5

I've added the changes among some other things in 58514a67a5
trinity-1686a closed this pull request 3 years ago
Please reopen this pull request to perform a merge.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b ahangarha-ahangarha-patch-1 bidi-plume
git pull ahangarha-patch-1

Step 2:

Merge the changes and update on Forgejo.
git checkout bidi-plume
git merge --no-ff ahangarha-ahangarha-patch-1
git push origin bidi-plume
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Plume/pulldown-cmark#1
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'ahangarha/pulldown-cmark:ahangarha-patch-1'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes