Plume/pulldown-cmark
5
0
Fork 2
Code Issues Pull requests Releases Wiki Activity

Remove dir=auto from <li> #1

Closed
ahangarha wants to merge 1 commit from ahangarha/pulldown-cmark:ahangarha-patch-1 into bidi-plume
pull from: ahangarha/pulldown-cmark:ahangarha-patch-1
merge into: Plume:bidi-plume
Conversation 1 Commits 1 Files changed 1 -7
1 changed files with 0 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/html.rs
View file

@ -232,13 +232,6 @@ where
self.write("\n<ul dir=\"auto\">\n")
}
}
Tag::Item => {
if self.end_newline {
self.write("<li dir=\"auto\">")
} else {
self.write("\n<li dir=\"auto\">")
}
}
trinity-1686a commented 2021-07-06 09:26:07 +00:00
Review
Copy link

Don't remove the whole block as it would transform lists to plain text. Just remove dir=\"auto\" from both calls to write

Don't remove the whole block as it would transform lists to plain text. Just remove ` dir=\"auto\"` from both calls to write
👍 1
ahangarha commented 2021-07-10 07:37:08 +00:00
Review
Copy link

I didn't intended to remove whole block. Frankly I don't know how this has taken place. Feel free to make the appropriate modification.

Thanks for checking the detail.

I didn't intended to remove whole block. Frankly I don't know how this has taken place. Feel free to make the appropriate modification. Thanks for checking the detail.
Tag::Emphasis => self.write("<em>"),
Tag::Strong => self.write("<strong>"),
Tag::Strikethrough => self.write("<del>"),