- Dortmund
- https://igalic.co/
-
Infrastructure & Open Source
(Homoiconic Ops Witch)
- Joined on
2020-06-26
yesno… we want to retain our ConnectionCustomization, so we're keeping our own init_pool().
- pass
DbConnin asrefinstead ofCopying it around.
This will help with the async migration, as we're currently passing all of PlumeRocket around as ref, which means that it ends up sitting somewhere in a function, until it's .awaited.
This can create lead us into a big mess, which may be impossible to untangle, so this should help not running into that to begin with.
6de9a1f1c8
Merge pull request 'Recreate search index if its format is outdated' (#802) from KitaitiMakoto/Plume:invalid-index into main
010eac6c4a
Merge pull request 'upgrade rocket* to the latest stable' (#800) from igalic/Plume:update/rocket into main
administrators are users too. anyway, let's ear-mark this for a next round
this is a user-facing error message, so it should go thru translation
this is a user-facing error message, so it should go thru translation
is this a user-facing error message? should it go thru translation?
maybe we should put the above if let into this match as well…
I've created a basic example with riker and multi-type messages for how to replace Mailer: https://gist.github.com/igalic/119e0f9ab5c3c8f5a3d3f50a5e17ee3a
I've created a basic example with riker and multi-type messages for how to replace Searcher: https://gist.github.com/igalic/16ec36a4c9277b3b46f6bea032226189
in a similar fashion, we can replace Worker, which currently mostly sents broadcast messages to all subscribers.
why would we need to keep our restore an index which Plume cannot load?
what could the admin do, that we can't? (why aren't we doing that?)